scandic/web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged in fix/remove-useless-check (pull request #1844)

Browse Source 
fix: remove useless check since cmsreward is always defined

Approved-by: Chuma Mcphoy (We Ahead)
This commit is contained in:
Christian Andolf
2025-04-24 09:41:28 +00:00
parent d66a3aabdf f17c8005d4
commit 055f9ab139
1 changed files with 10 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/scandic-web/server/routers/contentstack/reward/query.ts
View File

@@ -284,23 +284,17 @@ export const rewardQueryRouter = router({
return null return null
} }
const surprises: Surprise[] = cmsRewards const surprises: Surprise[] = cmsRewards.map((cmsReward) => {
.map((cmsReward) => {
// Non-null assertion is used here because we know our reward exist // Non-null assertion is used here because we know our reward exist
const apiReward = unwrappedSurpriseRewards.find( const apiReward = unwrappedSurpriseRewards.find(
({ rewardId }) => rewardId === cmsReward.reward_id ({ rewardId }) => rewardId === cmsReward.reward_id
)! )!
if (!cmsReward) {
return null
}
return { return {
...apiReward, ...apiReward,
...cmsReward, ...cmsReward,
} }
}) })
.flatMap((surprises) => (surprises ? [surprises] : []))
metricsGetSurprises.success() metricsGetSurprises.success()