scandic/web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove useless check since cmsreward is always defined

Browse Source
This commit is contained in:
Christian Andolf
2025-04-23 11:22:45 +02:00
parent d66a3aabdf
commit f17c8005d4
1 changed files with 10 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
apps/scandic-web/server/routers/contentstack/reward/query.ts
View File

@@ -284,23 +284,17 @@ export const rewardQueryRouter = router({
return null
}
const surprises: Surprise[] = cmsRewards
.map((cmsReward) => {
// Non-null assertion is used here because we know our reward exist
const apiReward = unwrappedSurpriseRewards.find(
({ rewardId }) => rewardId === cmsReward.reward_id
)!
const surprises: Surprise[] = cmsRewards.map((cmsReward) => {
// Non-null assertion is used here because we know our reward exist
const apiReward = unwrappedSurpriseRewards.find(
({ rewardId }) => rewardId === cmsReward.reward_id
)!
if (!cmsReward) {
return null
}
return {
...apiReward,
...cmsReward,
}
})
.flatMap((surprises) => (surprises ? [surprises] : []))
return {
...apiReward,
...cmsReward,
}
})
metricsGetSurprises.success()