From f17c8005d4c7380cf09f4c38e8953569885a955f Mon Sep 17 00:00:00 2001
From: Christian Andolf <christian.andolf@scandichotels.com>
Date: Wed, 23 Apr 2025 11:22:45 +0200
Subject: [PATCH] fix: remove useless check since cmsreward is always defined

---
 .../routers/contentstack/reward/query.ts      | 26 +++++++------------
 1 file changed, 10 insertions(+), 16 deletions(-)

diff --git a/apps/scandic-web/server/routers/contentstack/reward/query.ts b/apps/scandic-web/server/routers/contentstack/reward/query.ts
index 732da5705..4f42ba4d5 100644
--- a/apps/scandic-web/server/routers/contentstack/reward/query.ts
+++ b/apps/scandic-web/server/routers/contentstack/reward/query.ts
@@ -284,23 +284,17 @@ export const rewardQueryRouter = router({
         return null
       }
 
-      const surprises: Surprise[] = cmsRewards
-        .map((cmsReward) => {
-          // Non-null assertion is used here because we know our reward exist
-          const apiReward = unwrappedSurpriseRewards.find(
-            ({ rewardId }) => rewardId === cmsReward.reward_id
-          )!
+      const surprises: Surprise[] = cmsRewards.map((cmsReward) => {
+        // Non-null assertion is used here because we know our reward exist
+        const apiReward = unwrappedSurpriseRewards.find(
+          ({ rewardId }) => rewardId === cmsReward.reward_id
+        )!
 
-          if (!cmsReward) {
-            return null
-          }
-
-          return {
-            ...apiReward,
-            ...cmsReward,
-          }
-        })
-        .flatMap((surprises) => (surprises ? [surprises] : []))
+        return {
+          ...apiReward,
+          ...cmsReward,
+        }
+      })
 
       metricsGetSurprises.success()