fix: remove useless check since cmsreward is always defined

This commit is contained in:
Christian Andolf
2025-04-23 11:22:45 +02:00
parent d66a3aabdf
commit f17c8005d4

View File

@@ -284,23 +284,17 @@ export const rewardQueryRouter = router({
return null return null
} }
const surprises: Surprise[] = cmsRewards const surprises: Surprise[] = cmsRewards.map((cmsReward) => {
.map((cmsReward) => { // Non-null assertion is used here because we know our reward exist
// Non-null assertion is used here because we know our reward exist const apiReward = unwrappedSurpriseRewards.find(
const apiReward = unwrappedSurpriseRewards.find( ({ rewardId }) => rewardId === cmsReward.reward_id
({ rewardId }) => rewardId === cmsReward.reward_id )!
)!
if (!cmsReward) { return {
return null ...apiReward,
} ...cmsReward,
}
return { })
...apiReward,
...cmsReward,
}
})
.flatMap((surprises) => (surprises ? [surprises] : []))
metricsGetSurprises.success() metricsGetSurprises.success()