scandic/web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged in fix/enable-surprises-flag (pull request #1749)

Browse Source 
fix: add new feature flag for surprises

Approved-by: Linus Flood
Approved-by: Chuma Mcphoy (We Ahead)
This commit is contained in:
Christian Andolf
2025-04-07 13:13:50 +00:00
parent 84becd1bb3 5e55b60807
commit c9e3680b6b
4 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
apps/scandic-web/.env.local.example
View File

@@ -57,6 +57,7 @@ NEXT_PUBLIC_HIDE_FOR_NEXT_RELEASE="false"
ENABLE_BOOKING_FLOW="false"
ENABLE_BOOKING_WIDGET="false"
ENABLE_BOOKING_WIDGET_HOTELRESERVATION_PATH="false"
ENABLE_SURPRISES="true"
SHOW_SITE_WIDE_ALERT="false"
SHOW_SIGNUP_FLOW="true"
@@ -68,4 +69,4 @@ SAS_POINT_TRANSFER_ENABLED="true"
SAS_API_ENDPOINT=""
SAS_AUTH_ENDPOINT=""
SAS_OCP_APIM=""
SAS_AUTH_CLIENTID=""
SAS_AUTH_CLIENTID=""

1
apps/scandic-web/.env.test
View File

@@ -49,6 +49,7 @@ TZ=UTC
ENABLE_BOOKING_FLOW="false"
ENABLE_BOOKING_WIDGET="false"
ENABLE_BOOKING_WIDGET_HOTELRESERVATION_PATH="false"
ENABLE_SURPRISES="true"
SHOW_SITE_WIDE_ALERT="false"
NEXT_PUBLIC_SENTRY_ENVIRONMENT="test"

2
apps/scandic-web/components/MyPages/Surprises/index.tsx
View File

@@ -4,7 +4,7 @@ import { serverClient } from "@/lib/trpc/server"
import SurprisesClient from "./Client"
export default async function Surprises() {
if (env.HIDE_FOR_NEXT_RELEASE) {
if (!env.ENABLE_SURPRISES) {
return null
}

8
apps/scandic-web/env/server.ts vendored
View File

@@ -134,6 +134,13 @@ export const env = createEnv({
// transform to boolean
.transform((s) => s === "true")
.default("true"),
ENABLE_SURPRISES: z
.string()
// only allow "true" or "false"
.refine((s) => s === "true" || s === "false")
// transform to boolean
.transform((s) => s === "true")
.default("false"),
SHOW_SITE_WIDE_ALERT: z
.string()
// only allow "true" or "false"
@@ -266,6 +273,7 @@ export const env = createEnv({
ENABLE_BOOKING_WIDGET: process.env.ENABLE_BOOKING_WIDGET,
ENABLE_BOOKING_WIDGET_HOTELRESERVATION_PATH:
process.env.ENABLE_BOOKING_WIDGET_HOTELRESERVATION_PATH,
ENABLE_SURPRISES: process.env.ENABLE_SURPRISES,
SHOW_SITE_WIDE_ALERT: process.env.SHOW_SITE_WIDE_ALERT,
SENTRY_ENVIRONMENT: process.env.NEXT_PUBLIC_SENTRY_ENVIRONMENT,
SENTRY_SERVER_SAMPLERATE: process.env.SENTRY_SERVER_SAMPLERATE,