scandic/web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged in fix/SW-1617-aa-tracking-ratecodetype- (pull request #2669)

Browse Source 
fix(SW-1617): Added rateCodeType in tracking for confirmation page

* fix(SW-1617): Added rateCodeType in tracking for confirmation page

* fix(SW-1617) Removed unnecessary comment


Approved-by: Bianca Widstam
Approved-by: Erik Tiekstra
This commit is contained in:
Hrishikesh Vaipurkar
2025-08-20 08:42:05 +00:00
parent dc9e38e02a
commit c6ed6d767e
4 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/scandic-web/components/HotelReservation/BookingConfirmation/Tracking/tracking.ts
View File

@@ -146,7 +146,7 @@ export function getTracking(
.join(",") .join(",")
.toLowerCase(), .toLowerCase(),
rateCodeName: rooms.map(constructRateCodeName).join(","), rateCodeName: rooms.map(constructRateCodeName).join(","),
//rateCodeType: , //TODO: Add when available in API. "regular, promotion, corporate etx", rateCodeType: rooms.map((r) => r.rateCodeType?.toLowerCase()).join(","),
region: hotel?.address.city, region: hotel?.address.city,
revenueCurrencyCode: [...new Set(rooms.map((r) => r.currencyCode))].join( revenueCurrencyCode: [...new Set(rooms.map((r) => r.currencyCode))].join(
"," ","

1
apps/scandic-web/components/HotelReservation/BookingConfirmation/utils.ts
View File

@@ -77,6 +77,7 @@ export function mapRoomState(
name: room.name, name: room.name,
packages: booking.packages, packages: booking.packages,
rateDefinition: booking.rateDefinition, rateDefinition: booking.rateDefinition,
rateCodeType: booking.bookingType,
refId: booking.refId, refId: booking.refId,
roomFeatures: booking.packages.filter((p) => p.type === "RoomFeature"), roomFeatures: booking.packages.filter((p) => p.type === "RoomFeature"),
roomPoints: booking.roomPoints, roomPoints: booking.roomPoints,

1
apps/scandic-web/types/stores/booking-confirmation.ts
View File

@@ -28,6 +28,7 @@ export interface Room {
packages: BookingConfirmation["booking"]["packages"] packages: BookingConfirmation["booking"]["packages"]
formattedRoomCost: string formattedRoomCost: string
rateDefinition: BookingConfirmation["booking"]["rateDefinition"] rateDefinition: BookingConfirmation["booking"]["rateDefinition"]
rateCodeType: BookingConfirmation["booking"]["bookingType"]
refId: string refId: string
roomFeatures?: PackageSchema[] | null roomFeatures?: PackageSchema[] | null
roomPoints: number roomPoints: number

1
packages/trpc/lib/routers/booking/output.ts
View File

@@ -208,6 +208,7 @@ export const bookingConfirmationSchema = z
attributes: z.object({ attributes: z.object({
adults: z.number().int(), adults: z.number().int(),
ancillary: ancillarySchema, ancillary: ancillarySchema,
bookingType: z.string().optional(),
cancelationNumber: z.string().nullable().default(""), cancelationNumber: z.string().nullable().default(""),
checkInDate: z.string().refine((val) => dt(val).isValid()), checkInDate: z.string().refine((val) => dt(val).isValid()),
checkOutDate: z.string().refine((val) => dt(val).isValid()), checkOutDate: z.string().refine((val) => dt(val).isValid()),