From c6ed6d767e745b879ffd087ed352694abbc2441c Mon Sep 17 00:00:00 2001 From: Hrishikesh Vaipurkar Date: Wed, 20 Aug 2025 08:42:05 +0000 Subject: [PATCH] Merged in fix/SW-1617-aa-tracking-ratecodetype- (pull request #2669) fix(SW-1617): Added rateCodeType in tracking for confirmation page * fix(SW-1617): Added rateCodeType in tracking for confirmation page * fix(SW-1617) Removed unnecessary comment Approved-by: Bianca Widstam Approved-by: Erik Tiekstra --- .../HotelReservation/BookingConfirmation/Tracking/tracking.ts | 2 +- .../components/HotelReservation/BookingConfirmation/utils.ts | 1 + apps/scandic-web/types/stores/booking-confirmation.ts | 1 + packages/trpc/lib/routers/booking/output.ts | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/scandic-web/components/HotelReservation/BookingConfirmation/Tracking/tracking.ts b/apps/scandic-web/components/HotelReservation/BookingConfirmation/Tracking/tracking.ts index 3ec0cb4a6..5e9157677 100644 --- a/apps/scandic-web/components/HotelReservation/BookingConfirmation/Tracking/tracking.ts +++ b/apps/scandic-web/components/HotelReservation/BookingConfirmation/Tracking/tracking.ts @@ -146,7 +146,7 @@ export function getTracking( .join(",") .toLowerCase(), rateCodeName: rooms.map(constructRateCodeName).join(","), - //rateCodeType: , //TODO: Add when available in API. "regular, promotion, corporate etx", + rateCodeType: rooms.map((r) => r.rateCodeType?.toLowerCase()).join(","), region: hotel?.address.city, revenueCurrencyCode: [...new Set(rooms.map((r) => r.currencyCode))].join( "," diff --git a/apps/scandic-web/components/HotelReservation/BookingConfirmation/utils.ts b/apps/scandic-web/components/HotelReservation/BookingConfirmation/utils.ts index 9af493cc2..9478a3cce 100644 --- a/apps/scandic-web/components/HotelReservation/BookingConfirmation/utils.ts +++ b/apps/scandic-web/components/HotelReservation/BookingConfirmation/utils.ts @@ -77,6 +77,7 @@ export function mapRoomState( name: room.name, packages: booking.packages, rateDefinition: booking.rateDefinition, + rateCodeType: booking.bookingType, refId: booking.refId, roomFeatures: booking.packages.filter((p) => p.type === "RoomFeature"), roomPoints: booking.roomPoints, diff --git a/apps/scandic-web/types/stores/booking-confirmation.ts b/apps/scandic-web/types/stores/booking-confirmation.ts index 031bf7d43..c0d05b3b9 100644 --- a/apps/scandic-web/types/stores/booking-confirmation.ts +++ b/apps/scandic-web/types/stores/booking-confirmation.ts @@ -28,6 +28,7 @@ export interface Room { packages: BookingConfirmation["booking"]["packages"] formattedRoomCost: string rateDefinition: BookingConfirmation["booking"]["rateDefinition"] + rateCodeType: BookingConfirmation["booking"]["bookingType"] refId: string roomFeatures?: PackageSchema[] | null roomPoints: number diff --git a/packages/trpc/lib/routers/booking/output.ts b/packages/trpc/lib/routers/booking/output.ts index 386fcffe1..70fc5aa49 100644 --- a/packages/trpc/lib/routers/booking/output.ts +++ b/packages/trpc/lib/routers/booking/output.ts @@ -208,6 +208,7 @@ export const bookingConfirmationSchema = z attributes: z.object({ adults: z.number().int(), ancillary: ancillarySchema, + bookingType: z.string().optional(), cancelationNumber: z.string().nullable().default(""), checkInDate: z.string().refine((val) => dt(val).isValid()), checkOutDate: z.string().refine((val) => dt(val).isValid()),