feat(SW-2227): Implemented new design for room package filters

Approved-by: Arvid Norlin

apps/scandic-web/components/HotelReservation/EnterDetails/Details/SpecialRequests/index.tsx

@@ -41,35 +41,35 @@ export default function SpecialRequests() {
           TODO: Hiding because API is not ready for this yet (https://scandichotels.atlassian.net/browse/SW-1497). Add back in when API is ready.
 
           <Select
-            label={intl.formatMessage({ id: "Floor preference" })}
+            label={intl.formatMessage({ defaultMessage: "Floor preference" })}
             name="specialRequest.floorPreference"
             items={[
               noPreferenceItem,
               {
                 value: FloorPreference.HIGH,
-                label: intl.formatMessage({ id: "High floor" }),
+                label: intl.formatMessage({ defaultMessage: "High floor" }),
               },
               {
                 value: FloorPreference.LOW,
-                label: intl.formatMessage({ id: "Low floor" }),
+                label: intl.formatMessage({ defaultMessage: "Low floor" }),
               },
             ]}
           />
           <Select
-            label={intl.formatMessage({ id: "Elevator preference" })}
+            label={intl.formatMessage({ defaultMessage: "Elevator preference" })}
             name="specialRequest.elevatorPreference"
             items={[
               noPreferenceItem,
               {
                 value: ElevatorPreference.AWAY_FROM_ELEVATOR,
                 label: intl.formatMessage({
-                  id: "Away from elevator",
+                  defaultMessage: "Away from elevator",
                 }),
               },
               {
                 value: ElevatorPreference.NEAR_ELEVATOR,
                 label: intl.formatMessage({
-                  id: "Near elevator",
+                  defaultMessage: "Near elevator",
                 }),
               },
             ]}

apps/scandic-web/components/HotelReservation/SelectRate/RoomsContainer/Rooms/RoomsHeader/RoomPackageFilter/Form/Checkboxes/checkbox.module.css

@@ -1,52 +1,76 @@
+.checkboxGroup {
+  display: grid;
+  gap: var(--Space-x15);
+}
+
 .checkboxWrapper {
+  display: grid;
+  gap: var(--Space-x05);
+}
+
+.checkboxField {
   display: grid;
   grid-template-columns: auto 1fr auto;
   align-items: center;
-  gap: var(--Spacing-x-one-and-half);
-  padding: var(--Spacing-x1) var(--Spacing-x-one-and-half);
+  gap: var(--Space-x15);
+  padding: var(--Space-x1) var(--Space-x15);
   cursor: pointer;
   border-radius: var(--Corner-radius-Medium);
   transition: background-color 0.3s;
   color: var(--Text-Default);
-}
 
-.checkboxWrapper:hover {
-  background-color: var(--UI-Input-Controls-Surface-Hover);
+  &[data-disabled] {
+    cursor: unset;
+
+    .checkbox {
+      border-color: var(--Border-Interactive-Disabled);
+      background-color: var(--Surface-UI-Fill-Disabled);
+    }
+
+    .text {
+      color: var(--Base-Text-Disabled);
+    }
+  }
+
+  &:hover:not([data-disabled]) {
+    background-color: var(--UI-Input-Controls-Surface-Hover);
+  }
+
+  &[data-focus-visible] .checkbox {
+    /* Used this value as it makes sense from a token name perspective and has a good contrast, but we need to decide for a default ui state */
+    outline: 2px solid var(--Border-Interactive-Focus);
+    outline-offset: 2px;
+  }
+
+  &[data-selected] .checkbox {
+    border-color: var(--Surface-UI-Fill-Active);
+    background-color: var(--Surface-UI-Fill-Active);
+  }
 }
 
 .checkbox {
   width: 24px;
   height: 24px;
   min-width: 24px;
-  border: 1px solid var(--UI-Input-Controls-Border-Normal);
+  border: 1px solid var(--Border-Interactive-Default);
   border-radius: var(--Corner-radius-Small);
   transition: all 0.3s;
   display: flex;
   align-items: center;
   justify-content: center;
-  background-color: var(--UI-Input-Controls-Surface-Normal);
+  background-color: var(--Surface-UI-Fill-Default);
 }
 
-.checkboxWrapper[data-selected] .checkbox {
-  border-color: var(--UI-Input-Controls-Fill-Selected);
-  background-color: var(--UI-Input-Controls-Fill-Selected);
-}
-
-.checkboxWrapper[data-disabled] .checkbox {
-  border-color: var(--UI-Input-Controls-Border-Disabled);
-  background-color: var(--UI-Input-Controls-Surface-Disabled);
-}
-
-.checkboxWrapper[data-disabled] .text {
-  color: var(--Base-Text-Disabled);
+.text {
+  color: var(--Text-Default);
 }
 
 @media screen and (max-width: 767px) {
-  .checkboxWrapper:hover {
+  .checkboxField:hover:not([data-disabled]) {
     background-color: transparent;
   }
 
-  .checkboxWrapper[data-selected] {
+  .checkboxField[data-selected] {
     background-color: transparent;
   }
 }

apps/scandic-web/components/HotelReservation/SelectRate/RoomsContainer/Rooms/RoomsHeader/RoomPackageFilter/Form/Checkboxes/index.tsx

@@ -1,5 +1,4 @@
 "use client"
-import { Fragment } from "react"
 import { Checkbox, CheckboxGroup } from "react-aria-components"
 import { Controller, useFormContext } from "react-hook-form"
 
@@ -32,46 +31,44 @@ export default function Checkboxes() {
         const allergyRoomSelected = includesAllergyRoom(field.value)
         const petRoomSelected = includesPetRoom(field.value)
         return (
-          <CheckboxGroup {...field}>
-            <div>
-              {packageOptions.map((option) => {
-                const isAllergyRoom = checkIsAllergyRoom(option.code)
-                const isPetRoom = checkIsPetRoom(option.code)
-                const isDisabled =
-                  (isPetRoom && allergyRoomSelected) ||
-                  (isAllergyRoom && petRoomSelected)
+          <CheckboxGroup {...field} className={styles.checkboxGroup}>
+            {packageOptions.map((option) => {
+              const isAllergyRoom = checkIsAllergyRoom(option.code)
+              const isPetRoom = checkIsPetRoom(option.code)
+              const isDisabled =
+                (isPetRoom && allergyRoomSelected) ||
+                (isAllergyRoom && petRoomSelected)
 
-                const isSelected = field.value.includes(option.code)
-                const iconName = getIconNameByPackageCode(option.code)
+              const isSelected = field.value.includes(option.code)
+              const iconName = getIconNameByPackageCode(option.code)
 
-                return (
-                  <Fragment key={option.code}>
-                    <Checkbox
-                      key={option.code}
-                      className={styles.checkboxWrapper}
-                      isDisabled={isDisabled}
-                      value={option.code}
-                    >
-                      <span className={styles.checkbox}>
-                        {isSelected ? (
-                          <MaterialIcon icon="check" color="Icon/Inverted" />
-                        ) : null}
-                      </span>
-                      <Typography
-                        className={styles.text}
-                        variant="Body/Paragraph/mdRegular"
-                      >
-                        <span>{option.description}</span>
-                      </Typography>
-                      {iconName ? (
-                        <MaterialIcon icon={iconName} color="Icon/Default" />
+              return (
+                <div key={option.code} className={styles.checkboxWrapper}>
+                  <Checkbox
+                    key={option.code}
+                    className={styles.checkboxField}
+                    isDisabled={isDisabled}
+                    value={option.code}
+                  >
+                    <span className={styles.checkbox}>
+                      {isSelected ? (
+                        <MaterialIcon icon="check" color="Icon/Inverted" />
                       ) : null}
-                    </Checkbox>
-                    {isPetRoom ? <PetRoomMessage /> : null}
-                  </Fragment>
-                )
-              })}
-            </div>
+                    </span>
+                    <Typography
+                      className={styles.text}
+                      variant="Body/Paragraph/mdRegular"
+                    >
+                      <span>{option.description}</span>
+                    </Typography>
+                    {iconName ? (
+                      <MaterialIcon icon={iconName} color="Icon/Default" />
+                    ) : null}
+                  </Checkbox>
+                  {isPetRoom ? <PetRoomMessage /> : null}
+                </div>
+              )
+            })}
           </CheckboxGroup>
         )
       }}

apps/scandic-web/components/HotelReservation/SelectRate/RoomsContainer/Rooms/RoomsHeader/RoomPackageFilter/Form/form.module.css

@@ -1,11 +1,30 @@
 .footer {
-  display: grid;
-  gap: var(--Space-x1);
   padding: 0 var(--Space-x15);
 }
 
 .buttonContainer {
-  align-items: center;
   display: flex;
-  justify-content: space-between;
+  flex-direction: column;
+  gap: var(--Space-x1);
+}
+
+.divider {
+  margin: var(--Space-x15) 0;
+}
+
+@media screen and (max-width: 767px) {
+  .divider {
+    display: none;
+  }
+  .footer {
+    margin-top: var(--Space-x5);
+  }
+}
+
+@media screen and (min-width: 768px) {
+  .buttonContainer {
+    flex-direction: row-reverse;
+    justify-content: space-between;
+    align-items: center;
+  }
 }

apps/scandic-web/components/HotelReservation/SelectRate/RoomsContainer/Rooms/RoomsHeader/RoomPackageFilter/Form/index.tsx

@@ -74,8 +74,13 @@ export default function Form({ close }: { close: VoidFunction }) {
       <form onSubmit={methods.handleSubmit(onSubmit)}>
         <Checkboxes />
         <div className={styles.footer}>
-          <Divider color="borderDividerSubtle" />
+          <Divider color="borderDividerSubtle" className={styles.divider} />
           <div className={styles.buttonContainer}>
+            <Typography variant="Body/Supporting text (caption)/smBold">
+              <Button variant="Tertiary" size="Small" type="submit">
+                {intl.formatMessage({ defaultMessage: "Apply" })}
+              </Button>
+            </Typography>
             <Typography variant="Body/Supporting text (caption)/smBold">
               <Button
                 onPress={clearSelectedPackages}
@@ -87,13 +92,6 @@ export default function Form({ close }: { close: VoidFunction }) {
                 })}
               </Button>
             </Typography>
-            <Typography variant="Body/Supporting text (caption)/smBold">
-              <Button variant="Tertiary" size="Small" type="submit">
-                {intl.formatMessage({
-                  defaultMessage: "Apply",
-                })}
-              </Button>
-            </Typography>
           </div>
         </div>
       </form>

apps/scandic-web/components/HotelReservation/SelectRate/RoomsContainer/Rooms/RoomsHeader/RoomPackageFilter/Modal.tsx

@@ -0,0 +1,52 @@
+import { useState } from "react"
+import {
+  Dialog,
+  DialogTrigger,
+  Modal,
+  ModalOverlay,
+} from "react-aria-components"
+import { useIntl } from "react-intl"
+
+import { Button } from "@scandic-hotels/design-system/Button"
+import { ChipButton } from "@scandic-hotels/design-system/ChipButton"
+import { MaterialIcon } from "@scandic-hotels/design-system/Icons/MaterialIcon"
+import { Typography } from "@scandic-hotels/design-system/Typography"
+
+import Form from "./Form"
+
+import styles from "./roomPackageFilter.module.css"
+
+export default function RoomPackageFilterModal() {
+  const intl = useIntl()
+  const [isOpen, setIsOpen] = useState(false)
+  return (
+    <DialogTrigger isOpen={isOpen} onOpenChange={setIsOpen}>
+      <ChipButton variant="Outlined">
+        {intl.formatMessage({ defaultMessage: "Room preferences" })}
+        <MaterialIcon
+          icon="keyboard_arrow_down"
+          size={20}
+          color="CurrentColor"
+        />
+      </ChipButton>
+
+      <ModalOverlay className={styles.modalOverlay} isDismissable>
+        <Modal className={styles.modal}>
+          <Dialog className={styles.modalDialog}>
+            <div className={styles.header}>
+              <Typography variant="Title/Subtitle/md">
+                <h3>
+                  {intl.formatMessage({ defaultMessage: "Room preferences" })}
+                </h3>
+              </Typography>
+              <Button variant="Icon" onPress={() => setIsOpen(false)}>
+                <MaterialIcon icon="close" size={24} color="CurrentColor" />
+              </Button>
+            </div>
+            <Form close={() => setIsOpen(false)} />
+          </Dialog>
+        </Modal>
+      </ModalOverlay>
+    </DialogTrigger>
+  )
+}

apps/scandic-web/components/HotelReservation/SelectRate/RoomsContainer/Rooms/RoomsHeader/RoomPackageFilter/Popover.tsx

@@ -0,0 +1,33 @@
+import { useState } from "react"
+import { Dialog, DialogTrigger, Popover } from "react-aria-components"
+import { useIntl } from "react-intl"
+
+import { ChipButton } from "@scandic-hotels/design-system/ChipButton"
+import { MaterialIcon } from "@scandic-hotels/design-system/Icons/MaterialIcon"
+
+import Form from "./Form"
+
+import styles from "./roomPackageFilter.module.css"
+
+export default function RoomPackageFilterPopover() {
+  const intl = useIntl()
+  const [isOpen, setIsOpen] = useState(false)
+  return (
+    <DialogTrigger isOpen={isOpen} onOpenChange={setIsOpen}>
+      <ChipButton variant="Outlined">
+        {intl.formatMessage({ defaultMessage: "Room preferences" })}
+        <MaterialIcon
+          icon="keyboard_arrow_down"
+          size={20}
+          color="CurrentColor"
+        />
+      </ChipButton>
+
+      <Popover placement="bottom end" className={styles.popover}>
+        <Dialog className={styles.popoverDialog}>
+          <Form close={() => setIsOpen(false)} />
+        </Dialog>
+      </Popover>
+    </DialogTrigger>
+  )
+}

apps/scandic-web/components/HotelReservation/SelectRate/RoomsContainer/Rooms/RoomsHeader/RoomPackageFilter/index.tsx

@@ -1,15 +1,9 @@
 "use client"
-import { useState } from "react"
-import {
-  Button as AriaButton,
-  Dialog,
-  DialogTrigger,
-  Popover,
-} from "react-aria-components"
-import { useIntl } from "react-intl"
+import { Button as AriaButton } from "react-aria-components"
+import { useMediaQuery } from "usehooks-ts"
 
-import { ChipButton } from "@scandic-hotels/design-system/ChipButton"
 import { MaterialIcon } from "@scandic-hotels/design-system/Icons/MaterialIcon"
+import { Typography } from "@scandic-hotels/design-system/Typography"
 
 import { trpc } from "@/lib/trpc/client"
 import { useRatesStore } from "@/stores/select-rate"
@@ -17,7 +11,8 @@ import { useRatesStore } from "@/stores/select-rate"
 import { useRoomContext } from "@/contexts/SelectRate/Room"
 import useLang from "@/hooks/useLang"
 
-import Form from "./Form"
+import RoomPackageFilterModal from "./Modal"
+import RoomPackageFilterPopover from "./Popover"
 import { getIconNameByPackageCode } from "./utils"
 
 import styles from "./roomPackageFilter.module.css"
@@ -25,11 +20,9 @@ import styles from "./roomPackageFilter.module.css"
 import type { PackageEnum } from "@/types/requests/packages"
 
 export default function RoomPackageFilter() {
-  const intl = useIntl()
   const lang = useLang()
   const utils = trpc.useUtils()
-
-  const [isOpen, setIsOpen] = useState(false)
+  const displayAsPopover = useMediaQuery("(min-width: 768px)")
 
   const {
     actions: { removeSelectedPackage, updateRooms },
@@ -63,41 +56,35 @@ export default function RoomPackageFilter() {
 
   return (
     <div className={styles.roomPackageFilter}>
-      {selectedPackages.map((pkg) => (
-        <AriaButton
-          key={pkg.code}
-          className={styles.activeFilterButton}
-          onPress={() => deleteSelectedPackage(pkg.code)}
-        >
-          <MaterialIcon
-            icon={getIconNameByPackageCode(pkg.code)}
-            size={16}
-            color="Icon/Interactive/Default"
-          />
-          <MaterialIcon
-            icon="close"
-            size={16}
-            color="Icon/Interactive/Default"
-          />
-        </AriaButton>
-      ))}
-      <DialogTrigger isOpen={isOpen} onOpenChange={setIsOpen}>
-        <ChipButton variant="Outlined">
-          {intl.formatMessage({
-            defaultMessage: "Room preferences",
-          })}
-          <MaterialIcon
-            icon="keyboard_arrow_down"
-            size={20}
-            color="CurrentColor"
-          />
-        </ChipButton>
-        <Popover placement="bottom end">
-          <Dialog className={styles.dialog}>
-            <Form close={() => setIsOpen(false)} />
-          </Dialog>
-        </Popover>
-      </DialogTrigger>
+      <div className={styles.selectedPackages}>
+        {selectedPackages.map((pkg) => (
+          <Typography
+            key={pkg.code}
+            variant="Body/Supporting text (caption)/smRegular"
+          >
+            <span className={styles.selectedPackage}>
+              <MaterialIcon
+                icon={getIconNameByPackageCode(pkg.code)}
+                size={16}
+                color="CurrentColor"
+              />
+              {pkg.description}
+              <AriaButton
+                onPress={() => deleteSelectedPackage(pkg.code)}
+                className={styles.removeButton}
+              >
+                <MaterialIcon icon="close" size={16} color="CurrentColor" />
+              </AriaButton>
+            </span>
+          </Typography>
+        ))}
+      </div>
+      <div hidden={displayAsPopover}>
+        <RoomPackageFilterModal />
+      </div>
+      <div hidden={!displayAsPopover}>
+        <RoomPackageFilterPopover />
+      </div>
     </div>
   )
 }

apps/scandic-web/components/HotelReservation/SelectRate/RoomsContainer/Rooms/RoomsHeader/RoomPackageFilter/roomPackageFilter.module.css

@@ -1,28 +1,141 @@
 .roomPackageFilter {
   display: flex;
   gap: var(--Space-x1);
+  flex-direction: column-reverse;
+  align-items: start;
 }
 
-.activeFilterButton {
+.selectedPackages {
   display: flex;
-  justify-content: center;
-  align-items: center;
-  padding: 0 var(--Space-x1);
-  gap: var(--Space-x05);
-  border-radius: var(--Corner-radius-Small);
-  background-color: var(--Surface-Secondary-Default-dark);
-  border-width: 0;
-  cursor: pointer;
+  gap: var(--Space-x1);
+  flex-wrap: wrap;
+}
+
+.modalOverlay {
+  position: fixed;
+  inset: 0;
+  background-color: var(--Overlay-40);
+
+  &[data-entering] {
+    animation: overlay-fade 200ms;
+  }
+
+  &[data-exiting] {
+    animation: overlay-fade 150ms reverse ease-in;
+  }
+}
+
+.modal {
+  position: fixed;
+  bottom: 0;
+  left: 0;
+  right: 0;
+  padding: var(--Space-x2) var(--Space-x05);
+  border-radius: var(--Corner-radius-md) var(--Corner-radius-md) 0 0;
+  background-color: var(--Surface-Primary-Default);
+  box-shadow: 0px 0px 14px 6px rgba(0, 0, 0, 0.1);
+
+  &[data-entering] {
+    animation: modal-anim 200ms;
+  }
+
+  &[data-exiting] {
+    animation: modal-anim 150ms reverse ease-in;
+  }
+}
+
+.modalDialog {
+  display: grid;
+  gap: var(--Space-x2);
 }
 
 .dialog {
   display: grid;
-  gap: var(--Space-x1);
-  padding: var(--Space-x2);
-  flex-direction: column;
-  align-items: flex-end;
-  border-radius: var(--Corner-radius-md);
-  background-color: var(--Surface-Primary-Default);
-  box-shadow: 0px 0px 14px 6px rgba(0, 0, 0, 0.1);
+  gap: var(--Space-x2);
   max-width: 340px;
 }
+
+.header {
+  display: flex;
+  justify-content: space-between;
+  align-items: center;
+  padding: 0 var(--Space-x15);
+}
+
+.footer {
+  display: grid;
+  gap: var(--Space-x1);
+  padding: 0 var(--Space-x15);
+}
+
+.selectedPackage {
+  display: flex;
+  justify-content: center;
+  align-items: center;
+  padding: var(--Space-x1);
+  gap: var(--Space-x05);
+  border-radius: var(--Corner-radius-Small);
+  background-color: var(--Surface-Secondary-Default-dark);
+  color: var(--Text-Interactive-Default);
+}
+
+.removeButton {
+  background-color: transparent;
+  border-width: 0;
+  cursor: pointer;
+  padding: var(--Space-x05);
+  margin: calc(-1 * var(--Space-x05));
+}
+
+@media screen and (max-width: 767px) {
+  .popover {
+    display: none;
+  }
+}
+
+@media screen and (min-width: 768px) {
+  .roomPackageFilter {
+    flex-direction: row;
+    align-items: stretch;
+  }
+
+  .modalOverlay {
+    display: none;
+  }
+
+  .popover {
+    padding: var(--Space-x2);
+    border-radius: var(--Corner-radius-md);
+    background-color: var(--Surface-Primary-Default);
+    box-shadow: 0px 0px 14px 6px rgba(0, 0, 0, 0.1);
+    max-width: 340px;
+  }
+
+  .checkboxContainer {
+    padding: 0 var(--Space-x1);
+  }
+
+  .header {
+    display: none;
+  }
+}
+
+@keyframes overlay-fade {
+  from {
+    opacity: 0;
+  }
+
+  to {
+    opacity: 1;
+  }
+}
+
+@keyframes modal-anim {
+  from {
+    transform: translateY(100%);
+  }
+
+  to {
+    transform: translateY(0);
+  }
+}