scandic/web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged in fix/LOY-138-remove-membership-id-surprises (pull request #1337)

Browse Source 
fix(LOY-138): remove membership id from showing in surprises

Approved-by: Chuma Mcphoy (We Ahead)
This commit is contained in:
Christian Andolf
2025-02-14 07:51:08 +00:00
parent 53b6628b25 03e9e5c9ca
commit 3044bc87d1
10 changed files with 10 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
components/MyPages/Surprises/Client.tsx
View File

@@ -27,10 +27,7 @@ import type { SurprisesProps } from "@/types/components/blocks/surprises"
const MotionModal = motion(Modal)
export default function SurprisesNotification({
surprises,
membershipNumber,
}: SurprisesProps) {
export default function SurprisesNotification({ surprises }: SurprisesProps) {
const lang = useLang()
const intl = useIntl()
const pathname = usePathname()
@@ -185,10 +182,7 @@ export default function SurprisesNotification({
}}
layout
>
<Slide
surprise={surprise}
membershipNumber={membershipNumber}
/>
<Slide surprise={surprise} />
</motion.div>
</AnimatePresence>

12
components/MyPages/Surprises/Slide.tsx
View File

@@ -12,7 +12,7 @@ import styles from "./surprises.module.css"
import type { SlideProps } from "@/types/components/blocks/surprises"
export default function Slide({ surprise, membershipNumber }: SlideProps) {
export default function Slide({ surprise }: SlideProps) {
const lang = useLang()
const intl = useIntl()
@@ -38,16 +38,6 @@ export default function Slide({ surprise, membershipNumber }: SlideProps) {
}
)}
</Caption>
<Caption>
{intl.formatMessage(
{
id: "Membership ID {id}",
},
{
id: membershipNumber,
}
)}
</Caption>
</div>
</Card>
)

14
components/MyPages/Surprises/index.tsx
View File

@@ -1,5 +1,4 @@
import { env } from "@/env/server"
import { getProfile } from "@/lib/trpc/memoizedRequests"
import { serverClient } from "@/lib/trpc/server"
import SurprisesClient from "./Client"
@@ -9,22 +8,11 @@ export default async function Surprises() {
return null
}
const user = await getProfile()
if (!user || "error" in user) {
return null
}
const surprises = await serverClient().contentstack.rewards.surprises()
if (!surprises) {
return null
}
return (
<SurprisesClient
surprises={surprises}
membershipNumber={user.membership?.membershipNumber}
/>
)
return <SurprisesClient surprises={surprises} />
}

3
i18n/dictionaries/da.json
View File

@@ -64,9 +64,9 @@
"Bed type": "Seng type",
"Bike friendly": "Cykelvenlig",
"Birth date": "Fødselsdato",
"Boardroom": "Boardroom",
"Birth date is missing": "Birth date is missing",
"Birth date: {dateOfBirth, date, ::MMMM d yyyy}": "Birth date: {dateOfBirth, date, ::MMMM d yyyy}",
"Boardroom": "Boardroom",
"Book": "Book",
"Book Reward Night": "Book bonusnat",
"Book a table online": "Book et bord online",
@@ -332,7 +332,6 @@
"Members": "Members",
"Members {price}/night": "Medlemmer {price}/nat",
"Membership ID copied to clipboard": "Medlems-ID kopieret til udklipsholder",
"Membership ID {id}": "Medlems-id {id}",
"Membership ID: {id}": "Medlems-id: {id}",
"Membership benefits applied": "Membership benefits applied",
"Membership cards": "Medlemskort",

3
i18n/dictionaries/de.json
View File

@@ -65,9 +65,9 @@
"Bed type": "Bettentyp",
"Bike friendly": "Fahrradfreundlich",
"Birth date": "Geburtsdatum",
"Boardroom": "Boardroom",
"Birth date is missing": "Birth date is missing",
"Birth date: {dateOfBirth, date, ::MMMM d yyyy}": "Birth date: {dateOfBirth, date, ::MMMM d yyyy}",
"Boardroom": "Boardroom",
"Book": "Buchen",
"Book Reward Night": "Bonusnacht buchen",
"Book a table online": "Tisch online buchen",
@@ -333,7 +333,6 @@
"Members": "Members",
"Members {price}/night": "Mitglieder {price}/nacht",
"Membership ID copied to clipboard": "Mitglieds-ID in die Zwischenablage kopiert",
"Membership ID {id}": "Mitglieds-ID {id}",
"Membership ID: {id}": "Mitglieds-ID: {id}",
"Membership benefits applied": "Membership benefits applied",
"Membership cards": "Mitgliedskarten",

3
i18n/dictionaries/en.json
View File

@@ -65,9 +65,9 @@
"Bed type": "Bed type",
"Bike friendly": "Bike friendly",
"Birth date": "Birth date",
"Boardroom": "Boardroom",
"Birth date is missing": "Birth date is missing",
"Birth date: {dateOfBirth, date, ::MMMM d yyyy}": "Birth date: {dateOfBirth, date, ::MMMM d yyyy}",
"Boardroom": "Boardroom",
"Book": "Book",
"Book Reward Night": "Book Reward Night",
"Book a table online": "Book a table online",
@@ -336,7 +336,6 @@
"Members": "Members",
"Members {price}/night": "Members {price}/night",
"Membership ID copied to clipboard": "Membership ID copied to clipboard",
"Membership ID {id}": "Membership ID {id}",
"Membership ID: {id}": "Membership ID: {id}",
"Membership benefits applied": "Membership benefits applied",
"Membership cards": "Membership cards",

3
i18n/dictionaries/fi.json
View File

@@ -63,9 +63,9 @@
"Bed type": "Vuodetyyppi",
"Bike friendly": "Pyöräystävällinen",
"Birth date": "Syntymäaika",
"Boardroom": "Boardroom",
"Birth date is missing": "Birth date is missing",
"Birth date: {dateOfBirth, date, ::MMMM d yyyy}": "Birth date: {dateOfBirth, date, ::MMMM d yyyy}",
"Boardroom": "Boardroom",
"Book": "Varaa",
"Book Reward Night": "Kirjapalkinto-ilta",
"Book a table online": "Varaa pöytä verkossa",
@@ -332,7 +332,6 @@
"Members": "Members",
"Members {price}/night": "Jäsenet {price}/yö",
"Membership ID copied to clipboard": "Jäsenyystunnus kopioitu leikepöydälle",
"Membership ID {id}": "Jäsentunnus {id}",
"Membership ID: {id}": "Jäsentunnus: {id}",
"Membership benefits applied": "Membership benefits applied",
"Membership cards": "Jäsenkortit",

3
i18n/dictionaries/no.json
View File

@@ -63,9 +63,9 @@
"Bed type": "Seng type",
"Bike friendly": "Sykkelvennlig",
"Birth date": "Fødselsdato",
"Boardroom": "Boardroom",
"Birth date is missing": "Birth date is missing",
"Birth date: {dateOfBirth, date, ::MMMM d yyyy}": "Birth date: {dateOfBirth, date, ::MMMM d yyyy}",
"Boardroom": "Boardroom",
"Book": "Bestill",
"Book Reward Night": "Bestill belønningskveld",
"Book a table online": "Bestill bord online",
@@ -331,7 +331,6 @@
"Members": "Members",
"Members {price}/night": "Medlemmer {price}/natt",
"Membership ID copied to clipboard": "Medlems-ID kopiert til utklippstavlen",
"Membership ID {id}": "Medlems-ID {id}",
"Membership ID: {id}": "Medlems-ID: {id}",
"Membership benefits applied": "Membership benefits applied",
"Membership cards": "Medlemskort",

3
i18n/dictionaries/sv.json
View File

@@ -63,9 +63,9 @@
"Bed type": "Sängtyp",
"Bike friendly": "Cykelvänligt",
"Birth date": "Födelsedatum",
"Boardroom": "Boardroom",
"Birth date is missing": "Birth date is missing",
"Birth date: {dateOfBirth, date, ::MMMM d yyyy}": "Birth date: {dateOfBirth, date, ::MMMM d yyyy}",
"Boardroom": "Boardroom",
"Book": "Boka",
"Book Reward Night": "Boka frinatt",
"Book a table online": "Boka ett bord online",
@@ -331,7 +331,6 @@
"Members": "Members",
"Members {price}/night": "Medlemmar {price}/natt",
"Membership ID copied to clipboard": "Medlems-ID kopierat till urklipp",
"Membership ID {id}": "Medlems-ID {id}",
"Membership ID: {id}": "Medlems-ID: {id}",
"Membership benefits applied": "Membership benefits applied",
"Membership cards": "Medlemskort",

1
types/components/blocks/surprises.ts
View File

@@ -26,7 +26,6 @@ export interface InitialProps {
export interface SlideProps {
surprise: Surprise
membershipNumber?: string
}
export interface HeaderProps extends React.PropsWithChildren {