Merged in fix/tracking-issue-pageview (pull request #1931)

fix: tracking issues

* fix: tracking issues


Approved-by: Hrishikesh Vaipurkar

apps/scandic-web/components/TrackingSDK/RouterTracking.tsx

@@ -24,6 +24,10 @@ export default function RouterTracking() {
   const { startRouterTransition } = useRouterTransitionStore()
 
   useEffect(() => {
+    if (pathName.includes("payment-callback")) {
+      return
+    }
+
     updateRouteInfo(pathName, currentLang, searchParams)
     if (hasPathOrLangChanged() || hasBookingFlowParamsChanged()) {
       setInitialPageLoadTime(Date.now())

apps/scandic-web/components/TrackingSDK/index.tsx

@@ -1,6 +1,9 @@
 "use client"
 
-import { useTrackSoftNavigation } from "@/components/TrackingSDK/hooks"
+import {
+  useTrackHardNavigation,
+  useTrackSoftNavigation,
+} from "@/components/TrackingSDK/hooks"
 
 import type {
   TrackingSDKAncillaries,
@@ -20,9 +23,7 @@ export default function TrackingSDK({
   paymentInfo?: TrackingSDKPaymentInfo
   ancillaries?: TrackingSDKAncillaries
 }) {
-  // This hook doesnt seem to be needed. Soft navigation hook seems to fire
+  useTrackHardNavigation({ pageData, hotelInfo, paymentInfo, ancillaries })
-  // on both hard and soft navigations
-  // useTrackHardNavigation({ pageData, hotelInfo, paymentInfo, ancillaries })
   useTrackSoftNavigation({ pageData, hotelInfo, paymentInfo, ancillaries })
 
   return null

apps/scandic-web/stores/tracking.ts

@@ -1,5 +1,6 @@
 "use client"
 
+import isEqual from "fast-deep-equal"
 import { create } from "zustand"
 
 import { convertSearchParamsToObj, searchParamsToRecord } from "@/utils/url"
@@ -84,7 +85,7 @@ const useTrackingStore = create<TrackingStoreState>((set, get) => ({
       searchParamsToRecord(currentParams)
     )
 
-    return !Object.is(previousParamsObject, currentParamsObject)
+    return !isEqual(previousParamsObject, currentParamsObject)
   },
 }))