chore: replace function expression with inline statement

replace destructuring for better static analysis remove unused variables
2024-11-05 10:14:52 +01:00
parent 28c30b2416
commit f6b3cf8b92
25 changed files with 75 additions and 78 deletions
--- a/components/Blocks/DynamicContent/Overview/Stats/Points/PointsColumn/index.tsx
+++ b/components/Blocks/DynamicContent/Overview/Stats/Points/PointsColumn/index.tsx
@@ -44,15 +44,13 @@ async function PointsColumn({
  title,
  subtitle,
 }: PointsColumnProps) {
-  const { formatMessage, formatNumber } = await getIntl()
+  const intl = await getIntl()

-  function number() {
-    if (typeof points === "number") {
-      return formatNumber(points)
-    } else if (typeof nights === "number") {
-      return formatNumber(nights)
-    }
-    return "N/A"
+  let number = "N/A"
+  if (typeof points === "number") {
+    number = intl.formatNumber(points)
+  } else if (typeof nights === "number") {
+    number = intl.formatNumber(nights)
  }

  return (
@@ -63,16 +61,16 @@ async function PointsColumn({
        textAlign="center"
        className={styles.firstRow}
      >
-        {formatMessage({
+        {intl.formatMessage({
          id: title,
        })}
      </Body>
      <Title color="white" level="h2" textAlign="center">
-        {number()}
+        {number}
      </Title>
      {subtitle ? (
        <Body color="white" textAlign="center">
-          {formatMessage({ id: subtitle })}
+          {intl.formatMessage({ id: subtitle })}
        </Body>
      ) : null}
    </article>