Merged in fix/destinations-speed-test (pull request #1704)

Feat(destination pages): Performance improvements

* fix/destinations: try cache full response

* Added more caching

* Removed unsed env car

* wip

* merge master

* wip

* wip

* wip

* Renaming


Approved-by: Michael Zetterberg

apps/scandic-web/server/routers/hotels/utils.ts

@@ -24,7 +24,7 @@ import { getHotel } from "./query"
 import type { z } from "zod"
 
 import { PointOfInterestGroupEnum } from "@/types/enums/pointOfInterest"
-import type { HotelDataWithUrl } from "@/types/hotel"
+import type { DestinationPagesHotelData } from "@/types/hotel"
 import type {
   CitiesGroupedByCountry,
   CityLocation,
@@ -529,19 +529,54 @@ export async function getHotelsByHotelIds({
   lang: Lang
   serviceToken: string
 }) {
-  const hotelPages = await getHotelPageUrls(lang)
-  const hotels = await Promise.all(
-    hotelIds.map(async (hotelId) => {
-      const hotelData = await getHotel(
-        { hotelId, language: lang, isCardOnlyPayment: false },
-        serviceToken
-      )
-      const hotelPage = hotelPages.find((page) => page.hotelId === hotelId)
-      return hotelData ? { ...hotelData, url: hotelPage?.url ?? null } : null
-    })
-  )
+  const cacheClient = await getCacheClient()
+  const cacheKey = `${lang}:getHotelsByHotelIds:hotels:${hotelIds.sort().join(",")}`
 
-  return hotels.filter((hotel): hotel is HotelDataWithUrl => !!hotel)
+  return await cacheClient.cacheOrGet(
+    cacheKey,
+    async () => {
+      const hotelPages = await getHotelPageUrls(lang)
+      const hotels = await Promise.all(
+        hotelIds.map(async (hotelId) => {
+          const hotelResponse = await getHotel(
+            { hotelId, language: lang, isCardOnlyPayment: false },
+            serviceToken
+          )
+
+          if (!hotelResponse) {
+            throw new Error(`Hotel not found: ${hotelId}`)
+          }
+
+          const hotelPage = hotelPages.find((page) => page.hotelId === hotelId)
+          const { hotel, cities } = hotelResponse
+          const data: DestinationPagesHotelData = {
+            hotel: {
+              id: hotel.id,
+              galleryImages: hotel.galleryImages?.length
+                ? [hotel.galleryImages[0]]
+                : [],
+              name: hotel.name,
+              tripadvisor: hotel.ratings?.tripAdvisor?.rating,
+              detailedFacilities: hotel.detailedFacilities?.slice(0, 3) || [],
+              location: hotel.location,
+              hotelType: hotel.hotelType,
+              type: hotel.type,
+              address: hotel.address,
+              cityIdentifier: cities?.[0]?.cityIdentifier,
+            },
+            url: hotelPage?.url ?? "",
+          } satisfies DestinationPagesHotelData
+
+          return { ...data, url: hotelPage?.url ?? null }
+        })
+      )
+
+      return hotels.filter(
+        (hotel): hotel is DestinationPagesHotelData => !!hotel
+      )
+    },
+    "1d"
+  )
 }
 
 function findProduct(product: Products, rateDefinition: RateDefinition) {
@@ -697,10 +732,13 @@ export async function getSelectedRoomAvailability(
   }
 
   if (Array.isArray(product)) {
-    const redemptionProduct = userPoints ? product.find(
-      (r) => r.redemption.rateCode === rateDefinition.rateCode &&
-        r.redemption.localPrice.pointsPerStay <= userPoints
-    ) : undefined
+    const redemptionProduct = userPoints
+      ? product.find(
+          (r) =>
+            r.redemption.rateCode === rateDefinition.rateCode &&
+            r.redemption.localPrice.pointsPerStay <= userPoints
+        )
+      : undefined
     if (!redemptionProduct) {
       return null
     }