From e25a974426cbb9a4befb85468a6fe584ae9fb7d3 Mon Sep 17 00:00:00 2001 From: Chuma McPhoy Date: Thu, 24 Oct 2024 09:19:14 +0200 Subject: [PATCH] fix(SW-360): more context to how we handle triggers --- components/Forms/Signup/index.tsx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/components/Forms/Signup/index.tsx b/components/Forms/Signup/index.tsx index a64569f80..9f061f614 100644 --- a/components/Forms/Signup/index.tsx +++ b/components/Forms/Signup/index.tsx @@ -173,9 +173,10 @@ export default function SignupForm({ link, subtitle, title }: SignUpFormProps) { {/* - We use this approach to trigger validation for all invalid inputs upon submission. - To handle this programmatically in the future, we would need some major refactoring - of the Input component, which is out of scope for now. + This is a manual validation trigger workaround: + - The Controller component (which Input uses) doesn't re-render on submit, + which prevents automatic error display. + - Future fix requires Input component refactoring (out of scope for now). */} {!methods.formState.isValid ? (