refactor(LOY-62): implement code review feedback

This commit is contained in:
Chuma McPhoy
2025-01-13 13:45:13 +01:00
parent e0d8315565
commit da31539610
10 changed files with 61 additions and 143 deletions

View File

@@ -0,0 +1,5 @@
import { MembershipLevelEnum } from "@/constants/membershipLevels"
export function isMembershipLevel(value: string): value is MembershipLevelEnum {
return Object.values(MembershipLevelEnum).some((level) => level === value)
}

View File

@@ -1,6 +1,11 @@
import { RESTAURANT_REWARD_IDS, REWARD_IDS } from "@/constants/rewards"
import {
COUPON_REWARD_TYPES,
RESTAURANT_REWARD_IDS,
REWARD_IDS,
} from "@/constants/rewards"
import type {
CouponRewardType,
RestaurantRewardId,
RewardId,
} from "@/types/components/myPages/rewards"
@@ -40,3 +45,9 @@ export function isRestaurantOnSiteTierReward(
): boolean {
return isOnSiteTierReward(reward) && isRestaurantReward(reward.reward_id)
}
export function isCouponRewardType(
type: RewardWithRedeem["rewardType"]
): type is CouponRewardType {
return COUPON_REWARD_TYPES.some((t) => t === type)
}