refactor(LOY-62): implement code review feedback

2025-01-13 13:45:13 +01:00
parent e0d8315565
commit da31539610
10 changed files with 61 additions and 143 deletions
--- a/server/routers/contentstack/reward/output.ts
+++ b/server/routers/contentstack/reward/output.ts
@@ -239,5 +239,3 @@ export const validateApiAllTiersSchema = z.record(
 )

 export type RedeemLocation = "Non-redeemable" | "On-site" | "Online"
-
-export type RewardType = "Tier" | "Member-voucher" | "Surprise" | "Campaign"
--- a/server/routers/contentstack/reward/query.ts
+++ b/server/routers/contentstack/reward/query.ts
@@ -378,6 +378,7 @@ export const rewardQueryRouter = router({
          ...reward,
          id: surprise.id,
          rewardType: surprise.rewardType,
+          rewardTierLevel: undefined,
          redeemLocation: surprise.redeemLocation,
          coupons: "coupon" in surprise ? surprise.coupon || [] : [],
        }