From d67a2919bff447d321fb7006e7b6e8af6888c31a Mon Sep 17 00:00:00 2001
From: Arvid Norlin <arvid.norlin@scandichotels.com>
Date: Tue, 10 Dec 2024 10:00:56 +0100
Subject: [PATCH] fix: limit first/lastname inputs to 30 characters

---
 components/HotelReservation/EnterDetails/Details/index.tsx | 2 ++
 components/HotelReservation/EnterDetails/Details/schema.ts | 1 +
 components/TempDesignSystem/Form/Input/index.tsx           | 2 ++
 i18n/dictionaries/da.json                                  | 4 ++--
 i18n/dictionaries/de.json                                  | 4 ++--
 i18n/dictionaries/en.json                                  | 4 ++--
 i18n/dictionaries/fi.json                                  | 4 ++--
 i18n/dictionaries/no.json                                  | 4 ++--
 i18n/dictionaries/sv.json                                  | 4 ++--
 9 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/components/HotelReservation/EnterDetails/Details/index.tsx b/components/HotelReservation/EnterDetails/Details/index.tsx
index 322535574..2aef91185 100644
--- a/components/HotelReservation/EnterDetails/Details/index.tsx
+++ b/components/HotelReservation/EnterDetails/Details/index.tsx
@@ -78,12 +78,14 @@ export default function Details({ user, memberPrice }: DetailsProps) {
           </Footnote>
           <Input
             label={intl.formatMessage({ id: "First name" })}
+            maxLength={30}
             name="firstName"
             readOnly={!!user}
             registerOptions={{ required: true }}
           />
           <Input
             label={intl.formatMessage({ id: "Last name" })}
+            maxLength={30}
             name="lastName"
             readOnly={!!user}
             registerOptions={{ required: true }}
diff --git a/components/HotelReservation/EnterDetails/Details/schema.ts b/components/HotelReservation/EnterDetails/Details/schema.ts
index 0782226bf..34fc55f06 100644
--- a/components/HotelReservation/EnterDetails/Details/schema.ts
+++ b/components/HotelReservation/EnterDetails/Details/schema.ts
@@ -2,6 +2,7 @@ import { z } from "zod"
 
 import { phoneValidator } from "@/utils/phoneValidator"
 
+// stringMatcher regex is copied from current web as specified by requirements.
 const stringMatcher =
   /^[A-Za-z¿ÀÁÂÃÄÅÆÇÈÉÊËÌÍÎÏÐÑÒÓÔÕÖØÙÚÛÜÝÞßàáâãäåæçèéêëìíîïðñòóôõöøùúûüýþÿ0-9-\s]*$/
 
diff --git a/components/TempDesignSystem/Form/Input/index.tsx b/components/TempDesignSystem/Form/Input/index.tsx
index dda34d115..dbc261043 100644
--- a/components/TempDesignSystem/Form/Input/index.tsx
+++ b/components/TempDesignSystem/Form/Input/index.tsx
@@ -18,6 +18,7 @@ export default function Input({
   disabled = false,
   helpText = "",
   label,
+  maxLength,
   name,
   placeholder = "",
   readOnly = false,
@@ -55,6 +56,7 @@ export default function Input({
             aria-labelledby={field.name}
             id={field.name}
             label={label}
+            maxLength={maxLength}
             placeholder={placeholder}
             readOnly={readOnly}
             required={!!registerOptions.required}
diff --git a/i18n/dictionaries/da.json b/i18n/dictionaries/da.json
index 20ca8dea2..fd7c2b3a3 100644
--- a/i18n/dictionaries/da.json
+++ b/i18n/dictionaries/da.json
@@ -144,7 +144,7 @@
   "Find booking": "Find booking",
   "Find hotels": "Find hotel",
   "First name": "Fornavn",
-  "First name can't contain any special charachters": "Fornavn kan ikke indeholde specielle tegn",
+  "First name can't contain any special characters": "Fornavn kan ikke indeholde specielle tegn",
   "First name is required": "Fornavn er påkrævet",
   "Flexibility": "Fleksibilitet",
   "Follow us": "Følg os",
@@ -195,7 +195,7 @@
   "King bed": "Kingsize-seng",
   "Language": "Sprog",
   "Last name": "Efternavn",
-  "Last name can't contain any special charachters": "Efternavn kan ikke indeholde specielle tegn",
+  "Last name can't contain any special characters": "Efternavn kan ikke indeholde specielle tegn",
   "Last name is required": "Efternavn er påkrævet",
   "Latest searches": "Seneste søgninger",
   "Left": "tilbage",
diff --git a/i18n/dictionaries/de.json b/i18n/dictionaries/de.json
index 61450323b..aff90bc45 100644
--- a/i18n/dictionaries/de.json
+++ b/i18n/dictionaries/de.json
@@ -144,7 +144,7 @@
   "Find booking": "Buchung finden",
   "Find hotels": "Hotels finden",
   "First name": "Vorname",
-  "First name can't contain any special charachters": "Der Vorname darf keine Sonderzeichen enthalten",
+  "First name can't contain any special characters": "Der Vorname darf keine Sonderzeichen enthalten",
   "First name is required": "Vorname ist erforderlich",
   "Flexibility": "Flexibilität",
   "Follow us": "Folgen Sie uns",
@@ -195,7 +195,7 @@
   "King bed": "Kingsize-Bett",
   "Language": "Sprache",
   "Last name": "Nachname",
-  "Last name can't contain any special charachters": "Der Nachname darf keine Sonderzeichen enthalten",
+  "Last name can't contain any special characters": "Der Nachname darf keine Sonderzeichen enthalten",
   "Last name is required": "Nachname ist erforderlich",
   "Latest searches": "Letzte Suchanfragen",
   "Left": "übrig",
diff --git a/i18n/dictionaries/en.json b/i18n/dictionaries/en.json
index 0852ec63c..7858c0fce 100644
--- a/i18n/dictionaries/en.json
+++ b/i18n/dictionaries/en.json
@@ -154,7 +154,7 @@
   "Find booking": "Find booking",
   "Find hotels": "Find hotels",
   "First name": "First name",
-  "First name can't contain any special charachters": "First name can't contain any special charachters",
+  "First name can't contain any special characters": "First name can't contain any special characters",
   "First name is required": "First name is required",
   "Flexibility": "Flexibility",
   "Follow us": "Follow us",
@@ -212,7 +212,7 @@
   "King bed": "King bed",
   "Language": "Language",
   "Last name": "Last name",
-  "Last name can't contain any special charachters": "Last name can't contain any special charachters",
+  "Last name can't contain any special characters": "Last name can't contain any special characters",
   "Last name is required": "Last name is required",
   "Latest searches": "Latest searches",
   "Latitude": "Latitude {lat}",
diff --git a/i18n/dictionaries/fi.json b/i18n/dictionaries/fi.json
index 078d8ce4b..f3bbede56 100644
--- a/i18n/dictionaries/fi.json
+++ b/i18n/dictionaries/fi.json
@@ -144,7 +144,7 @@
   "Find booking": "Etsi varaus",
   "Find hotels": "Etsi hotelleja",
   "First name": "Etunimi",
-  "First name can't contain any special charachters": "Etunimi ei voi sisältää erikoismerkkejä",
+  "First name can't contain any special characters": "Etunimi ei voi sisältää erikoismerkkejä",
   "First name is required": "Etunimi vaaditaan",
   "Flexibility": "Joustavuus",
   "Follow us": "Seuraa meitä",
@@ -195,7 +195,7 @@
   "King bed": "King-vuode",
   "Language": "Kieli",
   "Last name": "Sukunimi",
-  "Last name can't contain any special charachters": "Sukunimi ei voi sisältää erikoismerkkejä",
+  "Last name can't contain any special characters": "Sukunimi ei voi sisältää erikoismerkkejä",
   "Last name is required": "Sukunimi vaaditaan",
   "Latest searches": "Viimeisimmät haut",
   "Left": "jäljellä",
diff --git a/i18n/dictionaries/no.json b/i18n/dictionaries/no.json
index 110f6a8d6..bd5fe8527 100644
--- a/i18n/dictionaries/no.json
+++ b/i18n/dictionaries/no.json
@@ -143,7 +143,7 @@
   "Find booking": "Finn booking",
   "Find hotels": "Finn hotell",
   "First name": "Fornavn",
-  "First name can't contain any special charachters": "Fornavn kan ikke inneholde spesielle tegn",
+  "First name can't contain any special characters": "Fornavn kan ikke inneholde spesielle tegn",
   "First name is required": "Fornavn kreves",
   "Flexibility": "Fleksibilitet",
   "Follow us": "Følg oss",
@@ -193,7 +193,7 @@
   "King bed": "King-size-seng",
   "Language": "Språk",
   "Last name": "Etternavn",
-  "Last name can't contain any special charachters": "Etternavn kan ikke inneholde spesielle tegn",
+  "Last name can't contain any special characters": "Etternavn kan ikke inneholde spesielle tegn",
   "Last name is required": "Etternavn kreves",
   "Latest searches": "Siste søk",
   "Left": "igjen",
diff --git a/i18n/dictionaries/sv.json b/i18n/dictionaries/sv.json
index 001c4a209..c96853122 100644
--- a/i18n/dictionaries/sv.json
+++ b/i18n/dictionaries/sv.json
@@ -143,7 +143,7 @@
   "Find booking": "Hitta bokning",
   "Find hotels": "Hitta hotell",
   "First name": "Förnamn",
-  "First name can't contain any special charachters": "Förnamn får inte innehålla några specialtecken",
+  "First name can't contain any special characters": "Förnamn får inte innehålla några specialtecken",
   "First name is required": "Förnamn är obligatoriskt",
   "Flexibility": "Flexibilitet",
   "Follow us": "Följ oss",
@@ -194,7 +194,7 @@
   "King bed": "King size-säng",
   "Language": "Språk",
   "Last name": "Efternamn",
-  "Last name can't contain any special charachters": "Efternamn får inte innehålla några specialtecken",
+  "Last name can't contain any special characters": "Efternamn får inte innehålla några specialtecken",
   "Last name is required": "Efternamn är obligatoriskt",
   "Latest searches": "Senaste sökningarna",
   "Left": "kvar",