From d1a2175804172b38b994369836dd0dde3a0a38f9 Mon Sep 17 00:00:00 2001 From: Erik Tiekstra Date: Mon, 26 Aug 2024 08:52:32 +0200 Subject: [PATCH] chore: cleanup --- app/globals.css | 4 +- .../Header/HeaderLink/headerLink.module.css | 2 +- components/Header/HeaderLink/index.tsx | 4 +- components/Header/MainMenu/Avatar/index.tsx | 2 +- .../Header/MainMenu/MainMenuButton/index.tsx | 2 +- .../Header/MainMenu/MobileMenu/index.tsx | 10 ++- .../MainMenu/MobileMenu/mobileMenu.module.css | 4 +- .../Header/MainMenu/MyPagesMenu/index.tsx | 2 +- .../MyPagesMenu/myPagesMenu.module.css | 8 +- .../MainMenu/MyPagesMenuContent/index.tsx | 2 +- .../MainMenu/MyPagesMobileMenu/index.tsx | 2 +- .../myPagesMobileMenu.module.css | 3 +- .../NavigationMenuItem/index.tsx | 2 +- .../navigationMenuItem.module.css | 2 +- .../Header/MainMenu/NavigationMenu/index.tsx | 2 +- components/Header/MainMenu/index.tsx | 16 ++-- .../Header/MainMenu/mainMenu.module.css | 2 +- components/Header/TopMenu/Search/index.tsx | 18 ---- .../Header/TopMenu/Search/search.module.css | 20 ----- components/Header/TopMenu/index.tsx | 4 +- components/Header/header.module.css | 1 - .../LanguageSwitcherContent/index.tsx | 10 +-- ...css => languageSwitcherContent.module.css} | 84 ------------------ .../LanguageSwitcherContent/variants.ts | 17 ---- components/LanguageSwitcher/index.tsx | 6 +- .../languageSwitcher.module.css | 88 +------------------ components/LanguageSwitcher/variants.ts | 17 ---- hooks/useTrapFocus.ts | 1 - i18n/dictionaries/da.json | 2 +- i18n/dictionaries/de.json | 2 +- i18n/dictionaries/en.json | 2 +- i18n/dictionaries/fi.json | 4 +- i18n/dictionaries/no.json | 4 +- i18n/dictionaries/sv.json | 4 +- types/components/header/avatar.ts | 2 +- types/components/header/headerLink.ts | 2 +- types/components/header/languageSwitcher.ts | 10 --- types/components/header/mainMenu.ts | 2 +- types/components/header/mobileMenu.ts | 2 +- types/components/header/myPagesMenu.ts | 2 +- types/components/header/navigationMenu.ts | 2 +- types/components/header/navigationMenuItem.ts | 2 +- types/components/header/topMenu.ts | 2 +- .../languageSwitcher/languageSwitcher.ts | 6 ++ utils/tabbable.ts | 9 -- 45 files changed, 70 insertions(+), 324 deletions(-) delete mode 100644 components/Header/TopMenu/Search/index.tsx delete mode 100644 components/Header/TopMenu/Search/search.module.css rename components/LanguageSwitcher/LanguageSwitcherContent/{languageSwitcher.module.css => languageSwitcherContent.module.css} (51%) delete mode 100644 components/LanguageSwitcher/LanguageSwitcherContent/variants.ts delete mode 100644 components/LanguageSwitcher/variants.ts delete mode 100644 types/components/header/languageSwitcher.ts create mode 100644 types/components/languageSwitcher/languageSwitcher.ts diff --git a/app/globals.css b/app/globals.css index 531d007d5..71027f9e7 100644 --- a/app/globals.css +++ b/app/globals.css @@ -104,8 +104,10 @@ --max-width-text-block: 49.5rem; --mobile-site-header-height: 70.047px; --max-width-navigation: 89.5rem; + --main-menu-mobile-height: 75px; - --mobile-menu-overlay-z-index: 10; + + --menu-overlay-z-index: 10; } * { diff --git a/components/Header/HeaderLink/headerLink.module.css b/components/Header/HeaderLink/headerLink.module.css index 7049d4857..198e0c61b 100644 --- a/components/Header/HeaderLink/headerLink.module.css +++ b/components/Header/HeaderLink/headerLink.module.css @@ -1,4 +1,4 @@ -.topLink { +.headerLink { display: flex; align-items: center; gap: var(--Spacing-x1); diff --git a/components/Header/HeaderLink/index.tsx b/components/Header/HeaderLink/index.tsx index 9b2195ebb..2f05dbec2 100644 --- a/components/Header/HeaderLink/index.tsx +++ b/components/Header/HeaderLink/index.tsx @@ -2,11 +2,11 @@ import Link from "@/components/TempDesignSystem/Link" import styles from "./headerLink.module.css" -import { HeaderLinkProps } from "@/types/components/header/headerLink" +import type { HeaderLinkProps } from "@/types/components/header/headerLink" export default function HeaderLink({ children, ...props }: HeaderLinkProps) { return ( - + {children} ) diff --git a/components/Header/MainMenu/Avatar/index.tsx b/components/Header/MainMenu/Avatar/index.tsx index 7a0bc34c1..4ab15108d 100644 --- a/components/Header/MainMenu/Avatar/index.tsx +++ b/components/Header/MainMenu/Avatar/index.tsx @@ -3,7 +3,7 @@ import Image from "@/components/Image" import styles from "./avatar.module.css" -import { AvatarProps } from "@/types/components/header/avatar" +import type { AvatarProps } from "@/types/components/header/avatar" export default function Avatar({ image, initials }: AvatarProps) { let classNames = [styles.avatar] diff --git a/components/Header/MainMenu/MainMenuButton/index.tsx b/components/Header/MainMenu/MainMenuButton/index.tsx index c45cc569f..b5b3ae55a 100644 --- a/components/Header/MainMenu/MainMenuButton/index.tsx +++ b/components/Header/MainMenu/MainMenuButton/index.tsx @@ -1,6 +1,6 @@ import styles from "./menuButton.module.css" -import { MainMenuButtonProps } from "@/types/components/header/mainMenuButton" +import type { MainMenuButtonProps } from "@/types/components/header/mainMenuButton" export default function MainMenuButton({ className = "", diff --git a/components/Header/MainMenu/MobileMenu/index.tsx b/components/Header/MainMenu/MobileMenu/index.tsx index 99498bd6f..c59fdc7c1 100644 --- a/components/Header/MainMenu/MobileMenu/index.tsx +++ b/components/Header/MainMenu/MobileMenu/index.tsx @@ -14,7 +14,7 @@ import NavigationMenu from "../NavigationMenu" import styles from "./mobileMenu.module.css" -import { MobileMenuProps } from "@/types/components/header/mobileMenu" +import type { MobileMenuProps } from "@/types/components/header/mobileMenu" export default function MobileMenu({ mainNavigation, @@ -24,8 +24,10 @@ export default function MobileMenu({ const { isHamburgerMenuOpen, isMyPagesMobileMenuOpen, + isLanguageSwitcherOpen, toggleHamburgerMenu, toggleMyPagesMobileMenu, + toggleLanguageSwitcher, } = useDropdownStore() useHandleKeyUp((event: KeyboardEvent) => { @@ -38,6 +40,10 @@ export default function MobileMenu({ if (isMyPagesMobileMenuOpen) { toggleMyPagesMobileMenu() } else { + if (isLanguageSwitcherOpen) { + toggleLanguageSwitcher() + } + toggleHamburgerMenu() } } @@ -73,7 +79,7 @@ export default function MobileMenu({ {intl.formatMessage({ id: "Customer service" })} - + diff --git a/components/Header/MainMenu/MobileMenu/mobileMenu.module.css b/components/Header/MainMenu/MobileMenu/mobileMenu.module.css index c1fd26990..797b3b427 100644 --- a/components/Header/MainMenu/MobileMenu/mobileMenu.module.css +++ b/components/Header/MainMenu/MobileMenu/mobileMenu.module.css @@ -25,7 +25,7 @@ display: inline-block; height: 3px; position: relative; - transition: all 0.2s; + transition: all 0.3s; width: 32px; } @@ -72,7 +72,7 @@ width: 100%; background-color: var(--Base-Surface-Primary-light-Normal); transition: right 0.3s; - z-index: var(--mobile-menu-overlay-z-index); + z-index: var(--menu-overlay-z-index); } .modal[data-entering] { diff --git a/components/Header/MainMenu/MyPagesMenu/index.tsx b/components/Header/MainMenu/MyPagesMenu/index.tsx index 78a8987db..5d408cd32 100644 --- a/components/Header/MainMenu/MyPagesMenu/index.tsx +++ b/components/Header/MainMenu/MyPagesMenu/index.tsx @@ -16,7 +16,7 @@ import MyPagesMenuContent from "../MyPagesMenuContent" import styles from "./myPagesMenu.module.css" -import { MyPagesMenuProps } from "@/types/components/header/myPagesMenu" +import type { MyPagesMenuProps } from "@/types/components/header/myPagesMenu" export default function MyPagesMenu({ navigation, user }: MyPagesMenuProps) { const intl = useIntl() diff --git a/components/Header/MainMenu/MyPagesMenu/myPagesMenu.module.css b/components/Header/MainMenu/MyPagesMenu/myPagesMenu.module.css index 6f5a1805b..39002b177 100644 --- a/components/Header/MainMenu/MyPagesMenu/myPagesMenu.module.css +++ b/components/Header/MainMenu/MyPagesMenu/myPagesMenu.module.css @@ -9,7 +9,7 @@ } .chevron { - transition: transform 0.2s; + transition: transform 0.3s; } .chevron.isExpanded { @@ -18,13 +18,13 @@ .dropdown { position: absolute; - top: 46px; + top: 2.875rem; /* 2.875rem is the height of the main menu + bottom padding */ right: 0; background-color: var(--Base-Surface-Primary-light-Normal); border-radius: var(--Corner-radius-Large); - box-shadow: 0px 0px 14px 6px rgba(0, 0, 0, 0.1); + box-shadow: 0 0 0.875rem 0.375rem rgba(0, 0, 0, 0.1); min-width: 20rem; - z-index: 1; + z-index: var(--menu-overlay-z-index); } /* Triangle above dropdown */ diff --git a/components/Header/MainMenu/MyPagesMenuContent/index.tsx b/components/Header/MainMenu/MyPagesMenuContent/index.tsx index e87c25a94..dc70f3b68 100644 --- a/components/Header/MainMenu/MyPagesMenuContent/index.tsx +++ b/components/Header/MainMenu/MyPagesMenuContent/index.tsx @@ -14,7 +14,7 @@ import { useTrapFocus } from "@/hooks/useTrapFocus" import styles from "./myPagesMenuContent.module.css" -import { MyPagesMenuContentProps } from "@/types/components/header/myPagesMenu" +import type { MyPagesMenuContentProps } from "@/types/components/header/myPagesMenu" export default function MyPagesMenuContent({ navigation, diff --git a/components/Header/MainMenu/MyPagesMobileMenu/index.tsx b/components/Header/MainMenu/MyPagesMobileMenu/index.tsx index b976c37eb..51700f72c 100644 --- a/components/Header/MainMenu/MyPagesMobileMenu/index.tsx +++ b/components/Header/MainMenu/MyPagesMobileMenu/index.tsx @@ -14,7 +14,7 @@ import MyPagesMenuContent from "../MyPagesMenuContent" import styles from "./myPagesMobileMenu.module.css" -import { MyPagesMenuProps } from "@/types/components/header/myPagesMenu" +import type { MyPagesMenuProps } from "@/types/components/header/myPagesMenu" export default function MyPagesMobileMenu({ navigation, diff --git a/components/Header/MainMenu/MyPagesMobileMenu/myPagesMobileMenu.module.css b/components/Header/MainMenu/MyPagesMobileMenu/myPagesMobileMenu.module.css index 6b251ea49..eee75f79e 100644 --- a/components/Header/MainMenu/MyPagesMobileMenu/myPagesMobileMenu.module.css +++ b/components/Header/MainMenu/MyPagesMobileMenu/myPagesMobileMenu.module.css @@ -15,8 +15,7 @@ bottom: 0; width: 100%; background-color: var(--Base-Surface-Primary-light-Normal); - transition: right 0.3s; - z-index: var(--mobile-menu-overlay-z-index); + z-index: var(--menu-overlay-z-index); } .modal[data-entering] { diff --git a/components/Header/MainMenu/NavigationMenu/NavigationMenuItem/index.tsx b/components/Header/MainMenu/NavigationMenu/NavigationMenuItem/index.tsx index 4efc44086..c7893afc8 100644 --- a/components/Header/MainMenu/NavigationMenu/NavigationMenuItem/index.tsx +++ b/components/Header/MainMenu/NavigationMenu/NavigationMenuItem/index.tsx @@ -10,7 +10,7 @@ import { navigationMenuItemVariants } from "./variants" import styles from "./navigationMenuItem.module.css" -import { NavigationMenuItemProps } from "@/types/components/header/navigationMenuItem" +import type { NavigationMenuItemProps } from "@/types/components/header/navigationMenuItem" export default function MenuItem({ item, variant }: NavigationMenuItemProps) { const { children, title, href, seeAllLinkText, infoCard } = item diff --git a/components/Header/MainMenu/NavigationMenu/NavigationMenuItem/navigationMenuItem.module.css b/components/Header/MainMenu/NavigationMenu/NavigationMenuItem/navigationMenuItem.module.css index b509f4e73..2c6c79180 100644 --- a/components/Header/MainMenu/NavigationMenu/NavigationMenuItem/navigationMenuItem.module.css +++ b/components/Header/MainMenu/NavigationMenu/NavigationMenuItem/navigationMenuItem.module.css @@ -6,7 +6,7 @@ } .chevron { - transition: transform 0.2s; + transition: transform 0.3s; } .chevron.isExpanded { diff --git a/components/Header/MainMenu/NavigationMenu/index.tsx b/components/Header/MainMenu/NavigationMenu/index.tsx index 08534f56e..3a4f36d00 100644 --- a/components/Header/MainMenu/NavigationMenu/index.tsx +++ b/components/Header/MainMenu/NavigationMenu/index.tsx @@ -3,7 +3,7 @@ import { navigationMenuVariants } from "./variants" import styles from "./navigationMenu.module.css" -import { NavigationMenuProps } from "@/types/components/header/navigationMenu" +import type { NavigationMenuProps } from "@/types/components/header/navigationMenu" export default function NavigationMenu({ items, diff --git a/components/Header/MainMenu/index.tsx b/components/Header/MainMenu/index.tsx index 608c4c505..8b943aa05 100644 --- a/components/Header/MainMenu/index.tsx +++ b/components/Header/MainMenu/index.tsx @@ -17,7 +17,7 @@ import NavigationMenu from "./NavigationMenu" import styles from "./mainMenu.module.css" -import { MainMenuProps } from "@/types/components/header/mainMenu" +import type { MainMenuProps } from "@/types/components/header/mainMenu" export default async function MainMenu({ languageUrls }: MainMenuProps) { const intl = await getIntl() @@ -30,7 +30,7 @@ export default async function MainMenu({ languageUrls }: MainMenuProps) { return (