Fixed hotelId in payment error events

This commit is contained in:
Linus Flood
2025-01-10 12:00:21 +01:00
parent 7099115d40
commit c6c8df87ec
2 changed files with 29 additions and 18 deletions

View File

@@ -30,7 +30,6 @@ export default async function PaymentCallbackPage({
const lang = params.lang
const status = searchParams.status
const confirmationNumber = searchParams.confirmationNumber
const hotelId = searchParams.hotel
if (status === "success" && confirmationNumber) {
const confirmationUrl = `${bookingConfirmation(lang)}?${BOOKING_CONFIRMATION_NUMBER}=${confirmationNumber}`
@@ -42,6 +41,8 @@ export default async function PaymentCallbackPage({
const returnUrl = payment(lang)
const searchObject = new URLSearchParams()
let errorMessage = undefined
if (confirmationNumber) {
try {
const bookingStatus = await serverClient().booking.status({
@@ -51,37 +52,26 @@ export default async function PaymentCallbackPage({
// TODO: how to handle errors for multiple rooms?
const error = bookingStatus.errors.find((e) => e.errorCode)
errorMessage =
error?.description ??
`No error message found for booking ${confirmationNumber}, status: ${status}`
searchObject.set(
"errorCode",
error
? error.errorCode.toString()
: PaymentErrorCodeEnum.Failed.toString()
)
trackPaymentEvent({
event: "paymentFail",
hotelId,
errorMessage:
bookingStatus?.metadata?.errorMessage ??
`No error message found for booking ${confirmationNumber}, status: ${status}`,
})
} catch (error) {
console.error(
`[payment-callback] failed to get booking status for ${confirmationNumber}, status: ${status}`
)
if (status === "cancel") {
searchObject.set("errorCode", PaymentErrorCodeEnum.Cancelled.toString())
trackPaymentEvent({
event: "paymentCancel",
hotelId,
})
}
if (status === "error") {
searchObject.set("errorCode", PaymentErrorCodeEnum.Failed.toString())
trackPaymentEvent({
event: "paymentFail",
hotelId,
errorMessage: `Failed to get booking status for ${confirmationNumber}, status: ${status}`,
})
errorMessage = `Failed to get booking status for ${confirmationNumber}, status: ${status}`
}
}
}
@@ -90,6 +80,8 @@ export default async function PaymentCallbackPage({
<PaymentCallback
returnUrl={returnUrl.toString()}
searchObject={searchObject}
status={status}
errorMessage={errorMessage}
/>
)
}