chore: make PR fixes

This commit is contained in:
Arvid Norlin
2024-05-22 13:38:45 +02:00
parent b127584b17
commit bd93071e39
4 changed files with 41 additions and 40 deletions

View File

@@ -2,7 +2,7 @@ import Image from "@/components/Image"
import type { IconProps } from "@/types/components/icon" import type { IconProps } from "@/types/components/icon"
export default function ChevronDownIcon({ export default function CheckCircleIcon({
height = 20, height = 20,
width = 20, width = 20,
}: IconProps) { }: IconProps) {

View File

@@ -60,13 +60,7 @@ type OverviewTableTitleProps = { texts: TitleTranslation[] }
function OverviewTableTitle({ texts }: OverviewTableTitleProps) { function OverviewTableTitle({ texts }: OverviewTableTitleProps) {
return ( return (
<Title <Title as="h1" level="h1" weight="semiBold" uppercase>
as="h1"
level="h1"
className={styles.title}
weight="semiBold"
uppercase
>
{texts.map(({ text, highlight }, idx) => ( {texts.map(({ text, highlight }, idx) => (
<> <>
<span key={idx} className={highlight ? styles.highlight : ""}> <span key={idx} className={highlight ? styles.highlight : ""}>
@@ -145,8 +139,8 @@ export default function OverviewTable() {
return ( return (
<div className={styles.container}> <div className={styles.container}>
<div className={styles.intro}>
<OverviewTableTitle texts={titleTranslations[Lang.en]} /> <OverviewTableTitle texts={titleTranslations[Lang.en]} />
<div>
<p className={styles.preamble}> <p className={styles.preamble}>
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do
eiusmod tempor incididunt ut labore et dolore magna aliqua. Arcu risus eiusmod tempor incididunt ut labore et dolore magna aliqua. Arcu risus

View File

@@ -1,18 +1,23 @@
.container { .container {
background-color: var(--Main-Brand-PalePeach); background-color: var(--Main-Brand-PalePeach);
left: 50%; left: 50%;
margin-top: -1.6rem; margin-top: calc(var(--Spacing-x2) * -1);
margin-left: -50vw; margin-left: -50vw;
margin-right: -50vw; margin-right: -50vw;
margin-bottom: -9.3rem; /* Based on the MaxWidth's 1.6rem + the LoyaltyPage's 7.7rem bottom margins */ margin-bottom: calc(
(var(--Spacing-x2) + 7.7rem) * -1
); /* Based on the MaxWidth's 1.6rem + the LoyaltyPage's 7.7rem bottom margins */
position: relative; position: relative;
right: 50%; right: 50%;
width: 100dvw; width: 100dvw;
padding: 1.6rem; padding: var(--Spacing-x2);
display: grid;
gap: var(--Spacing-x6);
} }
.title { .intro {
font-family: var(--typography-Title1-Desktop-fontFamily), inherit; display: grid;
gap: var(--Spacing-x3);
} }
.highlight { .highlight {
@@ -22,29 +27,29 @@
.preamble { .preamble {
color: var(--Base-Text-Primary-High-contrast); color: var(--Base-Text-Primary-High-contrast);
font-size: var(--typography-Body-Regular-fontSize); font-size: var(--typography-Body-Regular-fontSize);
line-height: 150%; line-height: var(--typography-Body-Regular-lineHeight);
margin: 0; margin: 0;
} }
.columns { .columns {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
gap: 1.6rem; gap: var(--Spacing-x2);
padding: 1.6rem; padding-top: var(--Spacing-x2);
position: relative; position: relative;
} }
.columnHeaderContainer { .columnHeaderContainer {
display: grid; display: grid;
grid-template-columns: 1fr 1fr; grid-template-columns: 1fr 1fr;
gap: 1.6rem; gap: var(--Spacing-x2);
z-index: 2; z-index: 2;
} }
.columnHeader { .columnHeader {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
gap: 1.6rem; gap: var(--Spacing-x2);
} }
.selectContainer { .selectContainer {
@@ -56,14 +61,14 @@
color: var(--Base-Text-UI-Placeholder); color: var(--Base-Text-UI-Placeholder);
position: absolute; position: absolute;
top: 7px; top: 7px;
left: 1.6rem; left: var(--Spacing-x2);
} }
.select { .select {
appearance: none; appearance: none;
border: 1px solid var(--Base-Input-Controls-Border-Normal, #b8a79a); border: 1px solid var(--Base-Input-Controls-Border-Normal, #b8a79a);
border-radius: 0.8rem; border-radius: var(--Corner-radius-Medium);
padding: 1.6rem; padding: var(--Spacing-x2);
width: 100%; width: 100%;
} }
@@ -71,8 +76,8 @@
display: flex; display: flex;
align-items: center; align-items: center;
position: absolute; position: absolute;
right: 1.6rem; right: var(--Spacing-x2);
bottom: 1.6rem; bottom: var(--Spacing-x2);
} }
.leftColumn { .leftColumn {
@@ -82,6 +87,7 @@
bottom: 0; bottom: 0;
left: 0; left: 0;
right: 50%; right: 50%;
margin-left: calc(var(--Spacing-x2) * -1);
z-index: 1; z-index: 1;
} }
@@ -90,40 +96,41 @@
position: absolute; position: absolute;
position: absolute; position: absolute;
top: 0; top: 0;
bottom: 1.6rem; bottom: var(--Spacing-x2);
left: 50%; left: 50%;
right: 0; right: 0;
margin-right: calc(var(--Spacing-x2) * -1);
z-index: 1; z-index: 1;
border-top-left-radius: 0.8rem; border-top-left-radius: var(--Corner-radius-Medium);
} }
.levelSummary { .levelSummary {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
align-items: center; align-items: center;
gap: 1.6rem; gap: var(--Spacing-x2);
} }
.levelRequirements { .levelRequirements {
background-color: var(--Main-Brand-Burgundy); background-color: var(--Main-Brand-Burgundy);
border-radius: 0.8rem; border-radius: var(--Corner-radius-Medium);
color: #f7e1d5; color: #f7e1d5;
padding: 0.4rem 0.8rem; padding: var(--Spacing-x-half) var(--Spacing-x1);
} }
.levelSummaryText { .levelSummaryText {
color: var(--Main-Brand-Burgundy); color: var(--Main-Brand-Burgundy);
font-size: var(--typography-Footnote-Regular-fontSize); font-size: var(--typography-Footnote-Regular-fontSize);
line-height: 150%; line-height: var(--typography-Body-Regular-lineHeight);
margin: 0; margin: 0;
} }
.benefitCard { .benefitCard {
background-color: var(--Main-Grey-White); background-color: var(--Main-Grey-White);
border: 1px solid var(--Base-Border-Subtle); border: 1px solid var(--Base-Border-Subtle);
border-radius: 0.4rem; border-radius: var(--Corner-radius-Small);
color: var(--Main-Brand-Burgundy); color: var(--Main-Brand-Burgundy);
padding: 0 1.6rem; padding: 0 var(--Spacing-x2);
z-index: 2; z-index: 2;
} }
@@ -155,7 +162,7 @@
.benefitInfo { .benefitInfo {
border-bottom: 1px solid var(--Base-Border-Subtle); border-bottom: 1px solid var(--Base-Border-Subtle);
padding: 1.5rem 0; padding: var(--Spacing-x-one-and-half) 0;
} }
.benefitComparison { .benefitComparison {
@@ -167,22 +174,22 @@
display: flex; display: flex;
justify-content: center; justify-content: center;
align-items: center; align-items: center;
padding: 1rem; padding: var(--Spacing-x-one-and-half);
} }
.benefitValueContainer { .benefitValueContainer {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
align-items: center; align-items: center;
gap: 1rem; gap: var(--Spacing-x-one-and-half);
} }
.benefitValue { .benefitValue {
background-color: var(--Main-Brand-Burgundy); background-color: var(--Main-Brand-Burgundy);
border-radius: 0.8rem; border-radius: var(--Corner-radius-Medium);
color: var(--Base-Surface-Primary-Hover-alt, #fff); color: var(--Base-Surface-Primary-Hover-alt, #fff);
font-size: var(--typography-Footnote-Regular-fontSize); font-size: var(--typography-Footnote-Regular-fontSize);
padding: 0.4rem 0.8rem; padding: var(--Spacing-x-half) var(--Spacing-x1);
} }
.benefitValueDetails { .benefitValueDetails {

View File

@@ -66,8 +66,8 @@ export type LevelSummaryProps = {
export type BenefitCardProps = { export type BenefitCardProps = {
comparedValues: { comparedValues: {
a: { unlocked: boolean; value?: string; valueDetails?: string } a: BenefitValueInformation
b: { unlocked: boolean; value?: string; valueDetails?: string } b: BenefitValueInformation
} }
title: string title: string
description: string description: string