From b486fd1ad08a6fcef8dc250dc64ab55d07ab9f7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20J=C3=A4derberg?= Date: Mon, 19 May 2025 08:35:47 +0000 Subject: [PATCH] Merged in fix/SW-2804-missing-meeting-rooms (pull request #2138) fix: return [] when we get a 404 for meeting rooms for a hotel * fix: return [] when we get a 404 for meeting rooms for a hotel Approved-by: Linus Flood --- apps/scandic-web/server/routers/hotels/query.ts | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/apps/scandic-web/server/routers/hotels/query.ts b/apps/scandic-web/server/routers/hotels/query.ts index b32d5f099..66e7f3c38 100644 --- a/apps/scandic-web/server/routers/hotels/query.ts +++ b/apps/scandic-web/server/routers/hotels/query.ts @@ -898,8 +898,16 @@ export const hotelQueryRouter = router({ ) if (!apiResponse.ok) { + if (apiResponse.status === 404) { + // This is expected when the hotel does not have meeting rooms + metricsMeetingRooms.success() + return [] + } + await metricsMeetingRooms.httpError(apiResponse) - throw new Error("Failed to fetch meeting rooms") + throw new Error("Failed to fetch meeting rooms", { + cause: apiResponse, + }) } const apiJson = await apiResponse.json() @@ -909,6 +917,7 @@ export const hotelQueryRouter = router({ metricsMeetingRooms.validationError(validatedMeetingRooms.error) throw badRequestError() } + metricsMeetingRooms.success() return validatedMeetingRooms.data.data