From a7167dde6aec6e824d6bc352c6bac953cb428c96 Mon Sep 17 00:00:00 2001
From: Hrishikesh Vaipurkar <hrishikesh.vaipurkar@scandichotels.com>
Date: Wed, 18 Sep 2024 13:24:35 +0200
Subject: [PATCH] feat: SW-276 Implemented child age validation

---
 components/Forms/BookingWidget/schema.ts      | 24 ++++-----
 .../ChildSelector/ChildInfoSelector.tsx       | 49 ++++++++++++-------
 .../ChildSelector/child-selector.module.css   |  5 +-
 .../GuestsRoomPicker/ChildSelector/index.tsx  | 15 ++++++
 .../guests-room-picker.module.css             |  1 -
 .../GuestsRoomPicker/index.tsx                |  2 +
 .../GuestsRoomsPicker/GuestsRoomsPicker.tsx   | 14 ++++--
 .../guests-rooms-picker.module.css            | 10 +++-
 components/GuestsRoomsPicker/index.tsx        | 41 ++++++++++------
 .../bookingWidget/guestsRoomsPicker.ts        |  3 ++
 10 files changed, 110 insertions(+), 54 deletions(-)

diff --git a/components/Forms/BookingWidget/schema.ts b/components/Forms/BookingWidget/schema.ts
index bc0be8d9c..9541abd42 100644
--- a/components/Forms/BookingWidget/schema.ts
+++ b/components/Forms/BookingWidget/schema.ts
@@ -2,6 +2,18 @@ import { z } from "zod"
 
 import type { Location } from "@/types/trpc/routers/hotel/locations"
 
+export const guestRoomsSchema = z.array(
+  z.object({
+    adults: z.number().default(1),
+    children: z.array(
+      z.object({
+        age: z.number().nonnegative(),
+        bed: z.number(),
+      })
+    ),
+  })
+)
+
 export const bookingWidgetSchema = z.object({
   bookingCode: z.string(), // Update this as required when working with booking codes component
   date: z.object({
@@ -25,17 +37,7 @@ export const bookingWidgetSchema = z.object({
     { message: "Required" }
   ),
   redemption: z.boolean().default(false),
-  rooms: z.array(
-    z.object({
-      adults: z.number().default(1),
-      children: z.array(
-        z.object({
-          age: z.number(),
-          bed: z.number(),
-        })
-      ),
-    })
-  ),
+  rooms: guestRoomsSchema,
   search: z.string({ coerce: true }).min(1, "Required"),
   voucher: z.boolean().default(false),
 })
diff --git a/components/GuestsRoomsPicker/GuestsRoomPicker/ChildSelector/ChildInfoSelector.tsx b/components/GuestsRoomsPicker/GuestsRoomPicker/ChildSelector/ChildInfoSelector.tsx
index 7dbc6d303..d0ff98aba 100644
--- a/components/GuestsRoomsPicker/GuestsRoomPicker/ChildSelector/ChildInfoSelector.tsx
+++ b/components/GuestsRoomsPicker/GuestsRoomPicker/ChildSelector/ChildInfoSelector.tsx
@@ -12,6 +12,7 @@ type ChildSelectorProps = {
   index: number
   availableBedTypes?: ChildBed[]
   updateChild: (child: Child, index: number) => void
+  childAgeError: boolean
 }
 
 export default function ChildInfoSelector({
@@ -23,6 +24,7 @@ export default function ChildInfoSelector({
     { label: "In extra bed", value: 2 },
   ],
   updateChild = (child: Child, index: number) => {},
+  childAgeError,
 }: ChildSelectorProps) {
   const intl = useIntl()
   const ageLabel = intl.formatMessage({ id: "Age" })
@@ -55,29 +57,38 @@ export default function ChildInfoSelector({
 
   return (
     <>
-      <Select
-        size={2}
-        items={ageList}
-        label={ageLabel}
-        aria-label={ageLabel}
-        value={child.age}
-        onSelect={(key) => {
-          handleOnSelect(key, "age")
-        }}
-        name="age"
-      />
-      {child.age !== -1 ? (
+      <div>
         <Select
-          items={availableBedTypes}
-          label={bedLabel}
-          aria-label={bedLabel}
-          value={child.bed}
+          required={true}
+          items={ageList}
+          label={ageLabel}
+          aria-label={ageLabel}
+          value={child.age}
           onSelect={(key) => {
-            handleOnSelect(key, "bed")
+            handleOnSelect(key, "age")
           }}
-          name="bed"
+          name="age"
+          placeholder={ageLabel}
         />
-      ) : null}
+        {childAgeError && child.age < 0 ? (
+          <span>Child Age is required</span>
+        ) : null}
+      </div>
+      <div>
+        {child.age !== -1 ? (
+          <Select
+            items={availableBedTypes}
+            label={bedLabel}
+            aria-label={bedLabel}
+            value={child.bed}
+            onSelect={(key) => {
+              handleOnSelect(key, "bed")
+            }}
+            name="bed"
+            placeholder={bedLabel}
+          />
+        ) : null}
+      </div>
     </>
   )
 }
diff --git a/components/GuestsRoomsPicker/GuestsRoomPicker/ChildSelector/child-selector.module.css b/components/GuestsRoomsPicker/GuestsRoomPicker/ChildSelector/child-selector.module.css
index 7f7bd09d7..cd8dff789 100644
--- a/components/GuestsRoomsPicker/GuestsRoomPicker/ChildSelector/child-selector.module.css
+++ b/components/GuestsRoomsPicker/GuestsRoomPicker/ChildSelector/child-selector.module.css
@@ -5,8 +5,9 @@
 }
 
 .childInfoContainer {
-  display: flex;
-  gap: 20px;
+  display: grid;
+  gap: var(--Spacing-x2);
+  grid-template-columns: 1fr 2fr;
 }
 
 .textCenter {
diff --git a/components/GuestsRoomsPicker/GuestsRoomPicker/ChildSelector/index.tsx b/components/GuestsRoomsPicker/GuestsRoomPicker/ChildSelector/index.tsx
index d1ca9138b..8cf9edb67 100644
--- a/components/GuestsRoomsPicker/GuestsRoomPicker/ChildSelector/index.tsx
+++ b/components/GuestsRoomsPicker/GuestsRoomPicker/ChildSelector/index.tsx
@@ -17,6 +17,7 @@ export default function ChildSelector({
   roomChildren = [],
   adultCount = 1,
   updateChildren = (children: Child[]) => {},
+  childAgeError,
 }: ChildSelectorProps) {
   const intl = useIntl()
   const childrenLabel = intl.formatMessage({ id: "Children" })
@@ -59,19 +60,32 @@ export default function ChildSelector({
   }
   roomChildren.forEach((child, index) => {
     let types: typeof availableBedTypes = []
+    let selectedBed: boolean = false
     if (
       child.age <= 5 &&
       (availableInAdultsBed > 0 || childInAdultsBedIndices.indexOf(index) != -1)
     ) {
       types.push(availableBedTypes[0])
+      if (child.bed == 0) {
+        selectedBed = true
+      }
     }
     if (child.age < 3) {
       types.push(availableBedTypes[1])
+      if (child.bed == 1) {
+        selectedBed = true
+      }
     }
     if (child.age > 2) {
       types.push(availableBedTypes[2])
+      if (child.bed == 2) {
+        selectedBed = true
+      }
     }
     childBedTypes[index] = types
+    if (!selectedBed) {
+      child.bed = types[0].value
+    }
   })
 
   return (
@@ -93,6 +107,7 @@ export default function ChildSelector({
             child={child}
             availableBedTypes={childBedTypes[index]}
             updateChild={updateChildInfo}
+            childAgeError={childAgeError}
           />
         </div>
       ))}
diff --git a/components/GuestsRoomsPicker/GuestsRoomPicker/guests-room-picker.module.css b/components/GuestsRoomsPicker/GuestsRoomPicker/guests-room-picker.module.css
index 64c253dff..59ab72488 100644
--- a/components/GuestsRoomsPicker/GuestsRoomPicker/guests-room-picker.module.css
+++ b/components/GuestsRoomsPicker/GuestsRoomPicker/guests-room-picker.module.css
@@ -1,5 +1,4 @@
 .container {
-  width: 280px;
   display: grid;
   gap: var(--Spacing-x2);
   padding-bottom: var(--Spacing-x1);
diff --git a/components/GuestsRoomsPicker/GuestsRoomPicker/index.tsx b/components/GuestsRoomsPicker/GuestsRoomPicker/index.tsx
index 1dcca2cb5..b7237a74e 100644
--- a/components/GuestsRoomsPicker/GuestsRoomPicker/index.tsx
+++ b/components/GuestsRoomsPicker/GuestsRoomPicker/index.tsx
@@ -17,6 +17,7 @@ export default function GuestsRoomPicker({
   handleOnSelect = (selected: GuestsRoom, index: number) => {},
   room = { adults: 1, children: [] },
   index = 1,
+  childAgeError,
 }: GuestsRoomPickerProps) {
   const intl = useIntl()
   const roomLabel = intl.formatMessage({ id: "Room" })
@@ -41,6 +42,7 @@ export default function GuestsRoomPicker({
         roomChildren={room.children}
         adultCount={room.adults}
         updateChildren={updateChildren}
+        childAgeError={childAgeError}
       />
     </section>
   )
diff --git a/components/GuestsRoomsPicker/GuestsRoomsPicker.tsx b/components/GuestsRoomsPicker/GuestsRoomsPicker.tsx
index 33ac64ecb..9414046db 100644
--- a/components/GuestsRoomsPicker/GuestsRoomsPicker.tsx
+++ b/components/GuestsRoomsPicker/GuestsRoomsPicker.tsx
@@ -23,6 +23,7 @@ export default function GuestsRoomsPicker({
     },
   ],
   closePicker,
+  childAgeError,
 }: GuestsRoomsPickerProps) {
   const lang = useLang()
   const [selectedGuests, setSelectedGuests] =
@@ -62,26 +63,29 @@ export default function GuestsRoomsPicker({
   return (
     <>
       {selectedGuests.map((room, index) => (
-        <section key={index}>
+        <section className={styles.roomContainer} key={index}>
           <GuestsRoomPicker
             room={room}
             handleOnSelect={handleSelectRoomGuests}
             index={index}
+            childAgeError={childAgeError}
           />
-          <Divider></Divider>
-          {index > 0 ? (
+          {/* Not in MVP
+           {index > 0 ? (
             <Button intent="text" onClick={() => removeRoom(index)}>
               Remove Room
             </Button>
-          ) : null}
+          ) : null} */}
+          <Divider></Divider>
         </section>
       ))}
       <div className={styles.footer}>
+        {/*  Not in MVP
         {selectedGuests.length < 4 ? (
           <Button intent="text" onClick={addRoom}>
             Add Room
           </Button>
-        ) : null}
+        ) : null} */}
         <Button onClick={closePicker}>Done</Button>
       </div>
     </>
diff --git a/components/GuestsRoomsPicker/guests-rooms-picker.module.css b/components/GuestsRoomsPicker/guests-rooms-picker.module.css
index 15c7fd05e..4994d808c 100644
--- a/components/GuestsRoomsPicker/guests-rooms-picker.module.css
+++ b/components/GuestsRoomsPicker/guests-rooms-picker.module.css
@@ -6,6 +6,10 @@
     overflow: visible;
   }
 }
+.roomContainer {
+  display: grid;
+  gap: var(--Spacing-x1);
+}
 .hideWrapper {
   background-color: var(--Main-Grey-White);
   border-radius: var(--Corner-radius-Medium);
@@ -14,6 +18,8 @@
   position: absolute;
   /** BookingWidget padding + border-width */
   top: calc(100% + var(--Spacing-x2) + 1px);
+  width: 360px;
+  max-width: 100vw; /* for small screens having view port width of 320px */
 }
 .btn {
   background: none;
@@ -28,7 +34,7 @@
 }
 .footer {
   display: grid;
-  gap: 20px;
-  grid-template-columns: auto auto;
+  gap: var(--Spacing-x1);
+  grid-template-columns: auto;
   margin: 10px 0 0;
 }
diff --git a/components/GuestsRoomsPicker/index.tsx b/components/GuestsRoomsPicker/index.tsx
index 66f0cce70..42fa366cc 100644
--- a/components/GuestsRoomsPicker/index.tsx
+++ b/components/GuestsRoomsPicker/index.tsx
@@ -1,9 +1,10 @@
 "use client"
 
-import { useEffect, useRef, useState } from "react"
+import { useCallback, useEffect, useRef, useState } from "react"
 import { useFormContext, useWatch } from "react-hook-form"
 import { useIntl } from "react-intl"
 
+import { guestRoomsSchema } from "@/components/Forms/BookingWidget/schema"
 import Body from "@/components/TempDesignSystem/Text/Body"
 
 import GuestsRoomsPicker from "./GuestsRoomsPicker"
@@ -20,6 +21,7 @@ export default function GuestsRoomsPickerForm({
 }: GuestsRoomsFormProps) {
   const intl = useIntl()
   const [isOpen, setIsOpen] = useState(false)
+  const [isAgeError, setIsAgeError] = useState(false)
   const selectedGuests = useWatch({ name })
   const { register, setValue } = useFormContext()
   const ref = useRef<HTMLDivElement | null>(null)
@@ -28,19 +30,29 @@ export default function GuestsRoomsPickerForm({
   }
   function handleSelectGuest(selected: GuestsRoom[]) {
     setValue(name, selected)
+    setIsAgeError(false)
   }
+  const closePicker = useCallback(() => {
+    const guestRoomsValidData = guestRoomsSchema.safeParse(selectedGuests)
+    if (guestRoomsValidData.success) {
+      setIsOpen(false)
+    } else {
+      setIsAgeError(true)
+    }
+  }, [selectedGuests])
+
   useEffect(() => {
     function handleClickOutside(evt: Event) {
       const target = evt.target as HTMLElement
       if (ref.current && target && !ref.current.contains(target)) {
-        setIsOpen(false)
+        closePicker()
       }
     }
     document.addEventListener("click", handleClickOutside)
     return () => {
       document.removeEventListener("click", handleClickOutside)
     }
-  }, [setIsOpen])
+  }, [closePicker])
 
   let selectedAdultsCount = 0
   let selectedChildrenCount = 0
@@ -51,33 +63,34 @@ export default function GuestsRoomsPickerForm({
   })
   const selectedRoomsCount = selectedGuests.length
   const childCountLabel =
-    (selectedChildrenCount > 1
+    selectedChildrenCount > 1
       ? intl.formatMessage({ id: "Children" })
-      : intl.formatMessage({ id: "Child" })) + ", "
+      : intl.formatMessage({ id: "Child" })
 
   return (
     <div className={styles.container} data-isopen={isOpen} ref={ref}>
       <button className={styles.btn} onClick={handleOnClick} type="button">
         <Body className={styles.body}>
-          {selectedAdultsCount}{" "}
-          {selectedAdultsCount > 1
-            ? intl.formatMessage({ id: "Adults" })
-            : intl.formatMessage({ id: "Adult" })}{" "}
-          {", "}
-          {selectedChildrenCount > 0
-            ? selectedChildrenCount + " " + childCountLabel
-            : null}
           {selectedRoomsCount}{" "}
           {selectedRoomsCount > 1
             ? intl.formatMessage({ id: "Rooms" })
             : intl.formatMessage({ id: "Room" })}
+          {", "}
+          {selectedAdultsCount}{" "}
+          {selectedAdultsCount > 1
+            ? intl.formatMessage({ id: "Adults" })
+            : intl.formatMessage({ id: "Adult" })}
+          {selectedChildrenCount > 0
+            ? ", " + selectedChildrenCount + " " + childCountLabel
+            : null}
         </Body>
       </button>
       <div aria-modal className={styles.hideWrapper} role="dialog">
         <GuestsRoomsPicker
           handleOnSelect={handleSelectGuest}
           initialSelected={selectedGuests}
-          closePicker={handleOnClick}
+          closePicker={closePicker}
+          childAgeError={isAgeError}
         />
       </div>
     </div>
diff --git a/types/components/bookingWidget/guestsRoomsPicker.ts b/types/components/bookingWidget/guestsRoomsPicker.ts
index 150dc0334..a888d5cc3 100644
--- a/types/components/bookingWidget/guestsRoomsPicker.ts
+++ b/types/components/bookingWidget/guestsRoomsPicker.ts
@@ -21,12 +21,14 @@ export interface GuestsRoomsPickerProps {
   handleOnSelect: (selected: GuestsRoom[]) => void
   initialSelected?: GuestsRoom[]
   closePicker: () => void
+  childAgeError: boolean
 }
 
 export type GuestsRoomPickerProps = {
   handleOnSelect: (selected: GuestsRoom, index: number) => void
   room: GuestsRoom
   index: number
+  childAgeError: boolean
 }
 
 export type AdultSelectorProps = {
@@ -38,4 +40,5 @@ export type ChildSelectorProps = {
   roomChildren: Child[]
   adultCount: number
   updateChildren: (children: Child[]) => void
+  childAgeError: boolean
 }