Merged in feat/SW-618-payment-non-happy-path (pull request #874)

Feat/SW-618 payment non happy path

* feat(SW-618): filter out expired saved cards

* feat(SW-618): Added payment error codes and way of showing messages based on code

* feat(SW-618): show error message if max retries has been reached and remove search param after showing toast

* fix(SW-618): move fallback error codes

* fix(SW-618): remove ref from stopping useEffect to run twice

* fix(SW-618): refactored logic for toast message and minor fixes

* fix(SW-618): remove error message enum due to static analysis problems


Approved-by: Christian Andolf
Approved-by: Arvid Norlin

components/HotelReservation/EnterDetails/Payment/index.tsx

@@ -28,6 +28,7 @@ import Body from "@/components/TempDesignSystem/Text/Body"
 import Caption from "@/components/TempDesignSystem/Text/Caption"
 import { toast } from "@/components/TempDesignSystem/Toasts"
 import { useHandleBookingStatus } from "@/hooks/booking/useHandleBookingStatus"
+import { usePaymentFailedToast } from "@/hooks/booking/usePaymentFailedToast"
 import useLang from "@/hooks/useLang"
 
 import { bedTypeMap } from "../../SelectRate/RoomSelection/utils"
@@ -41,7 +42,7 @@ import { RoomPackageCodeEnum } from "@/types/components/hotelReservation/selectR
 import { PaymentProps } from "@/types/components/hotelReservation/selectRate/section"
 import { BreakfastPackageEnum } from "@/types/enums/breakfast"
 
-const maxRetries = 40
+const maxRetries = 4
 const retryInterval = 2000
 
 export const formId = "submit-booking"
@@ -87,6 +88,8 @@ export default function Payment({
   const [availablePaymentOptions, setAvailablePaymentOptions] =
     useState(otherPaymentOptions)
 
+  usePaymentFailedToast()
+
   const methods = useForm<PaymentFormData>({
     defaultValues: {
       paymentMethod: savedCreditCards?.length
@@ -105,23 +108,29 @@ export default function Payment({
       if (result?.confirmationNumber) {
         setConfirmationNumber(result.confirmationNumber)
       } else {
-        // TODO: add proper error message
-        toast.error("Failed to create booking")
+        toast.error(
+          intl.formatMessage({
+            id: "payment.error.failed",
+          })
+        )
       }
     },
     onError: (error) => {
       console.error("Error", error)
-      // TODO: add proper error message
-      toast.error("Failed to create booking")
+      toast.error(
+        intl.formatMessage({
+          id: "payment.error.failed",
+        })
+      )
     },
   })
 
-  const bookingStatus = useHandleBookingStatus(
+  const bookingStatus = useHandleBookingStatus({
     confirmationNumber,
-    BookingStatusEnum.PaymentRegistered,
+    expectedStatus: BookingStatusEnum.BookingCompleted,
     maxRetries,
-    retryInterval
-  )
+    retryInterval,
+  })
 
   useEffect(() => {
     if (window.ApplePaySession) {
@@ -138,8 +147,14 @@ export default function Payment({
   useEffect(() => {
     if (bookingStatus?.data?.paymentUrl) {
       router.push(bookingStatus.data.paymentUrl)
+    } else if (bookingStatus.isTimeout) {
+      toast.error(
+        intl.formatMessage({
+          id: "payment.error.failed",
+        })
+      )
     }
-  }, [bookingStatus, router])
+  }, [bookingStatus, router, intl])
 
   useEffect(() => {
     setIsSubmittingDisabled(