Merged in chore/add-error-details-for-sentry (pull request #3378)

Include more details when throwing errors for debugging in Sentry

* WIP throw errors with more details for debugging in Sentry

* Fix throwing response-data

* Clearer message when a response fails

* Add message to errors

* better typings

* .

* Try to send profileID and membershipNumber to Sentry when we fail to parse the apiResponse

* rename notFound -> notFoundError

* Merge branch 'master' of bitbucket.org:scandic-swap/web into chore/add-error-details-for-sentry


Approved-by: Linus Flood
This commit is contained in:
Joakim Jäderberg
2026-01-12 09:01:44 +00:00
parent 575763aaa2
commit 99537b13e8
37 changed files with 641 additions and 293 deletions

View File

@@ -1,7 +1,7 @@
import { createCounter } from "@scandic-hotels/common/telemetry"
import { router } from "../../.."
import { notFound } from "../../../errors"
import { notFoundError } from "../../../errors"
import {
GetDestinationCityPage,
GetDestinationCityPageRefs,
@@ -34,9 +34,10 @@ export const destinationCityPageQueryRouter = router({
metricsGetDestinationCityPageRefs.start()
const variables = { locale: lang, uid }
const refsResponse = await request<GetDestinationCityPageRefsSchema>(
GetDestinationCityPageRefs,
{ locale: lang, uid },
variables,
{
key: generateRefsResponseTag(lang, uid),
ttl: "max",
@@ -44,9 +45,11 @@ export const destinationCityPageQueryRouter = router({
)
if (!refsResponse.data) {
const notFoundError = notFound(refsResponse)
metricsGetDestinationCityPageRefs.noDataError()
throw notFoundError
throw notFoundError({
message: "GetDestinationCityPageRefs returned no data",
errorDetails: variables,
})
}
const validatedRefsData = destinationCityPageRefsSchema.safeParse(
@@ -73,19 +76,19 @@ export const destinationCityPageQueryRouter = router({
const response = await request<GetDestinationCityPageData>(
GetDestinationCityPage,
{
locale: lang,
uid,
},
variables,
{
key: tags,
ttl: "max",
}
)
if (!response.data) {
const notFoundError = notFound(response)
metricsGetDestinationCityPage.noDataError()
throw notFoundError
throw notFoundError({
message: "GetDestinationCityPage returned no data",
errorDetails: variables,
})
}
const validatedResponse = destinationCityPageSchema.safeParse(response.data)