From 876370e81738e109bf5bf1d437f0e653062e680f Mon Sep 17 00:00:00 2001
From: Chuma McPhoy <chuma.mcphoy@scandichotels.com>
Date: Tue, 12 Nov 2024 15:22:35 +0100
Subject: [PATCH] fix(SW-739): pr review fixes

---
 lib/api/endpoints.ts                        |  1 -
 server/routers/contentstack/reward/query.ts | 10 +++++-----
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/lib/api/endpoints.ts b/lib/api/endpoints.ts
index 4e5258db0..781a19f38 100644
--- a/lib/api/endpoints.ts
+++ b/lib/api/endpoints.ts
@@ -178,7 +178,6 @@ export namespace endpoints {
         export const reward = `${base.path.profile}/${version}/${base.enitity.Reward}`
         export const redeem = `${base.path.profile}/${version}/${base.enitity.Reward}/redeem`
         export const unwrap = `${base.path.profile}/${version}/${base.enitity.Reward}/unwrap`
-        // TODO: add surprise endpoint once available.
 
         export function claim(rewardId: string) {
           return `${base.path.profile}/${version}/${base.enitity.Reward}/Claim/${rewardId}`
diff --git a/server/routers/contentstack/reward/query.ts b/server/routers/contentstack/reward/query.ts
index 565ead0a5..b1f5ccb8c 100644
--- a/server/routers/contentstack/reward/query.ts
+++ b/server/routers/contentstack/reward/query.ts
@@ -46,7 +46,7 @@ export const rewardQueryRouter = router({
     .query(async function ({ input, ctx }) {
       getAllRewardCounter.add(1)
 
-      const allApiRewards = !!env.USE_NEW_REWARDS_ENDPOINT
+      const allApiRewards = env.USE_NEW_REWARDS_ENDPOINT
         ? await getCachedAllTierRewards(ctx.serviceToken)
         : await getAllCachedApiRewards(ctx.serviceToken)
 
@@ -108,7 +108,7 @@ export const rewardQueryRouter = router({
       getByLevelRewardCounter.add(1)
       const { level_id } = input
 
-      const allUpcomingApiRewards = !!env.USE_NEW_REWARDS_ENDPOINT
+      const allUpcomingApiRewards = env.USE_NEW_REWARDS_ENDPOINT
         ? await getCachedAllTierRewards(ctx.serviceToken)
         : await getAllCachedApiRewards(ctx.serviceToken)
 
@@ -146,7 +146,7 @@ export const rewardQueryRouter = router({
           if (contentStackReward) {
             return contentStackReward
           } else {
-            console.error("No contentStackReward found", reward?.rewardId)
+            console.info("No contentStackReward found", reward?.rewardId)
           }
         })
         .filter((reward): reward is Reward => Boolean(reward))
@@ -161,7 +161,7 @@ export const rewardQueryRouter = router({
 
       const { limit, cursor } = input
 
-      const isNewEndpoint = !!env.USE_NEW_REWARDS_ENDPOINT
+      const isNewEndpoint = env.USE_NEW_REWARDS_ENDPOINT
       const endpoint = isNewEndpoint
         ? api.endpoints.v1.Profile.Reward.reward
         : api.endpoints.v1.Profile.reward
@@ -256,7 +256,7 @@ export const rewardQueryRouter = router({
   surprises: contentStackBaseWithProtectedProcedure.query(async ({ ctx }) => {
     getCurrentRewardCounter.add(1)
 
-    const isNewEndpoint = !!env.USE_NEW_REWARDS_ENDPOINT
+    const isNewEndpoint = env.USE_NEW_REWARDS_ENDPOINT
     const endpoint = isNewEndpoint
       ? api.endpoints.v1.Profile.Reward.reward
       : api.endpoints.v1.Profile.reward