Merged in fix/linting (pull request #2708)

Fix/linting

* fix import issues and add lint check no-extraneous-dependencies
* fix use type HotelType instead of string

Approved-by: Anton Gunnarsson
This commit is contained in:
Joakim Jäderberg
2025-08-27 09:22:37 +00:00
parent 67bdf5bbcf
commit 80c3327419
55 changed files with 250 additions and 135 deletions

View File

@@ -1,10 +1,9 @@
import type { Meta, StoryObj } from '@storybook/react-vite'
import type { Meta, StoryObj } from '@storybook/nextjs-vite'
import { HotelCard } from './index'
import { fn } from 'storybook/test'
import { RateTypeEnum } from '@scandic-hotels/common/constants/rateType'
import { HotelTypeEnum } from '@scandic-hotels/trpc/enums/hotelType'
import { Button } from '@scandic-hotels/design-system/Button'
import { Button } from '../Button'
import { MaterialIcon } from '../Icons/MaterialIcon'
const meta: Meta<typeof HotelCard> = {
@@ -37,7 +36,7 @@ export const Default: Story = {
name: 'Test Hotel',
address: { streetAddress: '123 Test Street', city: 'Test City' },
description: 'A great place to stay.',
hotelType: HotelTypeEnum.Signature,
hotelType: 'signature',
detailedFacilities: [],
ratings: {
tripAdvisor: 4,
@@ -81,7 +80,6 @@ export const Default: Story = {
onPress={() => fn()}
variant="Text"
typography="Body/Paragraph/mdBold"
// eslint-disable-next-line formatjs/no-literal-string-in-jsx
>
Read more
<MaterialIcon icon="chevron_right" size={24} color="CurrentColor" />

View File

@@ -1,7 +1,7 @@
import Image from '@scandic-hotels/design-system/Image'
import Image from '../../Image'
import { hotelCardDialogImageVariants } from './variants'
import { TripAdvisorChip } from '@scandic-hotels/design-system/TripAdvisorChip'
import { TripAdvisorChip } from '../../TripAdvisorChip'
import styles from './hotelCardDialogImage.module.css'

View File

@@ -1,4 +1,4 @@
import SkeletonShimmer from '@scandic-hotels/design-system/SkeletonShimmer'
import SkeletonShimmer from '../SkeletonShimmer'
import styles from './HotelCardSkeleton.module.css'

View File

@@ -1,12 +1,23 @@
import { useIntl } from 'react-intl'
import { CurrencyEnum } from '@scandic-hotels/common/constants/currency'
import Caption from '@scandic-hotels/design-system/Caption'
import Subtitle from '@scandic-hotels/design-system/Subtitle'
import Caption from '../../Caption'
import Subtitle from '../../Subtitle'
import styles from './hotelChequeCard.module.css'
import type { ProductTypeCheque } from '@scandic-hotels/trpc/types/availability'
type ProductTypeCheque = {
localPrice: {
numberOfCheques: number
additionalPricePerStay: number
currency: CurrencyEnum | null | undefined
}
requestedPrice?: {
numberOfCheques: number
additionalPricePerStay: number
currency: CurrencyEnum | null | undefined
}
}
export default function HotelChequeCard({
productTypeCheque,

View File

@@ -1,4 +1,4 @@
import type { Meta, StoryObj } from '@storybook/react-vite'
import type { Meta, StoryObj } from '@storybook/nextjs-vite'
import { StandaloneHotelCardDialog } from './index'
import { fn } from 'storybook/test'

View File

@@ -4,15 +4,15 @@ import { useState } from 'react'
import { useIntl } from 'react-intl'
import { selectRate } from '@scandic-hotels/common/constants/routes/hotelReservation'
import Body from '@scandic-hotels/design-system/Body'
import Caption from '@scandic-hotels/design-system/Caption'
import Footnote from '@scandic-hotels/design-system/Footnote'
import { IconButton } from '@scandic-hotels/design-system/IconButton'
import { MaterialIcon } from '@scandic-hotels/design-system/Icons/MaterialIcon'
import Link from '@scandic-hotels/design-system/Link'
import { OldDSButton as Button } from '@scandic-hotels/design-system/OldDSButton'
import Subtitle from '@scandic-hotels/design-system/Subtitle'
import { Typography } from '@scandic-hotels/design-system/Typography'
import Body from '../../../Body'
import Caption from '../../../Caption'
import Footnote from '../../../Footnote'
import { IconButton } from '../../../IconButton'
import { MaterialIcon } from '../../../Icons/MaterialIcon'
import Link from '../../../Link'
import { OldDSButton as Button } from '../../../OldDSButton'
import Subtitle from '../../../Subtitle'
import { Typography } from '../../../Typography'
import { NoPriceAvailableCard } from '../../NoPriceAvailableCard'
import { HotelCardDialogImage } from '../../HotelCardDialogImage'
@@ -20,7 +20,7 @@ import { HotelCardDialogImage } from '../../HotelCardDialogImage'
import styles from './standaloneHotelCardDialog.module.css'
import { Lang } from '@scandic-hotels/common/constants/language'
import { HotelPin } from '../../../Map/types'
import { FacilityToIcon } from '@scandic-hotels/design-system/FacilityToIcon'
import { FacilityToIcon } from '../../../FacilityToIcon'
import { HotelPointsRow } from '../../HotelPointsRow'
interface StandaloneHotelCardProps {

View File

@@ -1,7 +1,7 @@
import { useIntl } from 'react-intl'
import Caption from '@scandic-hotels/design-system/Caption'
import Subtitle from '@scandic-hotels/design-system/Subtitle'
import Caption from '../../Caption'
import Subtitle from '../../Subtitle'
import styles from './hotelPointsRow.module.css'

View File

@@ -1,10 +1,10 @@
import { cx } from 'class-variance-authority'
import { useIntl } from 'react-intl'
import Body from '@scandic-hotels/design-system/Body'
import Caption from '@scandic-hotels/design-system/Caption'
import { Divider } from '@scandic-hotels/design-system/Divider'
import Subtitle from '@scandic-hotels/design-system/Subtitle'
import Body from '../../Body'
import Caption from '../../Caption'
import { Divider } from '../../Divider'
import Subtitle from '../../Subtitle'
import { RateTypeEnum } from '@scandic-hotels/common/constants/rateType'
import styles from './hotelPriceCard.module.css'

View File

@@ -1,12 +1,14 @@
import { useIntl } from 'react-intl'
import { CurrencyEnum } from '@scandic-hotels/common/constants/currency'
import Caption from '@scandic-hotels/design-system/Caption'
import Subtitle from '@scandic-hotels/design-system/Subtitle'
import Caption from '../../Caption'
import Subtitle from '../../Subtitle'
import styles from './hotelVoucherCard.module.css'
import type { ProductTypeVoucher } from '@scandic-hotels/trpc/types/availability'
type ProductTypeVoucher = {
numberOfVouchers: number
}
export default function HotelVoucherCard({
productTypeVoucher,

View File

@@ -1,7 +1,7 @@
import { useIntl } from 'react-intl'
import { MaterialIcon } from '@scandic-hotels/design-system/Icons/MaterialIcon'
import { Typography } from '@scandic-hotels/design-system/Typography'
import { MaterialIcon } from '../../Icons/MaterialIcon'
import { Typography } from '../../Typography'
import styles from './noPriceAvailable.module.css'

View File

@@ -11,17 +11,15 @@ import {
selectRate,
} from '@scandic-hotels/common/constants/routes/hotelReservation'
import { getSingleDecimal } from '@scandic-hotels/common/utils/numberFormatting'
import Caption from '@scandic-hotels/design-system/Caption'
import { Divider } from '@scandic-hotels/design-system/Divider'
import { FacilityToIcon } from '@scandic-hotels/design-system/FacilityToIcon'
import HotelLogoIcon from '@scandic-hotels/design-system/Icons/HotelLogoIcon'
import ImageGallery, {
GalleryImage,
} from '@scandic-hotels/design-system/ImageGallery'
import Caption from '../Caption'
import { Divider } from '../Divider'
import { FacilityToIcon } from '../FacilityToIcon'
import HotelLogoIcon from '../Icons/Logos'
import ImageGallery, { GalleryImage } from '../ImageGallery'
import { HotelPointsRow } from './HotelPointsRow'
import { NoPriceAvailableCard } from './NoPriceAvailableCard'
import Link from '@scandic-hotels/design-system/Link'
import { Typography } from '@scandic-hotels/design-system/Typography'
import Link from '../Link'
import { Typography } from '../Typography'
import HotelChequeCard from './HotelChequeCard'
import { HotelPriceCard } from './HotelPriceCard'