Merged in chore/price-calculation-tests (pull request #3072)

chore: Add more price calculation tests

* Add tests and refactor types for getVoucherPrice

* Add tests for sumPackagesRequestedPrice

* Add tests for calculateVat


Approved-by: Joakim Jäderberg
This commit is contained in:
Anton Gunnarsson
2025-11-04 12:50:51 +00:00
parent dc42a22513
commit 7fc49428c7
4 changed files with 214 additions and 12 deletions

View File

@@ -4,7 +4,12 @@ import { AlertTypeEnum } from "@scandic-hotels/common/constants/alert"
import { CurrencyEnum } from "@scandic-hotels/common/constants/currency"
import { dt } from "@scandic-hotels/common/dt"
import { filterOverlappingDates, sumPackages } from "./index"
import {
calculateVat,
filterOverlappingDates,
sumPackages,
sumPackagesRequestedPrice,
} from "./index"
import type { specialAlertsSchema } from "@scandic-hotels/trpc/routers/hotels/schemas/hotel/specialAlerts"
import type { z } from "zod"
@@ -98,3 +103,42 @@ describe("sumPackages", () => {
expect(result).toEqual({ currency: CurrencyEnum.SEK, price: 350 })
})
})
describe("sumPackagesRequestedPrice", () => {
it("returns 0 price for null packages", () => {
const result = sumPackagesRequestedPrice(null)
expect(result).toEqual({ currency: undefined, price: 0 })
})
it("returns 0 price for undefined packages", () => {
const result = sumPackagesRequestedPrice(undefined)
expect(result).toEqual({ currency: undefined, price: 0 })
})
it("returns 0 price for empty packages", () => {
const result = sumPackagesRequestedPrice([])
expect(result).toEqual({ currency: undefined, price: 0 })
})
it("sums prices of packages", () => {
const result = sumPackagesRequestedPrice([
{ requestedPrice: { totalPrice: 100, currency: CurrencyEnum.SEK } },
{ requestedPrice: { totalPrice: 200, currency: CurrencyEnum.SEK } },
{ requestedPrice: { totalPrice: 50, currency: CurrencyEnum.SEK } },
])
expect(result).toEqual({ currency: CurrencyEnum.SEK, price: 350 })
})
})
describe("calculateVat", () => {
it("calculates VAT correctly", () => {
expect(calculateVat(100, 25)).toEqual({
priceExclVat: 80,
vatAmount: 20,
})
expect(calculateVat(5, 100)).toEqual({
priceExclVat: 2.5,
vatAmount: 2.5,
})
})
})

View File

@@ -9,7 +9,6 @@ import { ChildBedTypeEnum } from "@scandic-hotels/trpc/enums/childBedTypeEnum"
import { RoomPackageCodeEnum } from "@scandic-hotels/trpc/enums/roomFilter"
import type { CurrencyEnum } from "@scandic-hotels/common/constants/currency"
import type { Packages } from "@scandic-hotels/trpc/types/packages"
import type { JSX } from "react"
import type { RoomPackageCodes } from "../../types/components/selectRate/roomFilter"
@@ -63,7 +62,12 @@ export function sumPackages(
)
}
export function sumPackagesRequestedPrice(packages: Packages | null) {
export function sumPackagesRequestedPrice(
packages:
| { requestedPrice: { totalPrice: number; currency?: CurrencyEnum } }[]
| null
| undefined
) {
if (!packages || !packages.length) {
return {
currency: undefined,