scandic/web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged in fix/SW-2311-campaign-tracking (pull request #2753)

Browse Source 
fix(SW-2311): update campaign tracking values

* fix(SW-2311): update campaign tracking values


Approved-by: Erik Tiekstra
This commit is contained in:
Matilda Landström
2025-09-03 10:58:54 +00:00
parent 941eb51665
commit 7bad898d9d
6 changed files with 16 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/scandic-web/components/ContentType/CampaignOverviewPage/index.tsx
View File

@@ -21,8 +21,8 @@ export default async function CampaignOverviewPage() {
notFound() notFound()
} }
const { campaignOverviewPage, tracking } = pageData const { campaign_overview_page, tracking } = pageData
const { header, topCampaign, blocks } = campaignOverviewPage const { header, topCampaign, blocks } = campaign_overview_page
return ( return (
<> <>

4
apps/scandic-web/components/ContentType/CampaignPage/index.tsx
View File

@@ -21,8 +21,8 @@ export default async function CampaignPage() {
notFound() notFound()
} }
const { campaignPage, tracking } = pageData const { campaign_page, tracking } = pageData
const { heading, subheading, preamble, blocks, hero } = campaignPage const { heading, subheading, preamble, blocks, hero } = campaign_page
return ( return (
<> <>

3
packages/common/tracking/types.ts
View File

@@ -8,8 +8,7 @@ export enum TrackingChannelEnum {
"static-content-page" = "static-content-page", "static-content-page" = "static-content-page",
"hotelreservation" = "hotelreservation", "hotelreservation" = "hotelreservation",
"collection-page" = "collection-page", "collection-page" = "collection-page",
"campaign-page" = "campaign-page", "campaign" = "campaign",
"campaign-overview-page" = "campaign-overview-page",
"hotels" = "hotels", "hotels" = "hotels",
"homepage" = "homepage", "homepage" = "homepage",
} }

10
packages/trpc/lib/routers/contentstack/campaignOverviewPage/query.ts
View File

@@ -103,19 +103,19 @@ export const campaignOverviewPageQueryRouter = router({
return null return null
} }
const campaignOverviewPage = validatedResponse.data.campaign_overview_page const { campaign_overview_page, trackingProps } = validatedResponse.data
metricsGetCampaignOverviewPage.success() metricsGetCampaignOverviewPage.success()
const system = campaignOverviewPage.system const system = campaign_overview_page.system
const pageName = `campaign-overview-page` const pageName = trackingProps.url
const tracking: TrackingPageData = { const tracking: TrackingPageData = {
pageId: system.uid, pageId: system.uid,
domainLanguage: system.locale, domainLanguage: system.locale,
publishDate: system.updated_at, publishDate: system.updated_at,
createDate: system.created_at, createDate: system.created_at,
channel: "campaign-overview-page", channel: "campaign",
pageType: "campaignoverviewpage", pageType: "campaignoverviewpage",
pageName, pageName,
siteSections: pageName, siteSections: pageName,
@@ -123,7 +123,7 @@ export const campaignOverviewPageQueryRouter = router({
} }
return { return {
campaignOverviewPage, campaign_overview_page,
tracking, tracking,
} }
}), }),

10
packages/trpc/lib/routers/contentstack/campaignPage/query.ts
View File

@@ -94,19 +94,19 @@ export const campaignPageQueryRouter = router({
return null return null
} }
const campaignPage = validatedResponse.data.campaign_page const { campaign_page, trackingProps } = validatedResponse.data
metricsGetCampaignPage.success() metricsGetCampaignPage.success()
const system = campaignPage.system const system = campaign_page.system
const pageName = `campaign-page` const pageName = trackingProps.url
const tracking: TrackingPageData = { const tracking: TrackingPageData = {
pageId: system.uid, pageId: system.uid,
domainLanguage: system.locale, domainLanguage: system.locale,
publishDate: system.updated_at, publishDate: system.updated_at,
createDate: system.created_at, createDate: system.created_at,
channel: "campaign-page", channel: "campaign",
pageType: "campaigncollectionpage", pageType: "campaigncollectionpage",
pageName, pageName,
siteSections: pageName, siteSections: pageName,
@@ -114,7 +114,7 @@ export const campaignPageQueryRouter = router({
} }
return { return {
campaignPage, campaign_page,
tracking, tracking,
} }
}), }),

3
packages/trpc/lib/routers/types.ts
View File

@@ -23,10 +23,9 @@ type TrackingSDKChannel =
| "static-content-page" | "static-content-page"
| "hotelreservation" | "hotelreservation"
| "collection-page" | "collection-page"
| "campaign-page" | "campaign"
| "hotels" | "hotels"
| "homepage" | "homepage"
| "campaign-overview-page"
export type TrackingUserData = export type TrackingUserData =
| { | {