scandic/web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merged in fix/cleanup-metrics-attributes (pull request #494)

Browse Source 
fix: remove toString() in metric attributes to avooid silly data like Object: Object

Approved-by: Michael Zetterberg
This commit is contained in:
Arvid Norlin
2024-08-26 13:06:58 +00:00
committed by Michael Zetterberg
parent 1b54837ca9 b56069e009
commit 7949039521
2 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
server/routers/hotels/query.ts
View File

@@ -44,7 +44,7 @@ export const hotelQueryRouter = router({
console.info( console.info(
"api.hotels.hotel start", "api.hotels.hotel start",
JSON.stringify({ JSON.stringify({
query: { hotelId, params: params.toString() }, query: { hotelId, params },
}) })
) )
const apiResponse = await api.get( const apiResponse = await api.get(
@@ -74,7 +74,7 @@ export const hotelQueryRouter = router({
console.error( console.error(
"api.hotels.hotel error", "api.hotels.hotel error",
JSON.stringify({ JSON.stringify({
query: { hotelId, params: params.toString() }, query: { hotelId, params },
error: { error: {
status: apiResponse.status, status: apiResponse.status,
statusText: apiResponse.statusText, statusText: apiResponse.statusText,
@@ -99,7 +99,7 @@ export const hotelQueryRouter = router({
console.error( console.error(
"api.hotels.hotel validation error", "api.hotels.hotel validation error",
JSON.stringify({ JSON.stringify({
query: { hotelId, params: params.toString() }, query: { hotelId, params },
error: validatedHotelData.error, error: validatedHotelData.error,
}) })
) )
@@ -129,7 +129,7 @@ export const hotelQueryRouter = router({
console.error( console.error(
"api.hotels.hotel validation error", "api.hotels.hotel validation error",
JSON.stringify({ JSON.stringify({
query: { hotelId, params: params.toString() }, query: { hotelId, params },
error: validatedRoom.error, error: validatedRoom.error,
}) })
) )
@@ -144,7 +144,7 @@ export const hotelQueryRouter = router({
console.info( console.info(
"api.hotels.hotel success", "api.hotels.hotel success",
JSON.stringify({ JSON.stringify({
query: { hotelId, params: params.toString() }, query: { hotelId, params: params },
}) })
) )
return { return {

34
server/routers/user/query.ts
View File

@@ -369,7 +369,7 @@ export const userQueryRouter = router({
const params = new URLSearchParams() const params = new URLSearchParams()
params.set("limit", "1") params.set("limit", "1")
getPreviousStaysCounter.add(1, { params: params.toString() }) getPreviousStaysCounter.add(1, { query: JSON.stringify({ params }) })
console.info( console.info(
"api.booking.stays.past start", "api.booking.stays.past start",
JSON.stringify({ query: { params } }) JSON.stringify({ query: { params } })
@@ -454,10 +454,10 @@ export const userQueryRouter = router({
if (cursor) { if (cursor) {
params.offset = cursor params.offset = cursor
} }
getPreviousStaysCounter.add(1, { params: params.toString() }) getPreviousStaysCounter.add(1, { query: JSON.stringify({ params }) })
console.info( console.info(
"api.booking.stays.past start", "api.booking.stays.past start",
JSON.stringify({ query: { params: params.toString() } }) JSON.stringify({ query: { params } })
) )
const apiResponse = await api.get( const apiResponse = await api.get(
@@ -473,7 +473,7 @@ export const userQueryRouter = router({
if (!apiResponse.ok) { if (!apiResponse.ok) {
const text = await apiResponse.text() const text = await apiResponse.text()
getPreviousStaysFailCounter.add(1, { getPreviousStaysFailCounter.add(1, {
query: JSON.stringify({ params: params.toString() }), query: JSON.stringify({ params }),
error_type: "http_error", error_type: "http_error",
error: JSON.stringify({ error: JSON.stringify({
status: apiResponse.status, status: apiResponse.status,
@@ -484,7 +484,7 @@ export const userQueryRouter = router({
console.error( console.error(
"api.booking.stays.past error ", "api.booking.stays.past error ",
JSON.stringify({ JSON.stringify({
query: { params: params.toString() }, query: { params },
error: { error: {
status: apiResponse.status, status: apiResponse.status,
statusText: apiResponse.statusText, statusText: apiResponse.statusText,
@@ -500,14 +500,14 @@ export const userQueryRouter = router({
const verifiedData = getStaysSchema.safeParse(apiJson) const verifiedData = getStaysSchema.safeParse(apiJson)
if (!verifiedData.success) { if (!verifiedData.success) {
getPreviousStaysFailCounter.add(1, { getPreviousStaysFailCounter.add(1, {
query: JSON.stringify({ params: params.toString() }), query: JSON.stringify({ params }),
error_type: "validation_error", error_type: "validation_error",
error: JSON.stringify(verifiedData.error), error: JSON.stringify(verifiedData.error),
}) })
console.error( console.error(
"api.booking.stays.past validation error ", "api.booking.stays.past validation error ",
JSON.stringify({ JSON.stringify({
query: { params: params.toString() }, query: { params },
error: verifiedData.error, error: verifiedData.error,
}) })
) )
@@ -515,11 +515,11 @@ export const userQueryRouter = router({
return null return null
} }
getPreviousStaysSuccessCounter.add(1, { getPreviousStaysSuccessCounter.add(1, {
query: JSON.stringify({ params: params.toString() }), query: JSON.stringify({ params }),
}) })
console.info( console.info(
"api.booking.stays.past success", "api.booking.stays.past success",
JSON.stringify({ query: { params: params.toString() } }) JSON.stringify({ query: { params } })
) )
const nextCursor = const nextCursor =
verifiedData.data.links && verifiedData.data.links &&
@@ -549,11 +549,11 @@ export const userQueryRouter = router({
params.offset = cursor params.offset = cursor
} }
getUpcomingStaysCounter.add(1, { getUpcomingStaysCounter.add(1, {
query: JSON.stringify({ params: params.toString() }), query: JSON.stringify({ params }),
}) })
console.info( console.info(
"api.booking.stays.future start", "api.booking.stays.future start",
JSON.stringify({ query: { params: params.toString() } }) JSON.stringify({ query: { params } })
) )
const apiResponse = await api.get( const apiResponse = await api.get(
api.endpoints.v1.upcomingStays, api.endpoints.v1.upcomingStays,
@@ -568,7 +568,7 @@ export const userQueryRouter = router({
if (!apiResponse.ok) { if (!apiResponse.ok) {
const text = await apiResponse.text() const text = await apiResponse.text()
getUpcomingStaysFailCounter.add(1, { getUpcomingStaysFailCounter.add(1, {
query: JSON.stringify({ params: params.toString() }), query: JSON.stringify({ params }),
error_type: "http_error", error_type: "http_error",
error: JSON.stringify({ error: JSON.stringify({
status: apiResponse.status, status: apiResponse.status,
@@ -579,7 +579,7 @@ export const userQueryRouter = router({
console.error( console.error(
"api.booking.stays.future error ", "api.booking.stays.future error ",
JSON.stringify({ JSON.stringify({
query: { params: params.toString() }, query: { params },
error_type: "http_error", error_type: "http_error",
error: { error: {
status: apiResponse.status, status: apiResponse.status,
@@ -595,24 +595,24 @@ export const userQueryRouter = router({
const verifiedData = getStaysSchema.safeParse(apiJson) const verifiedData = getStaysSchema.safeParse(apiJson)
if (!verifiedData.success) { if (!verifiedData.success) {
getUpcomingStaysFailCounter.add(1, { getUpcomingStaysFailCounter.add(1, {
query: JSON.stringify({ params: params.toString() }), query: JSON.stringify({ params }),
error_type: "validation_error", error_type: "validation_error",
error: JSON.stringify(verifiedData.error), error: JSON.stringify(verifiedData.error),
}) })
console.error( console.error(
"api.booking.stays.future validation error ", "api.booking.stays.future validation error ",
JSON.stringify({ JSON.stringify({
query: { params: params.toString() }, query: { params },
error: verifiedData.error, error: verifiedData.error,
}) })
) )
return null return null
} }
getUpcomingStaysSuccessCounter.add(1, { getUpcomingStaysSuccessCounter.add(1, {
query: JSON.stringify({ params: params.toString() }), query: JSON.stringify({ params }),
}) })
console.info("api.booking.stays.future success", { console.info("api.booking.stays.future success", {
query: { params: params.toString() }, query: JSON.stringify({ params }),
}) })
const nextCursor = const nextCursor =
verifiedData.data.links && verifiedData.data.links &&