Merged in fix/tripadvisor-rating (pull request #2193)

fix(SW-2892): don't show Tripadvisor rating if undefined

* fix: don't show rating if undefined


Approved-by: Bianca Widstam
Approved-by: Christian Andolf
Approved-by: Erik Tiekstra

apps/scandic-web/components/ContentType/DestinationPage/HotelMapCard/DialogImage/index.tsx

@@ -7,16 +7,16 @@ import Chip from "@/components/TempDesignSystem/Chip"
 import styles from "./dialogImage.module.css"
 
 interface DialogImageProps {
-  image: string | undefined
+  image?: string
-  altText: string | undefined
+  altText?: string
-  ratings: number
+  rating?: number
   imageError: boolean
   setImageError: (error: boolean) => void
 }
 export default function DialogImage({
   image,
   altText,
-  ratings,
+  rating,
   imageError,
   setImageError,
 }: DialogImageProps) {
@@ -32,14 +32,16 @@ export default function DialogImage({
           onError={() => setImageError(true)}
         />
       )}
-      <div className={styles.tripAdvisor}>
+      {rating ? (
-        <Chip className={styles.tripAdvisor}>
+        <div className={styles.tripAdvisor}>
-          <TripadvisorIcon color="Icon/Interactive/Default" />
+          <Chip className={styles.tripAdvisor}>
-          <Typography variant="Tag/sm">
+            <TripadvisorIcon color="Icon/Interactive/Default" />
-            <p>{ratings}</p>
+            <Typography variant="Tag/sm">
-          </Typography>
+              <span>{rating}</span>
-        </Chip>
+            </Typography>
-      </div>
+          </Chip>
+        </div>
+      ) : null}
     </div>
   )
 }

apps/scandic-web/components/ContentType/DestinationPage/HotelMapCard/index.tsx

@@ -68,7 +68,7 @@ export default function HotelMapCard({
           <DialogImage
             image={image.src}
             altText={image.alt}
-            ratings={tripadvisorRating || 0}
+            rating={tripadvisorRating}
             imageError={imageError}
             setImageError={setImageError}
           />

apps/scandic-web/components/HotelReservation/HotelCardDialog/HotelCardDialogImage/index.tsx

@@ -12,7 +12,7 @@ import type { HotelCardDialogImageProps } from "@/types/components/hotelReservat
 export default function HotelCardDialogImage({
   firstImage,
   altText,
-  ratings,
+  rating,
   imageError,
   setImageError,
   position,
@@ -31,12 +31,14 @@ export default function HotelCardDialogImage({
           onError={() => setImageError(true)}
         />
       )}
-      <div className={styles.tripAdvisor}>
+      {rating ? (
-        <Chip className={styles.tripAdvisor}>
+        <div className={styles.tripAdvisor}>
-          <TripadvisorIcon color="Icon/Interactive/Default" />
+          <Chip className={styles.tripAdvisor}>
-          {ratings}
+            <TripadvisorIcon color="Icon/Interactive/Default" />
-        </Chip>
+            {rating}
-      </div>
+          </Chip>
+        </div>
+      ) : null}
     </div>
   )
 }

apps/scandic-web/components/HotelReservation/HotelCardDialog/ListingHotelCardDialog/index.tsx

@@ -62,7 +62,7 @@ export default function ListingHotelCardDialog({
         <HotelCardDialogImage
           firstImage={firstImage}
           altText={altText}
-          ratings={ratings || 0}
+          rating={ratings}
           imageError={imageError}
           setImageError={setImageError}
           position="top"

apps/scandic-web/components/HotelReservation/HotelCardDialog/StandaloneHotelCardDialog/index.tsx

@@ -61,7 +61,7 @@ export default function StandaloneHotelCardDialog({
       <HotelCardDialogImage
         firstImage={firstImage}
         altText={altText}
-        ratings={ratings || 0}
+        rating={ratings}
         imageError={imageError}
         setImageError={setImageError}
         position="left"

apps/scandic-web/types/components/hotelReservation/selectHotel/map.ts

@@ -62,9 +62,9 @@ export interface HotelCardDialogProps {
 }
 
 export interface HotelCardDialogImageProps {
-  firstImage: string | undefined
+  firstImage?: string
-  altText: string | undefined
+  altText?: string
-  ratings: number
+  rating?: number | null
   imageError: boolean
   setImageError: (error: boolean) => void
   position: "top" | "left"