From 6f585a2c1e8d24a777474371ff5d1f15432b7ec8 Mon Sep 17 00:00:00 2001 From: Christian Andolf Date: Mon, 28 Apr 2025 14:39:59 +0200 Subject: [PATCH] fix(LOY-52): remove spinner on stay cards to prevent loading to spin indefinitely when opening link in a new tab --- .../DynamicContent/Stays/StayCard/index.tsx | 17 +--------------- .../Stays/StayCard/stay.module.css | 20 +++---------------- 2 files changed, 4 insertions(+), 33 deletions(-) diff --git a/apps/scandic-web/components/Blocks/DynamicContent/Stays/StayCard/index.tsx b/apps/scandic-web/components/Blocks/DynamicContent/Stays/StayCard/index.tsx index ba5387da4..6b384e078 100644 --- a/apps/scandic-web/components/Blocks/DynamicContent/Stays/StayCard/index.tsx +++ b/apps/scandic-web/components/Blocks/DynamicContent/Stays/StayCard/index.tsx @@ -1,13 +1,10 @@ "use client" -import { useState } from "react" - import { MaterialIcon } from "@scandic-hotels/design-system/Icons/MaterialIcon" import { dt } from "@/lib/dt" import Image from "@/components/Image" -import LoadingSpinner from "@/components/LoadingSpinner" import Link from "@/components/TempDesignSystem/Link" import Caption from "@/components/TempDesignSystem/Text/Caption" import Title from "@/components/TempDesignSystem/Text/Title" @@ -18,9 +15,6 @@ import styles from "./stay.module.css" import type { StayCardProps } from "@/types/components/myPages/stays/stayCard" export default function StayCard({ stay }: StayCardProps) { - // TODO: Temporary loading. Remove when current web is deleted. - const [loading, setLoading] = useState(false) - const { bookingUrl, isWebAppOrigin } = stay.attributes const shouldLinkToMyStay = isWebAppOrigin @@ -30,17 +24,8 @@ export default function StayCard({ stay }: StayCardProps) { } return ( - setLoading(true)} - > + - {loading && ( -
- -
- )} ) } diff --git a/apps/scandic-web/components/Blocks/DynamicContent/Stays/StayCard/stay.module.css b/apps/scandic-web/components/Blocks/DynamicContent/Stays/StayCard/stay.module.css index a9347d144..698d582bc 100644 --- a/apps/scandic-web/components/Blocks/DynamicContent/Stays/StayCard/stay.module.css +++ b/apps/scandic-web/components/Blocks/DynamicContent/Stays/StayCard/stay.module.css @@ -2,7 +2,6 @@ outline: 1px solid var(--Base-Border-Subtle); border-radius: var(--Corner-radius-md); overflow: hidden; - position: relative; &:focus, &:hover { @@ -25,10 +24,10 @@ .footer { color: var(--Scandic-Brand-Burgundy); display: grid; - gap: var(--Spacing-x2); + gap: var(--Space-x2); margin-top: auto; overflow: hidden; - padding: var(--Spacing-x2); + padding: var(--Space-x2); width: 100%; } @@ -41,18 +40,5 @@ .date { align-items: center; display: flex; - gap: var(--Spacing-x-half); -} - -.loadingcontainer { - position: absolute; - left: 0; - right: 0; - top: 0; - bottom: 0; - background: rgb(255 255 255 / 80%); - display: flex; - align-items: center; - justify-content: center; - padding-bottom: 70px; + gap: var(--Space-x05); }