From 69ed852fc4cf05fbe4e691a1b6dc6f03fd7dcc59 Mon Sep 17 00:00:00 2001 From: Christian Andolf Date: Fri, 25 Oct 2024 15:44:30 +0200 Subject: [PATCH] fix: only phrasing content is allowed inside buttons meaning no div or p elements, these are now replaced by span --- components/DatePicker/Screen/Desktop.tsx | 4 +-- components/DatePicker/Screen/Mobile.tsx | 4 +-- components/DatePicker/index.tsx | 6 ++-- .../SearchList/ClearSearchButton/index.tsx | 4 +-- .../Forms/BookingWidget/FormContent/index.tsx | 13 ++++--- components/GuestsRoomsPicker/index.tsx | 36 ++++++++++--------- .../Header/MainMenu/MobileMenu/index.tsx | 2 +- .../Header/MainMenu/MyPagesMenu/index.tsx | 6 ++-- .../NavigationMenu/MegaMenu/index.tsx | 4 +-- .../LanguageSwitcherContainer/index.tsx | 12 ++++--- .../TempDesignSystem/Form/Phone/index.tsx | 4 +-- components/TempDesignSystem/Select/index.tsx | 4 +-- 12 files changed, 56 insertions(+), 43 deletions(-) diff --git a/components/DatePicker/Screen/Desktop.tsx b/components/DatePicker/Screen/Desktop.tsx index 9056f9183..d5040a4ae 100644 --- a/components/DatePicker/Screen/Desktop.tsx +++ b/components/DatePicker/Screen/Desktop.tsx @@ -82,8 +82,8 @@ export default function DatePickerDesktop({ size="small" theme="base" > - - {intl.formatMessage({ id: "Select dates" })} + + {intl.formatMessage({ id: "Select dates" })} diff --git a/components/DatePicker/Screen/Mobile.tsx b/components/DatePicker/Screen/Mobile.tsx index 0407f9b63..6e68ba1fc 100644 --- a/components/DatePicker/Screen/Mobile.tsx +++ b/components/DatePicker/Screen/Mobile.tsx @@ -94,8 +94,8 @@ export default function DatePickerMobile({ size="large" theme="base" > - - {intl.formatMessage({ id: "Select dates" })} + + {intl.formatMessage({ id: "Select dates" })}
diff --git a/components/DatePicker/index.tsx b/components/DatePicker/index.tsx index a68f137ea..b18a4d9ca 100644 --- a/components/DatePicker/index.tsx +++ b/components/DatePicker/index.tsx @@ -89,8 +89,10 @@ export default function DatePickerForm({ name = "date" }: DatePickerFormProps) { return (
diff --git a/components/Forms/BookingWidget/FormContent/Search/SearchList/ClearSearchButton/index.tsx b/components/Forms/BookingWidget/FormContent/Search/SearchList/ClearSearchButton/index.tsx index 3b4391998..ae1f8f4d0 100644 --- a/components/Forms/BookingWidget/FormContent/Search/SearchList/ClearSearchButton/index.tsx +++ b/components/Forms/BookingWidget/FormContent/Search/SearchList/ClearSearchButton/index.tsx @@ -33,8 +33,8 @@ export default function ClearSearchButton({ type="button" > - - {intl.formatMessage({ id: "Clear searches" })} + + {intl.formatMessage({ id: "Clear searches" })} ) diff --git a/components/Forms/BookingWidget/FormContent/index.tsx b/components/Forms/BookingWidget/FormContent/index.tsx index bd7a65ba6..eca1634d8 100644 --- a/components/Forms/BookingWidget/FormContent/index.tsx +++ b/components/Forms/BookingWidget/FormContent/index.tsx @@ -65,12 +65,17 @@ export default function FormContent({ theme="base" type="submit" > - - {intl.formatMessage({ id: "Search" })} + + {intl.formatMessage({ id: "Search" })} -
+ -
+
diff --git a/components/GuestsRoomsPicker/index.tsx b/components/GuestsRoomsPicker/index.tsx index f12ecebde..8533f79bd 100644 --- a/components/GuestsRoomsPicker/index.tsx +++ b/components/GuestsRoomsPicker/index.tsx @@ -53,23 +53,25 @@ export default function GuestsRoomsPickerForm() { return (
diff --git a/components/Header/MainMenu/MobileMenu/index.tsx b/components/Header/MainMenu/MobileMenu/index.tsx index 1f2660770..ae79675dd 100644 --- a/components/Header/MainMenu/MobileMenu/index.tsx +++ b/components/Header/MainMenu/MobileMenu/index.tsx @@ -68,7 +68,7 @@ export default function MobileMenu({ })} onClick={() => toggleDropdown(DropdownTypeEnum.HamburgerMenu)} > - + toggleDropdown(DropdownTypeEnum.MyPagesMenu)} > - - {intl.formatMessage({ id: "Hi" })} {user.firstName}! + + + {intl.formatMessage({ id: "Hi" })} {user.firstName}! + toggleMegaMenu(false)} > - - {title} + + {title}
diff --git a/components/LanguageSwitcher/LanguageSwitcherContainer/index.tsx b/components/LanguageSwitcher/LanguageSwitcherContainer/index.tsx index ada415172..0eafafa29 100644 --- a/components/LanguageSwitcher/LanguageSwitcherContainer/index.tsx +++ b/components/LanguageSwitcher/LanguageSwitcherContainer/index.tsx @@ -35,10 +35,12 @@ export default function LanguageSwitcherContainer({ onClick={() => toggleDropdown(position)} > - - {intl.formatMessage({ - id: "Main menu", - })} + + + {intl.formatMessage({ + id: "Main menu", + })} +
@@ -53,7 +55,7 @@ export default function LanguageSwitcherContainer({ })} onClick={() => toggleDropdown(position)} > - + ) : null} diff --git a/components/TempDesignSystem/Form/Phone/index.tsx b/components/TempDesignSystem/Form/Phone/index.tsx index d27e31986..ffe66a67e 100644 --- a/components/TempDesignSystem/Form/Phone/index.tsx +++ b/components/TempDesignSystem/Form/Phone/index.tsx @@ -91,7 +91,7 @@ export default function Phone({ -
+ {props.children} -
+ )} /> diff --git a/components/TempDesignSystem/Select/index.tsx b/components/TempDesignSystem/Select/index.tsx index 64f3fc335..d506c146c 100644 --- a/components/TempDesignSystem/Select/index.tsx +++ b/components/TempDesignSystem/Select/index.tsx @@ -60,12 +60,12 @@ export default function Select({ >