fix(SW-1886): Removed "firstItem" props from blocks as it generates multiple h1 tags on those pages

* feat(SW-1886): Removed "firstItem" props from blocks as it generates multiple h1 tags on those pages


Approved-by: Fredrik Thorsson
Approved-by: Simon.Emanuelsson

apps/scandic-web/components/Blocks/DynamicContent/HowItWorks/index.tsx

@@ -7,13 +7,10 @@ import styles from "./howItWorks.module.css"
 
 import type { HowItWorksProps } from "@/types/components/blocks/dynamicContent"
 
-export default async function HowItWorks({
-  dynamic_content,
-  firstItem,
-}: HowItWorksProps) {
+export default async function HowItWorks({ dynamic_content }: HowItWorksProps) {
   const intl = await getIntl()
   return (
-    <SectionWrapper dynamic_content={dynamic_content} firstItem={firstItem}>
+    <SectionWrapper dynamic_content={dynamic_content}>
       <section className={styles.container}>
         <Title level="h3">{intl.formatMessage({ id: "How it works" })}</Title>
       </section>

apps/scandic-web/components/Blocks/DynamicContent/LoyaltyLevels/index.tsx

@@ -18,14 +18,13 @@ import type { LevelCardProps } from "@/types/components/overviewTable"
 
 export default async function LoyaltyLevels({
   dynamic_content,
-  firstItem,
 }: LoyaltyLevelsProps) {
   const uniqueLevels = await serverClient().contentstack.rewards.all({
     unique: true,
   })
 
   return (
-    <SectionWrapper dynamic_content={dynamic_content} firstItem={firstItem}>
+    <SectionWrapper dynamic_content={dynamic_content}>
       <section className={styles.cardContainer}>
         {uniqueLevels.map((level) => (
           <LevelCard key={level.level_id} level={level} />

apps/scandic-web/components/Blocks/DynamicContent/OverviewTable/index.tsx

@@ -8,7 +8,6 @@ import type { OverviewTableProps } from "@/types/components/blocks/dynamicConten
 
 export default async function OverviewTable({
   dynamic_content,
-  firstItem,
 }: OverviewTableProps) {
   const [levels, membershipLevel] = await Promise.all([
     serverClient().contentstack.rewards.all(),
@@ -16,7 +15,7 @@ export default async function OverviewTable({
   ])
 
   return (
-    <SectionWrapper dynamic_content={dynamic_content} firstItem={firstItem}>
+    <SectionWrapper dynamic_content={dynamic_content}>
       <OverviewTableClient
         levels={levels}
         activeMembership={membershipLevel?.membershipLevel ?? null}

apps/scandic-web/components/Blocks/DynamicContent/SectionWrapper/index.tsx

@@ -7,7 +7,6 @@ import type { DynamicContentProps } from "@/types/components/blocks/dynamicConte
 export default function SectionWrapper({
   children,
   dynamic_content,
-  firstItem,
 }: React.PropsWithChildren<DynamicContentProps>) {
   const displayHeader = !!(
     dynamic_content.link ||
@@ -21,8 +20,8 @@ export default function SectionWrapper({
           link={dynamic_content.link}
           preamble={dynamic_content.subtitle}
           title={dynamic_content.title}
-          headingAs={firstItem ? "h3" : "h4"}
-          headingLevel={firstItem ? "h1" : "h2"}
+          headingAs="h3"
+          headingLevel="h2"
         />
       ) : null}
       {children}

apps/scandic-web/components/Blocks/DynamicContent/index.tsx

@@ -33,7 +33,7 @@ export default function DynamicContent(props: DynamicContentProps) {
 }
 
 function DynamicContentBlocks(props: DynamicContentProps) {
-  const { dynamic_content, firstItem } = props
+  const { dynamic_content } = props
   switch (dynamic_content.component) {
     case DynamicContentEnum.Blocks.components.current_benefits:
       return <CurrentRewardsBlock {...dynamic_content} />
@@ -44,29 +44,17 @@ function DynamicContentBlocks(props: DynamicContentProps) {
         <ExpiringPoints {...dynamic_content} />
       )
     case DynamicContentEnum.Blocks.components.how_it_works:
-      return (
-        <HowItWorks dynamic_content={dynamic_content} firstItem={firstItem} />
-      )
+      return <HowItWorks dynamic_content={dynamic_content} />
     case DynamicContentEnum.Blocks.components.jobylon_feed:
       return <JobylonFeed {...dynamic_content} />
     case DynamicContentEnum.Blocks.components.loyalty_levels:
-      return (
-        <LoyaltyLevels
-          dynamic_content={dynamic_content}
-          firstItem={firstItem}
-        />
-      )
+      return <LoyaltyLevels dynamic_content={dynamic_content} />
     case DynamicContentEnum.Blocks.components.membership_overview:
       return <Overview {...dynamic_content} />
     case DynamicContentEnum.Blocks.components.next_benefits:
       return <NextLevelRewardsBlock {...dynamic_content} />
     case DynamicContentEnum.Blocks.components.overview_table:
-      return (
-        <OverviewTable
-          dynamic_content={dynamic_content}
-          firstItem={firstItem}
-        />
-      )
+      return <OverviewTable dynamic_content={dynamic_content} />
     case DynamicContentEnum.Blocks.components.points_overview:
       return <PointsOverview {...dynamic_content} />
     case DynamicContentEnum.Blocks.components.previous_stays: