scandic/web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: SW-1010 Optimized code

Browse Source
This commit is contained in:
Hrishikesh Vaipurkar
2024-11-27 11:51:48 +01:00
parent e4c58d2b30
commit 65f3ac7325
3 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
components/TempDesignSystem/Popover/index.tsx
View File

@@ -17,10 +17,9 @@ import styles from "./popover.module.css"
export default function Popover({ export default function Popover({
triggerContent, triggerContent,
children, children,
isNestedPopover = false,
...props ...props
}: PopoverProps) { }: PopoverProps) {
const setOverflowVisible = useSetOverFlowVisibleOnRA(isNestedPopover) const setOverflowVisible = useSetOverFlowVisibleOnRA()
return ( return (
<DialogTrigger onOpenChange={setOverflowVisible}> <DialogTrigger onOpenChange={setOverflowVisible}>

1
components/TempDesignSystem/Popover/popover.ts
View File

@@ -3,5 +3,4 @@ import type { PopoverProps as RAPopoverProps } from "react-aria-components"
export interface PopoverProps extends Omit<RAPopoverProps, "children"> { export interface PopoverProps extends Omit<RAPopoverProps, "children"> {
triggerContent: React.ReactNode triggerContent: React.ReactNode
children: React.ReactNode children: React.ReactNode
isNestedPopover?: boolean
} }

2
hooks/useSetOverflowVisibleOnRA.ts
View File

@@ -1,4 +1,4 @@
export default function useSetOverflowVisibleOnRA(isNestedInModal: boolean) { export default function useSetOverflowVisibleOnRA(isNestedInModal?: boolean) {
function setOverflowVisible(isOpen: boolean) { function setOverflowVisible(isOpen: boolean) {
if (isOpen) { if (isOpen) {
document.body.style.overflow = "visible" document.body.style.overflow = "visible"