Merged in chore/update-eslint-configs (pull request #2812)

chore: Extend eslint configs from @typescript-eslint/recommended

* Change to typescript recommended in scandic-web

* Remove comment

* Change to recommended ts config in partner-sas

* Change to recommended ts lint config in booking-flow


Approved-by: Linus Flood

packages/booking-flow/lib/components/BookingConfirmation/Header/Actions/ManageBooking.tsx

@@ -13,7 +13,7 @@ import type { BookingConfirmation } from "@scandic-hotels/trpc/types/bookingConf
 
 import type { AdditionalInfoCookieValue } from "../../../../types/components/findMyBooking/additionalInfoCookieValue"
 
-interface ManageBookingProps extends Pick<BookingConfirmation, "booking"> {}
+type ManageBookingProps = Pick<BookingConfirmation, "booking">
 
 export default function ManageBooking({ booking }: ManageBookingProps) {
   const intl = useIntl()

packages/booking-flow/lib/components/BookingConfirmation/Promos/index.tsx

@@ -13,7 +13,7 @@ import type { BookingConfirmation } from "@scandic-hotels/trpc/types/bookingConf
 
 import type { AdditionalInfoCookieValue } from "../../../types/components/findMyBooking/additionalInfoCookieValue"
 
-export interface PromosProps extends Pick<BookingConfirmation, "booking"> {}
+export type PromosProps = Pick<BookingConfirmation, "booking">
 
 export function Promos({ booking }: PromosProps) {
   const intl = useIntl()

packages/booking-flow/lib/components/BookingWidget/Client.tsx

@@ -90,7 +90,7 @@ export default function BookingWidgetClient({
     toDate = now.add(1, "day")
   }
 
-  let selectedLocation =
+  const selectedLocation =
     destinationsData?.currentSelection.hotel ??
     destinationsData?.currentSelection.city
 
@@ -199,8 +199,9 @@ export default function BookingWidgetClient({
           ? JSON.parse(storedBookingCode)
           : undefined
 
-      initialBookingCode?.remember &&
+      if (initialBookingCode?.remember) {
         methods.setValue("bookingCode", initialBookingCode)
+      }
     }
   }, [methods, selectedBookingCode])
 

packages/booking-flow/lib/components/BookingWidget/GuestsRoomsPicker/ChildSelector/ChildInfoSelector.tsx

@@ -84,7 +84,7 @@ export default function ChildInfoSelector({
   ]
 
   function getAvailableBeds(age: number) {
-    let availableBedTypes: ChildBed[] = []
+    const availableBedTypes: ChildBed[] = []
     if (age <= 5 && (adults > childrenInAdultsBed || child.bed === 0)) {
       availableBedTypes.push(allBedTypes[0])
     }

packages/booking-flow/lib/components/BookingWidget/GuestsRoomsPicker/index.tsx

@@ -63,7 +63,7 @@ export default function GuestsRoomsPickerForm({
   const updateHeight = useCallback(() => {
     // Get available space for picker to show without going beyond screen
     const bookingWidget = document.getElementById("booking-widget")
-    let maxHeight =
+    const maxHeight =
       window.innerHeight -
       (bookingWidget?.getBoundingClientRect().bottom ?? 0) -
       50

packages/booking-flow/lib/components/EnterDetails/Payment/schema.ts

@@ -13,4 +13,4 @@ export const paymentSchema = z.object({
   guarantee: z.boolean(),
 })
 
-export interface PaymentFormData extends z.output<typeof paymentSchema> {}
+export type PaymentFormData = z.output<typeof paymentSchema>

packages/booking-flow/lib/components/EnterDetails/Summary/Mobile/BottomSheet/index.tsx

@@ -17,10 +17,9 @@ import { formId } from "../../../Payment/PaymentClient"
 
 import styles from "./bottomSheet.module.css"
 
-interface SummaryBottomSheetProps
-  extends PropsWithChildren<{
-    isUserLoggedIn: boolean
-  }> {}
+type SummaryBottomSheetProps = PropsWithChildren<{
+  isUserLoggedIn: boolean
+}>
 
 export default function SummaryBottomSheet({
   children,

packages/booking-flow/lib/components/SelectHotel/index.tsx

@@ -46,6 +46,7 @@ export async function SelectHotel({
   const isAllUnavailable = hotels.every(
     (hotel) => hotel.availability.status !== "Available"
   )
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const isCityWithCountry = (city: any): city is { country: string } =>
     "country" in city
 

packages/booking-flow/lib/components/SelectRate/RoomsContainer/RateSummary/DesktopSummary.tsx

@@ -84,7 +84,7 @@ export function DesktopSummary({
     isUserLoggedIn || selectedRates.rates.some(isBookingCodeRate)
 
   const mainRoomRate = selectedRates.rates.at(0)
-  let mainRoomCurrency = getRoomCurrency(mainRoomRate)
+  const mainRoomCurrency = getRoomCurrency(mainRoomRate)
 
   return (
     <>

packages/booking-flow/lib/components/SelectRate/RoomsContainer/Rooms/RoomsList/RoomListItem/Rates/Code.tsx

@@ -159,6 +159,7 @@ function CorporateChequeCode({
   handleSelectRate,
   isSelected,
 }: {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   codeProduct: Extract<CodeProduct, { corporateCheque: any }>
   roomIndex: number
   roomTypeCode: string
@@ -329,6 +330,7 @@ function VoucherCode({
   handleSelectRate,
   isSelected,
 }: {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   codeProduct: Extract<CodeProduct, { voucher: any }>
   roomIndex: number
   roomTypeCode: string