Merged in chore/update-eslint-configs (pull request #2812)

chore: Extend eslint configs from @typescript-eslint/recommended

* Change to typescript recommended in scandic-web

* Remove comment

* Change to recommended ts config in partner-sas

* Change to recommended ts lint config in booking-flow


Approved-by: Linus Flood

apps/scandic-web/components/Blocks/DynamicContent/OverviewTable/reducer.ts

@@ -63,7 +63,11 @@ export function getInitialState({
   }
 }
 
-export function reducer(state: any, action: OverviewTableReducerAction) {
+export function reducer(
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  state: any,
+  action: OverviewTableReducerAction
+) {
   switch (action.type) {
     case OverviewTableActionsEnum.SET_SELECTED_LEVEL_A_MOBILE:
       return {

apps/scandic-web/components/Blocks/Table/index.tsx

@@ -28,6 +28,7 @@ export default function TableBlock({ data }: TableBlockProps) {
     accessorKey: col.id,
     header: col.header,
     size: col.width,
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     cell: (info: any) => (
       <div dangerouslySetInnerHTML={{ __html: info.getValue() }} />
     ),

apps/scandic-web/components/ContentType/HotelPage/DialogshiftWidget/Client.tsx

@@ -17,6 +17,7 @@ export default function DialogshiftWidgetClient({
   widgetId,
   language,
 }: DialogshiftWidgetClientProps) {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const dialogshiftRef = useRef<any>(null)
 
   useEffect(() => {

apps/scandic-web/components/DeprecatedJsonToHtml/renderOptions.tsx

@@ -42,6 +42,7 @@ import type { RenderOptions } from "@/types/rte/option"
 
 function extractPossibleAttributes(attrs: Attributes | undefined) {
   if (!attrs) return {}
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const props: Record<string, any> = {}
   if (attrs.id) {
     props.id = attrs.id
@@ -601,7 +602,7 @@ export const renderOptions: RenderOptions = {
     className?: string,
     id?: string
   ) => {
-    let props = {
+    const props = {
       className,
       id,
     }
@@ -614,9 +615,6 @@ export const renderOptions: RenderOptions = {
 
     if (className) {
       if (hasAvailableULFormat(className)) {
-        // @ts-ignore:  We want to set css modules classNames even if it does not correspond
-        // to an existing class in the module style sheet. Due to our css modules plugin for
-        // typescript, we cannot do this without the ts-ignore
         props.className = styles[className]
       }
     }

apps/scandic-web/components/DeprecatedJsonToHtml/utils.tsx

@@ -36,6 +36,7 @@ export function nodeChildrenToHtml(
   nodes: RTENode[],
   embeds: EmbedByUid,
   fullRenderOptions: RenderOptions
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
 ): any {
   return nodes
     .map((node, i) => {

apps/scandic-web/components/Forms/Edit/Profile/index.tsx

@@ -176,10 +176,7 @@ export default function Form({ user }: EditFormProps) {
           </Button>
         </div>
         <form
-          /**
-           * Ignoring since ts doesn't recognize that tRPC
-           * parses FormData before reaching the route
-           * @ts-ignore */
+          /* @ts-expect-error Ignoring since ts doesn't recognize that tRPC parses FormData before reaching the route */
           action={editProfile}
           className={styles.form}
           id={formId}

apps/scandic-web/components/HotelReservation/MyStay/Ancillaries/AddAncillaryFlow/AddAncillaryFlowModal/index.tsx

@@ -204,6 +204,7 @@ export default function AddAncillaryFlowModal({
     )
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   function handleGuaranteePayment(data: AncillaryFormData, packages: any) {
     const savedCreditCard = savedCreditCards?.find(
       (card) => card.id === data.paymentMethod

apps/scandic-web/components/HotelReservation/MyStay/ReferenceCard/Actions/NotCancelled/ManageStay/Actions/GuaranteeLateArrival/Form/schema.ts

@@ -7,4 +7,4 @@ export const paymentSchema = z.object({
   }),
 })
 
-export interface GuaranteeFormData extends z.output<typeof paymentSchema> {}
+export type GuaranteeFormData = z.output<typeof paymentSchema>

apps/scandic-web/components/HotelReservation/MyStay/TrackGuarantee.tsx

@@ -95,6 +95,7 @@ export default function TrackGuarantee({
         break
 
       case PaymentCallbackStatusEnum.Cancel:
+        // eslint-disable-next-line @typescript-eslint/no-unused-expressions
         isAncillaryFlow
           ? trackAncillaryPaymentEvent(
               "GuaranteeCancelAncillary",
@@ -107,6 +108,7 @@ export default function TrackGuarantee({
         break
 
       case PaymentCallbackStatusEnum.Error:
+        // eslint-disable-next-line @typescript-eslint/no-unused-expressions
         isAncillaryFlow
           ? trackAncillaryPaymentEvent(
               "GuaranteeFailAncillary",

apps/scandic-web/components/TempDesignSystem/Form/Input/index.tsx

@@ -36,7 +36,7 @@ const Input = forwardRef<HTMLInputElement, InputProps>(function Input(
 ) {
   const intl = useIntl()
   const { control } = useFormContext()
-  let numberAttributes: HTMLAttributes<HTMLInputElement> = {}
+  const numberAttributes: HTMLAttributes<HTMLInputElement> = {}
   if (type === "number") {
     numberAttributes.onWheel = function (evt: WheelEvent<HTMLInputElement>) {
       evt.currentTarget.blur()

apps/scandic-web/components/TempDesignSystem/Form/Select/select.ts

@@ -15,6 +15,7 @@ interface ReactAriaSelectProps
   showRadioButton?: boolean
   discreet?: boolean
   isNestedInModal?: boolean
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   optionsIcon?: ReactElement<any>
 }