From 5477343373cd1050fcebd24390a61d9ee8a5d0b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20J=C3=A4derberg?= Date: Tue, 25 Nov 2025 10:24:33 +0000 Subject: [PATCH] Merged in fix/dont-remove-items-when-unable-to-parse (pull request #3217) fix: dont remove cache entries when unable to parse api response * fix: dont remove cache entries when unable to parse api response Approved-by: Linus Flood --- .../common/dataCache/DistributedCache/get.ts | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/packages/common/dataCache/DistributedCache/get.ts b/packages/common/dataCache/DistributedCache/get.ts index f1f65a8b6..cedf7ccb1 100644 --- a/packages/common/dataCache/DistributedCache/get.ts +++ b/packages/common/dataCache/DistributedCache/get.ts @@ -3,7 +3,6 @@ import * as Sentry from "@sentry/nextjs" import { env } from "../../env/server" import { safeTry } from "../../utils/safeTry" import { cacheLogger } from "../logger" -import { deleteKey } from "./deleteKey" import { getCacheEndpoint } from "./endpoints" const API_KEY = env.REDIS_API_KEY ?? "" @@ -32,7 +31,7 @@ export async function get(key: string) { return undefined } - cacheLogger.error(`Failed to get cache for key ${key}`, { + cacheLogger.error(`Failed to get cache for key '${key}'`, { cacheKey: key, statusCode: response?.status, statusText: response?.statusText, @@ -55,12 +54,22 @@ export async function get(key: string) { ) if (jsonError) { - cacheLogger.error("Failed to parse cache response", { + cacheLogger.error(`Failed to parse cache response for key '${key}'`, { cacheKey: key, error: serializeError(jsonError), }) + Sentry.captureException( + jsonError ?? new Error("Unable to parse cache response"), + { + extra: { + cacheKey: key, + statusCode: response?.status, + statusText: response?.statusText, + contentType: response?.headers.get("content-type"), + }, + } + ) - await deleteKey(key) return undefined }