feat: harmonize log and metrics

apps/scandic-web/server/routers/user/mutation.ts

@@ -1,5 +1,3 @@
-import { metrics } from "@opentelemetry/api"
-
 import { signupVerify } from "@/constants/routes/signup"
 import { env } from "@/env/server"
 import * as api from "@/lib/api"
@@ -8,6 +6,7 @@ import {
   initiateSaveCardSchema,
   subscriberIdSchema,
 } from "@/server/routers/user/output"
+import { createCounter } from "@/server/telemetry"
 import { protectedProcedure, router, serviceProcedure } from "@/server/trpc"
 
 import {
@@ -17,20 +16,6 @@ import {
   signupInput,
 } from "./input"
 
-const meter = metrics.getMeter("trpc.user")
-const generatePreferencesLinkCounter = meter.createCounter(
-  "trpc.user.generatePreferencesLink"
-)
-const generatePreferencesLinkSuccessCounter = meter.createCounter(
-  "trpc.user.generatePreferencesLink-success"
-)
-const generatePreferencesLinkFailCounter = meter.createCounter(
-  "trpc.user.generatePreferencesLink-fail"
-)
-const signupCounter = meter.createCounter("trpc.user.signup")
-const signupSuccessCounter = meter.createCounter("trpc.user.signup-success")
-const signupFailCounter = meter.createCounter("trpc.user.signup-fail")
-
 export const userMutationRouter = router({
   creditCard: router({
     add: protectedProcedure.input(addCreditCardInput).mutation(async function ({
@@ -159,7 +144,15 @@ export const userMutationRouter = router({
   generatePreferencesLink: protectedProcedure.mutation(async function ({
     ctx,
   }) {
-    generatePreferencesLinkCounter.add(1)
+    const generatePreferencesLinkCounter = createCounter(
+      "trpc.user",
+      "generatePreferencesLink"
+    )
+
+    const metricsGeneratePreferencesLink = generatePreferencesLinkCounter.init()
+
+    metricsGeneratePreferencesLink.start()
+
     const apiResponse = await api.get(api.endpoints.v1.Profile.subscriberId, {
       headers: {
         Authorization: `Bearer ${ctx.session.token.access_token}`,
@@ -167,25 +160,7 @@ export const userMutationRouter = router({
     })
 
     if (!apiResponse.ok) {
-      const text = await apiResponse.text()
-      generatePreferencesLinkFailCounter.add(1, {
-        error_type: "http_error",
-        error: JSON.stringify({
-          status: apiResponse.status,
-          statusText: apiResponse.statusText,
-          text,
-        }),
-      })
-      console.error(
-        "api.user.subscriberId error ",
-        JSON.stringify({
-          error: {
-            status: apiResponse.status,
-            statusText: apiResponse.statusText,
-            text,
-          },
-        })
-      )
+      await metricsGeneratePreferencesLink.httpError(apiResponse)
       return null
     }
 
@@ -194,31 +169,23 @@ export const userMutationRouter = router({
     const validatedData = subscriberIdSchema.safeParse(data)
 
     if (!validatedData.success) {
-      generatePreferencesLinkSuccessCounter.add(1, {
-        error_type: "validation_error",
-        error: JSON.stringify(validatedData.error),
-      })
-      console.error(
-        "api.user.generatePreferencesLink validation error",
-        JSON.stringify({
-          error: validatedData.error,
-        })
-      )
-      console.error(validatedData.error.format())
-
+      metricsGeneratePreferencesLink.validationError(validatedData.error)
       return null
     }
+
     const preferencesLink = new URL(env.SALESFORCE_PREFERENCE_BASE_URL)
     preferencesLink.searchParams.set("subKey", validatedData.data.subscriberId)
 
-    generatePreferencesLinkSuccessCounter.add(1)
+    metricsGeneratePreferencesLink.success()
+
     return preferencesLink.toString()
   }),
   signup: serviceProcedure.input(signupInput).mutation(async function ({
     ctx,
     input,
   }) {
-    signupCounter.add(1)
+    const signupCounter = createCounter("trpc.user", "signup")
+    const metricsSignup = signupCounter.init()
 
     const apiResponse = await api.post(api.endpoints.v1.Profile.profile, {
       body: input,
@@ -228,29 +195,13 @@ export const userMutationRouter = router({
     })
 
     if (!apiResponse.ok) {
+      await metricsSignup.httpError(apiResponse)
       const text = await apiResponse.text()
-      signupFailCounter.add(1, {
-        error_type: "http_error",
-        error: JSON.stringify({
-          status: apiResponse.status,
-          statusText: apiResponse.statusText,
-          error: text,
-        }),
-      })
-      console.error(
-        "api.user.signup api error",
-        JSON.stringify({
-          error: {
-            status: apiResponse.status,
-            statusText: apiResponse.statusText,
-            error: text,
-          },
-        })
-      )
       throw serverErrorByStatus(apiResponse.status, text)
     }
-    signupSuccessCounter.add(1)
-    console.info("api.user.signup success")
+
+    metricsSignup.success()
+
     return {
       success: true,
       redirectUrl: signupVerify[input.language],