feat: harmonize log and metrics

apps/scandic-web/server/routers/contentstack/loyaltyLevel/query.ts

@@ -1,4 +1,3 @@
-import { metrics } from "@opentelemetry/api"
 import { cache } from "react"
 
 import {
@@ -11,6 +10,7 @@ import {
 } from "@/lib/graphql/Query/LoyaltyLevels.graphql"
 import { request } from "@/lib/graphql/request"
 import { notFound } from "@/server/errors/trpc"
+import { createCounter } from "@/server/telemetry"
 import { contentstackBaseProcedure, router } from "@/server/trpc"
 
 import { generateLoyaltyConfigTag } from "@/utils/generateTag"
@@ -24,32 +24,14 @@ import {
 
 import type { Context } from "@/server/context"
 
-const meter = metrics.getMeter("trpc.loyaltyLevel")
-// OpenTelemetry metrics: Loyalty Level
-const getAllLoyaltyLevelCounter = meter.createCounter(
-  "trpc.contentstack.loyaltyLevel.all"
-)
-
-const getAllLoyaltyLevelSuccessCounter = meter.createCounter(
-  "trpc.contentstack.loyaltyLevel.all-success"
-)
-const getAllLoyaltyLevelFailCounter = meter.createCounter(
-  "trpc.contentstack.loyaltyLevel.all-fail"
-)
-
-const getByLevelLoyaltyLevelCounter = meter.createCounter(
-  "trpc.contentstack.loyaltyLevel.byLevel"
-)
-
-const getByLevelLoyaltyLevelSuccessCounter = meter.createCounter(
-  "trpc.contentstack.loyaltyLevel.byLevel-success"
-)
-const getByLevelLoyaltyLevelFailCounter = meter.createCounter(
-  "trpc.contentstack.loyaltyLevel.byLevel-fail"
-)
-
 export const getAllLoyaltyLevels = cache(async (ctx: Context) => {
-  getAllLoyaltyLevelCounter.add(1)
+  const getLoyaltyLevelAllCounter = createCounter(
+    "trpc.contentstack",
+    "loyaltyLevel.all"
+  )
+  const metricsGetLoyaltyLevelAll = getLoyaltyLevelAllCounter.init()
+
+  metricsGetLoyaltyLevelAll.start()
 
   // Ideally we should fetch all available tiers from API, but since they
   // are static, we can just use the enum values. We want to know which
@@ -67,17 +49,8 @@ export const getAllLoyaltyLevels = cache(async (ctx: Context) => {
   )
 
   if (!loyaltyLevelsConfigResponse.data) {
-    getAllLoyaltyLevelFailCounter.add(1)
     const notFoundError = notFound(loyaltyLevelsConfigResponse)
-    console.error(
-      "contentstack.loyaltyLevels not found error",
-      JSON.stringify({
-        query: {
-          lang: ctx.lang,
-        },
-        error: { code: notFoundError.code },
-      })
-    )
+    metricsGetLoyaltyLevelAll.noDataError()
     throw notFoundError
   }
 
@@ -85,30 +58,28 @@ export const getAllLoyaltyLevels = cache(async (ctx: Context) => {
     loyaltyLevelsConfigResponse.data
   )
   if (!validatedLoyaltyLevels.success) {
-    getAllLoyaltyLevelFailCounter.add(1)
-    console.error(validatedLoyaltyLevels.error)
-    console.error(
-      "contentstack.rewards validation error",
-      JSON.stringify({
-        query: {
-          lang: ctx.lang,
-        },
-        error: validatedLoyaltyLevels.error,
-      })
-    )
+    metricsGetLoyaltyLevelAll.validationError(validatedLoyaltyLevels.error)
     return []
   }
 
-  getAllLoyaltyLevelSuccessCounter.add(1)
+  metricsGetLoyaltyLevelAll.success()
+
   return validatedLoyaltyLevels.data
 })
 
 export const getLoyaltyLevel = cache(
   async (ctx: Context, level_id: MembershipLevel) => {
-    getByLevelLoyaltyLevelCounter.add(1, {
-      query: JSON.stringify({ lang: ctx.lang, level_id }),
+    const getLoyaltyLevelCounter = createCounter(
+      "trpc.contentstack",
+      "loyaltyLevel.get"
+    )
+    const metricsGetLoyaltyLevel = getLoyaltyLevelCounter.init({
+      lang: ctx.lang,
+      level_id,
     })
 
+    metricsGetLoyaltyLevel.start()
+
     const loyaltyLevelsConfigResponse = await request<LoyaltyLevelsResponse>(
       GetLoyaltyLevel,
       { lang: ctx.lang, level_id },
@@ -121,15 +92,8 @@ export const getLoyaltyLevel = cache(
       !loyaltyLevelsConfigResponse.data ||
       !loyaltyLevelsConfigResponse.data.all_loyalty_level.items.length
     ) {
-      getByLevelLoyaltyLevelFailCounter.add(1)
       const notFoundError = notFound(loyaltyLevelsConfigResponse)
-      console.error(
-        "contentstack.loyaltyLevel not found error",
-        JSON.stringify({
-          query: { lang: ctx.lang, level_id },
-          error: { code: notFoundError.code },
-        })
-      )
+      metricsGetLoyaltyLevel.noDataError()
       throw notFoundError
     }
 
@@ -137,19 +101,12 @@ export const getLoyaltyLevel = cache(
       loyaltyLevelsConfigResponse.data
     )
     if (!validatedLoyaltyLevels.success) {
-      getByLevelLoyaltyLevelFailCounter.add(1)
-      console.error(validatedLoyaltyLevels.error)
-      console.error(
-        "contentstack.loyaltyLevel validation error",
-        JSON.stringify({
-          query: { lang: ctx.lang, level_id },
-          error: validatedLoyaltyLevels.error,
-        })
-      )
+      metricsGetLoyaltyLevel.validationError(validatedLoyaltyLevels.error)
       return null
     }
 
-    getByLevelLoyaltyLevelSuccessCounter.add(1)
+    metricsGetLoyaltyLevel.success()
+
     const result: LoyaltyLevel = validatedLoyaltyLevels.data[0]
     return result
   }