feat: harmonize log and metrics

apps/scandic-web/server/routers/contentstack/breadcrumbs/query.ts

@@ -1,4 +1,3 @@
-import { metrics } from "@opentelemetry/api"
 import { cache } from "react"
 
 import {
@@ -35,6 +34,7 @@ import {
 } from "@/lib/graphql/Query/Breadcrumbs/LoyaltyPage.graphql"
 import { request } from "@/lib/graphql/request"
 import { notFound } from "@/server/errors/trpc"
+import { createCounter } from "@/server/telemetry"
 import { contentstackExtendedProcedureUID, router } from "@/server/trpc"
 
 import { generateRefsResponseTag } from "@/utils/generateTag"
@@ -49,28 +49,6 @@ import type {
 } from "@/types/trpc/routers/contentstack/breadcrumbs"
 import type { Lang } from "@/constants/languages"
 
-const meter = metrics.getMeter("trpc.breadcrumbs")
-
-// OpenTelemetry metrics
-const getBreadcrumbsRefsCounter = meter.createCounter(
-  "trpc.contentstack.breadcrumbs.refs.get"
-)
-const getBreadcrumbsRefsSuccessCounter = meter.createCounter(
-  "trpc.contentstack.breadcrumbs.refs.get-success"
-)
-const getBreadcrumbsRefsFailCounter = meter.createCounter(
-  "trpc.contentstack.breadcrumbs.refs.get-fail"
-)
-const getBreadcrumbsCounter = meter.createCounter(
-  "trpc.contentstack.breadcrumbs.get"
-)
-const getBreadcrumbsSuccessCounter = meter.createCounter(
-  "trpc.contentstack.breadcrumbs.get-success"
-)
-const getBreadcrumbsFailCounter = meter.createCounter(
-  "trpc.contentstack.breadcrumbs.get-fail"
-)
-
 interface BreadcrumbsPageData<T> {
   dataKey: keyof T
   refQuery: string
@@ -81,11 +59,17 @@ const getBreadcrumbs = cache(async function fetchMemoizedBreadcrumbs<T>(
   { dataKey, refQuery, query }: BreadcrumbsPageData<T>,
   { uid, lang }: { uid: string; lang: Lang }
 ) {
-  getBreadcrumbsRefsCounter.add(1, { lang, uid })
-  console.info(
-    "contentstack.breadcrumbs refs get start",
-    JSON.stringify({ query: { lang, uid } })
+  const getBreadcrumbsRefsCounter = createCounter(
+    "trpc.contentstack",
+    "breadcrumbs.get.refs"
   )
+  const metricsGetBreadcrumbsRefs = getBreadcrumbsRefsCounter.init({
+    lang,
+    uid,
+  })
+
+  metricsGetBreadcrumbsRefs.start()
+
   const refsResponse = await request<{ [K in keyof T]: BreadcrumbsRefsSchema }>(
     refQuery,
     { locale: lang, uid },
@@ -100,32 +84,25 @@ const getBreadcrumbs = cache(async function fetchMemoizedBreadcrumbs<T>(
   )
 
   if (!validatedRefsData.success) {
-    getBreadcrumbsRefsFailCounter.add(1, {
-      error_type: "validation_error",
-      error: JSON.stringify(validatedRefsData.error),
-    })
-    console.error(
-      "contentstack.breadcrumbs refs validation error",
-      JSON.stringify({
-        error: validatedRefsData.error,
-      })
-    )
+    metricsGetBreadcrumbsRefs.validationError(validatedRefsData.error)
     return []
   }
 
-  getBreadcrumbsRefsSuccessCounter.add(1, { lang, uid })
-  console.info(
-    "contentstack.breadcrumbs refs get success",
-    JSON.stringify({ query: { lang, uid } })
-  )
+  metricsGetBreadcrumbsRefs.success()
 
   const tags = getTags(validatedRefsData.data, lang)
 
-  getBreadcrumbsCounter.add(1, { lang, uid })
-  console.info(
-    "contentstack.breadcrumbs get start",
-    JSON.stringify({ query: { lang, uid } })
+  const getBreadcrumbsCounter = createCounter(
+    "trpc.contentstack",
+    "breadcrumbs.get"
   )
+  const metricsGetBreadcrumbs = getBreadcrumbsCounter.init({
+    lang,
+    uid,
+  })
+
+  metricsGetBreadcrumbs.start()
+
   const response = await request<T>(
     query,
     { locale: lang, uid },
@@ -137,19 +114,7 @@ const getBreadcrumbs = cache(async function fetchMemoizedBreadcrumbs<T>(
 
   if (!response.data) {
     const notFoundError = notFound(response)
-    getBreadcrumbsFailCounter.add(1, {
-      lang,
-      uid,
-      error_type: "not_found",
-      error: JSON.stringify({ code: notFoundError.code }),
-    })
-    console.error(
-      "contentstack.breadcrumbs get not found error",
-      JSON.stringify({
-        query: { lang, uid },
-        error: { code: notFoundError.code },
-      })
-    )
+    metricsGetBreadcrumbs.noDataError()
     throw notFoundError
   }
 
@@ -158,24 +123,11 @@ const getBreadcrumbs = cache(async function fetchMemoizedBreadcrumbs<T>(
   )
 
   if (!validatedBreadcrumbs.success) {
-    getBreadcrumbsFailCounter.add(1, {
-      error_type: "validation_error",
-      error: JSON.stringify(validatedBreadcrumbs.error),
-    })
-    console.error(
-      "contentstack.breadcrumbs validation error",
-      JSON.stringify({
-        error: validatedBreadcrumbs.error,
-      })
-    )
+    metricsGetBreadcrumbs.validationError(validatedBreadcrumbs.error)
     return []
   }
 
-  getBreadcrumbsSuccessCounter.add(1, { lang, uid })
-  console.info(
-    "contentstack.breadcrumbs get success",
-    JSON.stringify({ query: { lang, uid } })
-  )
+  metricsGetBreadcrumbs.success()
 
   return validatedBreadcrumbs.data
 })