feat(SW-706): make eslint rule 'formatjs/no-literal-string-in-jsx' pass

2025-02-07 06:51:36 +01:00
parent e22fc1f3c8
commit 440e1f92df
393 changed files with 4839 additions and 1554 deletions
--- a/apps/scandic-web/components/Blocks/DynamicContent/Points/EarnAndBurn/AwardPoints/index.tsx
+++ b/apps/scandic-web/components/Blocks/DynamicContent/Points/EarnAndBurn/AwardPoints/index.tsx
@@ -34,7 +34,9 @@ export default function AwardPoints({
    <Body textTransform="bold" className={classNames}>
      {isCalculated
        ? intl.formatNumber(awardPoints)
-        : intl.formatMessage({ id: "Points being calculated" })}
+        : intl.formatMessage({
+            defaultMessage: "Points being calculated",
+          })}
    </Body>
  )
 }
--- a/apps/scandic-web/components/Blocks/DynamicContent/Points/EarnAndBurn/JourneyTable/ClientTable/Row/index.tsx
+++ b/apps/scandic-web/components/Blocks/DynamicContent/Points/EarnAndBurn/JourneyTable/ClientTable/Row/index.tsx
@@ -24,7 +24,7 @@ export default function Row({ transaction }: RowProps) {

  const nightsMsg = intl.formatMessage(
    {
-      id: "{totalNights, plural, one {# night} other {# nights}}",
+      defaultMessage: "{totalNights, plural, one {# night} other {# nights}}",
    },
    {
      totalNights: transaction.nights,
@@ -40,28 +40,40 @@ export default function Row({ transaction }: RowProps) {
    case Transactions.rewardType.stay:
    case Transactions.rewardType.stayAdj:
      if (transaction.hotelId === "ORS") {
-        description = intl.formatMessage({ id: "Former Scandic Hotel" })
+        description = intl.formatMessage({
+          defaultMessage: "Former Scandic Hotel",
+        })
      }
      if (transaction.confirmationNumber === "BALFWD") {
        description = intl.formatMessage({
-          id: "Points earned prior to May 1, 2021",
+          defaultMessage: "Points earned prior to May 1, 2021",
        })
      }
      break
    case Transactions.rewardType.ancillary:
-      description = intl.formatMessage({ id: "Extras to your booking" })
+      description = intl.formatMessage({
+        defaultMessage: "Extras to your booking",
+      })
      break
    case Transactions.rewardType.enrollment:
-      description = intl.formatMessage({ id: "Sign up bonus" })
+      description = intl.formatMessage({
+        defaultMessage: "Sign up bonus",
+      })
      break
    case Transactions.rewardType.mastercard_points:
-      description = intl.formatMessage({ id: "Scandic Friends Mastercard" })
+      description = intl.formatMessage({
+        defaultMessage: "Scandic Friends Mastercard",
+      })
      break
    case Transactions.rewardType.tui_points:
-      description = intl.formatMessage({ id: "TUI Points" })
+      description = intl.formatMessage({
+        defaultMessage: "TUI Points",
+      })

    case Transactions.rewardType.pointShop:
-      description = intl.formatMessage({ id: "Scandic Friends Point Shop" })
+      description = intl.formatMessage({
+        defaultMessage: "Scandic Friends Point Shop",
+      })
      break
  }

--- a/apps/scandic-web/components/Blocks/DynamicContent/Points/EarnAndBurn/JourneyTable/ClientTable/index.tsx
+++ b/apps/scandic-web/components/Blocks/DynamicContent/Points/EarnAndBurn/JourneyTable/ClientTable/index.tsx
@@ -15,10 +15,18 @@ export default function ClientTable({ transactions }: ClientTableProps) {
  const intl = useIntl()

  const tableHeadings = [
-    intl.formatMessage({ id: "Points" }),
-    intl.formatMessage({ id: "Description" }),
-    intl.formatMessage({ id: "Booking number" }),
-    intl.formatMessage({ id: "Arrival date" }),
+    intl.formatMessage({
+      defaultMessage: "Points",
+    }),
+    intl.formatMessage({
+      defaultMessage: "Description",
+    }),
+    intl.formatMessage({
+      defaultMessage: "Booking number",
+    }),
+    intl.formatMessage({
+      defaultMessage: "Arrival date",
+    }),
  ]

  return (
@@ -44,7 +52,9 @@ export default function ClientTable({ transactions }: ClientTableProps) {
          ) : (
            <Table.TR className={styles.placeholder}>
              <Table.TD colSpan={tableHeadings.length}>
-                {intl.formatMessage({ id: "No transactions available" })}
+                {intl.formatMessage({
+                  defaultMessage: "No transactions available",
+                })}
              </Table.TD>
            </Table.TR>
          )}
--- a/apps/scandic-web/components/Blocks/DynamicContent/Points/ExpiringPoints/ExpiringPointsTable/index.tsx
+++ b/apps/scandic-web/components/Blocks/DynamicContent/Points/ExpiringPoints/ExpiringPointsTable/index.tsx
@@ -22,8 +22,12 @@ export default function ExpiringPointsTable({
  const expiration = dt(expirationDate).locale(lang).format("DD MMM YYYY")

  const tableHeadings = [
-    intl.formatMessage({ id: "Points" }),
-    intl.formatMessage({ id: "Expiration Date" }),
+    intl.formatMessage({
+      defaultMessage: "Points",
+    }),
+    intl.formatMessage({
+      defaultMessage: "Expiration Date",
+    }),
  ]

  return (