Merged in fix/LOY-280-phone (pull request #2393)

fix(LOY-280): phone number validation

* fix(LOY-280): phone number validation

* Return formatted phonenumber even though its not valid


Approved-by: Christian Andolf

apps/scandic-web/components/Forms/Edit/Profile/index.tsx

@@ -60,7 +60,9 @@ export default function Form({ user }: EditFormProps) {
       email: user.email,
       language: user.language ?? langToApiLang[lang],
       phoneNumber: phoneNumber,
-      phoneNumberCC: phoneNumberCC || getDefaultCountryFromLang(lang),
+      phoneNumberCC: phoneNumber
+        ? phoneNumberCC
+        : getDefaultCountryFromLang(lang),
       password: "",
       newPassword: "",
       retypeNewPassword: "",

apps/scandic-web/utils/phone.ts

@@ -4,16 +4,23 @@ export function formatPhoneNumber(
   phoneNumber: string,
   phoneNumberCC?: string | null
 ): string {
+  if (!phoneNumber) return ""
+
+  const normalized = phoneNumber.trim().replaceAll(/-|\s/g, "")
+
   const parsedPhonenumber = phoneNumberCC?.length
     ? parsePhoneNumberFromString(
-        phoneNumber,
+        normalized,
         phoneNumberCC.toUpperCase() as CountryCode
       )
-    : parsePhoneNumberFromString(phoneNumber)
+    : parsePhoneNumberFromString(normalized)
 
-  if (parsedPhonenumber?.isValid()) {
+  if (!parsedPhonenumber?.isValid()) {
-    return parsedPhonenumber.number
+    console.warn(
+      `Invalid phone number: ${phoneNumber} with country code: ${phoneNumberCC}`,
+      parsedPhonenumber
+    )
   }
 
-  return phoneNumber
+  return parsedPhonenumber?.number || normalized
 }