From 3bd23bf56e64c691564de5cfa2cc0b9ea86e8134 Mon Sep 17 00:00:00 2001 From: Linus Flood Date: Fri, 5 Dec 2025 08:01:48 +0000 Subject: [PATCH] Merged in feat/book-595-gla-tracking-fix (pull request #3294) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit feat(BOOK-595): fixed correct tracking values and enter details pageview tracking * feat(BOOK-595): fixed correct tracking values and enter details pageview tracking * Fixed on SAS as well Approved-by: Joakim Jäderberg --- .../(payment-callback)/payment-callback/[status]/page.tsx | 4 ++-- apps/partner-sas/components/RouteChange.tsx | 4 ---- .../(payment-callback)/gla-payment-callback/page.tsx | 2 +- .../(payment-callback)/payment-callback/page.tsx | 4 ++-- .../(live)/(public)/hotelreservation/get-booking/page.tsx | 4 ++-- .../(views)/hotelreservation/gla-payment-callback/page.tsx | 4 ++-- apps/scandic-web/components/RouteChange.tsx | 4 ---- 7 files changed, 9 insertions(+), 17 deletions(-) diff --git a/apps/partner-sas/app/[lang]/hotelreservation/(payment-callback)/payment-callback/[status]/page.tsx b/apps/partner-sas/app/[lang]/hotelreservation/(payment-callback)/payment-callback/[status]/page.tsx index 59f618f5b..e6b78b4ee 100644 --- a/apps/partner-sas/app/[lang]/hotelreservation/(payment-callback)/payment-callback/[status]/page.tsx +++ b/apps/partner-sas/app/[lang]/hotelreservation/(payment-callback)/payment-callback/[status]/page.tsx @@ -32,9 +32,9 @@ export default async function PaymentCallbackPage( pageId: "payment-callback", domainLanguage: lang, channel: TrackingChannelEnum["hotelreservation"], - pageName: "payment-callback", + pageName: "hotelreservation|payment-callback", siteSections: "hotelreservation|payment-callback", - pageType: "hotelreservationspayment-callback", + pageType: "payment-callbackpage", siteVersion: "new-web", } diff --git a/apps/partner-sas/components/RouteChange.tsx b/apps/partner-sas/components/RouteChange.tsx index 41070e9a9..1c4363a3d 100644 --- a/apps/partner-sas/components/RouteChange.tsx +++ b/apps/partner-sas/components/RouteChange.tsx @@ -25,10 +25,6 @@ export default function RouteChange() { const { startRouterTransition } = useRouterTransitionStore() useEffect(() => { - if (pathName.includes("payment-callback")) { - return - } - updateRouteInfo(pathName, currentLang, searchParams) if (hasPathOrLangChanged()) { diff --git a/apps/scandic-web/app/[lang]/(live)/(public)/hotelreservation/(payment-callback)/gla-payment-callback/page.tsx b/apps/scandic-web/app/[lang]/(live)/(public)/hotelreservation/(payment-callback)/gla-payment-callback/page.tsx index 495d1f341..07364a43d 100644 --- a/apps/scandic-web/app/[lang]/(live)/(public)/hotelreservation/(payment-callback)/gla-payment-callback/page.tsx +++ b/apps/scandic-web/app/[lang]/(live)/(public)/hotelreservation/(payment-callback)/gla-payment-callback/page.tsx @@ -40,7 +40,7 @@ export default async function GuaranteePaymentCallbackPage( channel: TrackingChannelEnum["hotelreservation"], pageName: "gla-payment-callback", siteSections: "hotelreservation|gla-payment-callback", - pageType: "hotelreservationsgla-payment-callback", + pageType: "gla-payment-callbackpage", siteVersion: "new-web", } diff --git a/apps/scandic-web/app/[lang]/(live)/(public)/hotelreservation/(payment-callback)/payment-callback/page.tsx b/apps/scandic-web/app/[lang]/(live)/(public)/hotelreservation/(payment-callback)/payment-callback/page.tsx index a22d599ca..9f826fc9c 100644 --- a/apps/scandic-web/app/[lang]/(live)/(public)/hotelreservation/(payment-callback)/payment-callback/page.tsx +++ b/apps/scandic-web/app/[lang]/(live)/(public)/hotelreservation/(payment-callback)/payment-callback/page.tsx @@ -32,9 +32,9 @@ export default async function PaymentCallbackPage( pageId: "payment-callback", domainLanguage: lang, channel: TrackingChannelEnum["hotelreservation"], - pageName: "payment-callback", + pageName: "hotelreservation|payment-callback", siteSections: "hotelreservation|payment-callback", - pageType: "hotelreservationspayment-callback", + pageType: "payment-callbackpage", siteVersion: "new-web", } diff --git a/apps/scandic-web/app/[lang]/(live)/(public)/hotelreservation/get-booking/page.tsx b/apps/scandic-web/app/[lang]/(live)/(public)/hotelreservation/get-booking/page.tsx index 75b454e1b..52b1e5823 100644 --- a/apps/scandic-web/app/[lang]/(live)/(public)/hotelreservation/get-booking/page.tsx +++ b/apps/scandic-web/app/[lang]/(live)/(public)/hotelreservation/get-booking/page.tsx @@ -26,9 +26,9 @@ export default async function GetBookingPage( pageId: "get-booking", domainLanguage: lang, channel: TrackingChannelEnum["hotelreservation"], - pageName: "get-booking", + pageName: "hotelreservation|get-booking", siteSections: "hotelreservation|get-booking", - pageType: "hotelreservationsget-booking", + pageType: "getbookingpage", siteVersion: "new-web", } diff --git a/apps/scandic-web/app/[lang]/webview/(views)/hotelreservation/gla-payment-callback/page.tsx b/apps/scandic-web/app/[lang]/webview/(views)/hotelreservation/gla-payment-callback/page.tsx index 3ee4c1698..01df797ea 100644 --- a/apps/scandic-web/app/[lang]/webview/(views)/hotelreservation/gla-payment-callback/page.tsx +++ b/apps/scandic-web/app/[lang]/webview/(views)/hotelreservation/gla-payment-callback/page.tsx @@ -37,9 +37,9 @@ export default async function GuaranteePaymentWebViewCallbackPage( pageId: "webview|gla-payment-callback", domainLanguage: lang, channel: TrackingChannelEnum["hotelreservation"], - pageName: "webview|gla-payment-callback", + pageName: "webview|hotelreservation|gla-payment-callback", siteSections: "webview|hotelreservation|gla-payment-callback", - pageType: "hotelreservationsgla-payment-callback", + pageType: "gla-payment-callbackpage", siteVersion: "new-web", } diff --git a/apps/scandic-web/components/RouteChange.tsx b/apps/scandic-web/components/RouteChange.tsx index 0cbb3bc35..cc40d29c4 100644 --- a/apps/scandic-web/components/RouteChange.tsx +++ b/apps/scandic-web/components/RouteChange.tsx @@ -26,10 +26,6 @@ export default function RouteChange() { const { startRouterTransition } = useRouterTransitionStore() useEffect(() => { - if (pathName.includes("payment-callback")) { - return - } - updateRouteInfo(pathName, currentLang, searchParams) if (hasPathOrLangChanged()) {