scandic/web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: reduce the amount of section elements being used since most have no headers connected to them

Browse Source
This commit is contained in:
Christian Andolf
2025-04-28 14:47:26 +02:00
parent edc4f0c016
commit 32e95fcbbd
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/scandic-web/components/Blocks/DynamicContent/Stays/ListContainer/index.tsx
View File

@@ -1,5 +1,5 @@
import styles from "./container.module.css" import styles from "./container.module.css"
export default function ListContainer({ children }: React.PropsWithChildren) { export default function ListContainer({ children }: React.PropsWithChildren) {
return <section className={styles.container}>{children}</section> return <div className={styles.container}>{children}</div>
} }

4
apps/scandic-web/components/ContentType/HotelPage/Facilities/CardGrid/index.tsx
View File

@@ -26,7 +26,7 @@ export default function FacilitiesCardGrid({
} }
return ( return (
<section id={imageCard.card.id} className={styles.cardContainer}> <div id={imageCard.card.id} className={styles.cardContainer}>
<Grids.Stackable className={styles.desktopGrid}> <Grids.Stackable className={styles.desktopGrid}>
{facilitiesCardGrid.map((card: FacilityCardType) => ( {facilitiesCardGrid.map((card: FacilityCardType) => (
<Card {...card} key={card.id} className={getCardClassName(card)} /> <Card {...card} key={card.id} className={getCardClassName(card)} />
@@ -35,6 +35,6 @@ export default function FacilitiesCardGrid({
<Grids.Stackable className={styles.mobileGrid}> <Grids.Stackable className={styles.mobileGrid}>
<CardImage card={imageCard.card} imageCards={imageCard.images} /> <CardImage card={imageCard.card} imageCards={imageCard.images} />
</Grids.Stackable> </Grids.Stackable>
</section> </div>
) )
} }

4
apps/scandic-web/components/ContentType/HotelPage/Rooms/index.tsx
View File

@@ -36,7 +36,7 @@ export function Rooms({ rooms, preamble }: RoomsProps) {
className={styles.roomsContainer} className={styles.roomsContainer}
> >
<div ref={scrollRef} className={styles.scrollRef}></div> <div ref={scrollRef} className={styles.scrollRef}></div>
<div className={styles.sectionHeader}> <header className={styles.sectionHeader}>
<Typography variant="Title/md" className={styles.heading}> <Typography variant="Title/md" className={styles.heading}>
<h2> <h2>
{intl.formatMessage({ {intl.formatMessage({
@@ -49,7 +49,7 @@ export function Rooms({ rooms, preamble }: RoomsProps) {
<p>{preamble}</p> <p>{preamble}</p>
</Typography> </Typography>
)} )}
</div> </header>
<Grids.Stackable <Grids.Stackable
className={`${styles.grid} ${allRoomsVisible ? styles.allVisible : ""}`} className={`${styles.grid} ${allRoomsVisible ? styles.allVisible : ""}`}
> >

2
apps/scandic-web/components/TempDesignSystem/Grids/Stackable/index.tsx
View File

@@ -8,5 +8,5 @@ export default function Stackable({
columns, columns,
}: React.PropsWithChildren<StackableGridProps>) { }: React.PropsWithChildren<StackableGridProps>) {
const classNames = stackableGridVariants({ className, columns }) const classNames = stackableGridVariants({ className, columns })
return <section className={classNames}>{children}</section> return <div className={classNames}>{children}</div>
} }