fix(SW-219): review comments

This commit is contained in:
Chuma McPhoy
2024-09-16 08:53:44 +02:00
parent 68437356f0
commit 3151572108
2 changed files with 25 additions and 30 deletions

View File

@@ -22,9 +22,8 @@ export default function CardsGrid({
<Grids.Stackable> <Grids.Stackable>
{cards_grid.cards.map((card) => { {cards_grid.cards.map((card) => {
switch (card.__typename) { switch (card.__typename) {
case CardsGridEnum.Card: { case CardsGridEnum.Card:
if (card.isContentCard) { return card.isContentCard ? (
return (
<ContentCard <ContentCard
key={card.system.uid} key={card.system.uid}
title={card.heading || ""} title={card.heading || ""}
@@ -35,9 +34,7 @@ export default function CardsGrid({
backgroundImage={card.background_image} backgroundImage={card.background_image}
style="default" style="default"
/> />
) ) : (
} else {
return (
<Card <Card
theme={cards_grid.theme || "one"} theme={cards_grid.theme || "one"}
key={card.system.uid} key={card.system.uid}
@@ -48,8 +45,6 @@ export default function CardsGrid({
primaryButton={card.primaryButton} primaryButton={card.primaryButton}
/> />
) )
}
}
case CardsGridEnum.LoyaltyCard: case CardsGridEnum.LoyaltyCard:
return ( return (
<LoyaltyCard <LoyaltyCard

View File

@@ -1,11 +1,11 @@
import { VariantProps } from "class-variance-authority" import { VariantProps } from "class-variance-authority"
import { CardProps } from "@/components/TempDesignSystem/Card/card"
import { contentCardVariants } from "@/components/TempDesignSystem/ContentCard/variants" import { contentCardVariants } from "@/components/TempDesignSystem/ContentCard/variants"
import { ImageVaultAsset } from "@/types/components/imageVault" import { ImageVaultAsset } from "@/types/components/imageVault"
import type { CardProps } from "@/components/TempDesignSystem/Card/card"
export interface SidePeekButton { interface SidePeekButton {
title: string title: string
} }