scandic/web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: encoding find my booking cookie since next decodes when parsing

Browse Source 
this is done in order to handle emails containing plus signs
This commit is contained in:
Christian Andolf
2025-03-12 15:54:21 +01:00
committed by Michael Zetterberg
parent 550474dffe
commit 1a8a57599c
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/scandic-web/components/HotelReservation/FindMyBooking/index.tsx
View File

@@ -36,7 +36,7 @@ export default function FindMyBooking() {
onSuccess: (result) => { onSuccess: (result) => {
const values = form.getValues() const values = form.getValues()
const value = new URLSearchParams(values).toString() const value = new URLSearchParams(values).toString()
document.cookie = `bv=${value}; Path=/; Max-Age=30; Secure; SameSite=Strict` document.cookie = `bv=${encodeURIComponent(value)}; Path=/; Max-Age=30; Secure; SameSite=Strict`
router.push( router.push(
`/${lang}/hotelreservation/my-stay/${encodeURIComponent(result.refId)}` `/${lang}/hotelreservation/my-stay/${encodeURIComponent(result.refId)}`
) )

10
apps/scandic-web/components/HotelReservation/MyStay/accessBooking.test.ts
View File

@@ -29,7 +29,7 @@ describe("Access booking", () => {
confirmationNumber: "123456789", confirmationNumber: "123456789",
firstName: "Anonymous", firstName: "Anonymous",
lastName: "Booking", lastName: "Booking",
email: "logged-out@scandichotels.com", email: "logged+out@scandichotels.com",
}).toString() }).toString()
expect(accessBooking(loggedOut, "Booking", null, cookieString)).toBe( expect(accessBooking(loggedOut, "Booking", null, cookieString)).toBe(
ACCESS_GRANTED ACCESS_GRANTED
@@ -40,7 +40,7 @@ describe("Access booking", () => {
confirmationNumber: "123456789", confirmationNumber: "123456789",
firstName: "Anonymous", firstName: "Anonymous",
lastName: "Booking", lastName: "Booking",
email: "logged-out@scandichotels.com", email: "logged+out@scandichotels.com",
}).toString() }).toString()
expect(accessBooking(loggedOut, "Booking", user, cookieString)).toBe( expect(accessBooking(loggedOut, "Booking", user, cookieString)).toBe(
ERROR_FORBIDDEN ERROR_FORBIDDEN
@@ -50,7 +50,7 @@ describe("Access booking", () => {
const cookieString = new URLSearchParams({ const cookieString = new URLSearchParams({
confirmationNumber: "123456789", confirmationNumber: "123456789",
lastName: "Booking", lastName: "Booking",
email: "logged-out@scandichotels.com", email: "logged+out@scandichotels.com",
}).toString() }).toString()
expect(accessBooking(loggedOut, "Booking", null, cookieString)).toBe( expect(accessBooking(loggedOut, "Booking", null, cookieString)).toBe(
ERROR_BAD_REQUEST ERROR_BAD_REQUEST
@@ -99,7 +99,7 @@ const user: SafeUser = {
} }
const loggedOut: Guest = { const loggedOut: Guest = {
email: "logged-out@scandichotels.com", email: "logged+out@scandichotels.com",
firstName: "Anonymous", firstName: "Anonymous",
lastName: "Booking", lastName: "Booking",
membershipNumber: null, membershipNumber: null,
@@ -108,7 +108,7 @@ const loggedOut: Guest = {
} }
const loggedIn: Guest = { const loggedIn: Guest = {
email: "logged-in@scandichotels.com", email: "logged+in@scandichotels.com",
firstName: "Authenticated", firstName: "Authenticated",
lastName: "Booking", lastName: "Booking",
membershipNumber: "01234567890123", membershipNumber: "01234567890123",