From 0b4710f38016ebc2b275ef5f9c724da5d53f3953 Mon Sep 17 00:00:00 2001 From: Fredrik Thorsson Date: Thu, 28 Nov 2024 17:29:53 +0100 Subject: [PATCH] feat(SW-914): add enum --- .../SidePeeks/AboutTheHotel/index.tsx | 2 +- .../Parking/ParkingPrices/index.tsx | 19 ++++++++++++------- .../AccordionAmenities/Parking/index.tsx | 6 +++--- components/ContentType/HotelPage/data.ts | 4 ++-- .../TempDesignSystem/Divider/variants.ts | 2 +- .../components/hotelPage/sidepeek/parking.ts | 6 ++++++ types/enums/facilities.ts | 4 ++-- 7 files changed, 27 insertions(+), 16 deletions(-) diff --git a/components/ContentType/HotelPage/SidePeeks/AboutTheHotel/index.tsx b/components/ContentType/HotelPage/SidePeeks/AboutTheHotel/index.tsx index 436147a50..0537fda83 100644 --- a/components/ContentType/HotelPage/SidePeeks/AboutTheHotel/index.tsx +++ b/components/ContentType/HotelPage/SidePeeks/AboutTheHotel/index.tsx @@ -37,7 +37,7 @@ export default async function AboutTheHotelSidePeek({ socials={socials} ecoLabels={ecoLabels} /> - + {descriptions.descriptions.medium} {descriptions.facilityInformation} diff --git a/components/ContentType/HotelPage/SidePeeks/Amenities/AccordionAmenities/Parking/ParkingPrices/index.tsx b/components/ContentType/HotelPage/SidePeeks/Amenities/AccordionAmenities/Parking/ParkingPrices/index.tsx index b73bf17fe..0fa61798e 100644 --- a/components/ContentType/HotelPage/SidePeeks/Amenities/AccordionAmenities/Parking/ParkingPrices/index.tsx +++ b/components/ContentType/HotelPage/SidePeeks/Amenities/AccordionAmenities/Parking/ParkingPrices/index.tsx @@ -3,7 +3,10 @@ import { getIntl } from "@/i18n" import styles from "./parkingPrices.module.css" -import type { ParkingPricesProps } from "@/types/components/hotelPage/sidepeek/parking" +import { + type ParkingPricesProps, + Periods, +} from "@/types/components/hotelPage/sidepeek/parking" export default async function ParkingPrices({ data, @@ -17,20 +20,22 @@ export default async function ParkingPrices({ function getPeriod(period: string | undefined) { switch (period) { - case "Day": + case Periods.day: return day - case "Night": + case Periods.night: return night - case "AllDay": + case Periods.allDay: return allDay + default: + return "" } } - const filterdPeriods = data?.filter((filter) => filter.period !== "Hour") + const filteredPeriods = data?.filter((filter) => filter.period !== "Hour") return (
- {filterdPeriods?.map((parking) => ( + {filteredPeriods?.map((parking) => (
@@ -44,7 +49,7 @@ export default async function ParkingPrices({
{parking.startTime && parking.endTime && - parking.period !== "AllDay" && ( + parking.period !== Periods.allDay && (
{intl.formatMessage({ id: "From" })} diff --git a/components/ContentType/HotelPage/SidePeeks/Amenities/AccordionAmenities/Parking/index.tsx b/components/ContentType/HotelPage/SidePeeks/Amenities/AccordionAmenities/Parking/index.tsx index e063c719e..b70db205e 100644 --- a/components/ContentType/HotelPage/SidePeeks/Amenities/AccordionAmenities/Parking/index.tsx +++ b/components/ContentType/HotelPage/SidePeeks/Amenities/AccordionAmenities/Parking/index.tsx @@ -27,7 +27,7 @@ export default async function ParkingAmenity({ parking }: ParkingAmenityProps) {
    {data.numberOfChargingSpaces ? ( -
  • {`Number of charging points for electric cars: ${data.numberOfChargingSpaces}`}
    • +
  • {`${intl.formatMessage({ id: "Number of charging points for electric cars" })}: ${data.numberOfChargingSpaces}`}
    • ) : null}
  • {`${intl.formatMessage({ id: "Parking can be reserved in advance" })}: ${data.canMakeReservation ? intl.formatMessage({ id: "Yes" }) : intl.formatMessage({ id: "No" })}`}
    • {data.numberOfParkingSpots ? ( @@ -50,7 +50,7 @@ export default async function ParkingAmenity({ parking }: ParkingAmenityProps) { {intl.formatMessage({ id: "Weekday prices" })} - + {intl.formatMessage({ id: "Weekend prices" })} - + = { [FacilityEnum.GymTrainingFacilities]: IconName.Fitness, [FacilityEnum.KeyAccessOnlyToHealthClubGym]: IconName.Fitness, [FacilityEnum.FreeWiFi]: IconName.Wifi, + [FacilityEnum.MeetingArea]: IconName.Business, [FacilityEnum.MeetingRooms]: IconName.Business, [FacilityEnum.MeetingConferenceFacilities]: IconName.Business, [FacilityEnum.PetFriendlyRooms]: IconName.Pets, @@ -27,6 +28,7 @@ const facilityToIconMap: Record = { [FacilityEnum.DisabledParking]: IconName.Parking, [FacilityEnum.OutdoorTerrace]: IconName.OutdoorFurniture, [FacilityEnum.RoomService]: IconName.RoomService, + [FacilityEnum.LateCheckOutUntil1400Guaranteed]: IconName.Business, [FacilityEnum.LaundryRoom]: IconName.LaundryMachine, [FacilityEnum.LaundryService]: IconName.LaundryMachine, [FacilityEnum.LaundryServiceExpress]: IconName.LaundryMachine, @@ -281,8 +283,6 @@ const facilityToIconMap: Record = { [FacilityEnum.WideEntrance]: IconName.StarFilled, [FacilityEnum.WideRestaurantEntrance]: IconName.StarFilled, [FacilityEnum.WiFiWirelessInternetAccessAllScandic]: IconName.StarFilled, - [FacilityEnum.MeetingArea]: IconName.Business, - [FacilityEnum.LateCheckOutUntil1400Guaranteed]: IconName.Business, } export function mapFacilityToIcon(id: FacilityEnum): FC | null { diff --git a/components/TempDesignSystem/Divider/variants.ts b/components/TempDesignSystem/Divider/variants.ts index a9f25b044..06b683e94 100644 --- a/components/TempDesignSystem/Divider/variants.ts +++ b/components/TempDesignSystem/Divider/variants.ts @@ -13,7 +13,7 @@ export const dividerVariants = cva(styles.divider, { primaryLightSubtle: styles.primaryLightSubtle, subtle: styles.subtle, white: styles.white, - baseSurfaceSutbleHover: styles.baseSurfaceSubtleHover, + baseSurfaceSubtleHover: styles.baseSurfaceSubtleHover, }, opacity: { 100: styles.opacity100, diff --git a/types/components/hotelPage/sidepeek/parking.ts b/types/components/hotelPage/sidepeek/parking.ts index a4882783e..df2f4313b 100644 --- a/types/components/hotelPage/sidepeek/parking.ts +++ b/types/components/hotelPage/sidepeek/parking.ts @@ -1,5 +1,11 @@ import type { Hotel } from "@/types/hotel" +export enum Periods { + day = "Day", + night = "Night", + allDay = "AllDay", +} + export type ParkingAmenityProps = { parking: Hotel["parking"] } diff --git a/types/enums/facilities.ts b/types/enums/facilities.ts index f70da822b..2e9d0ae4d 100644 --- a/types/enums/facilities.ts +++ b/types/enums/facilities.ts @@ -148,6 +148,7 @@ export enum FacilityEnum { Lake0To1Km = 1865, LakeOrSea0To1Km = 245437, LaptopSafe = 5283, + LateCheckOutUntil1400Guaranteed = 324101, LaundryRoom = 326031, LaundryService = 1834, LaundryServiceExpress = 162583, @@ -155,6 +156,7 @@ export enum FacilityEnum { LifestyleConcierge = 162584, LuggageLockers = 324098, Massage = 348859, + MeetingArea = 1692, MeetingConferenceFacilities = 5806, MeetingRooms = 1017, MinibarInRoom = 5768, @@ -259,6 +261,4 @@ export enum FacilityEnum { WideEntrance = 2085, WideRestaurantEntrance = 2087, WiFiWirelessInternetAccessAllScandic = 5774, - MeetingArea = 1692, - LateCheckOutUntil1400Guaranteed = 324101, }