fix: enable localization of sidepeek params

This commit is contained in:
Arvid Norlin
2024-08-12 10:52:29 +02:00
parent 47c77b62d6
commit 04eb3c6d94
7 changed files with 49 additions and 9 deletions

View File

@@ -15,15 +15,13 @@ export default function SidePeekContainer({
const [activeSidePeek, setActiveSidePeek] =
useState<SidePeekContentKey | null>(() => {
const sidePeekParam = searchParams.get(
"sidepeek"
"open"
) as SidePeekContentKey | null
return sidePeekParam || null
})
useEffect(() => {
const sidePeekParam = searchParams.get(
"sidepeek"
) as SidePeekContentKey | null
const sidePeekParam = searchParams.get("open") as SidePeekContentKey | null
if (sidePeekParam !== activeSidePeek) {
setActiveSidePeek(sidePeekParam)
}
@@ -34,7 +32,7 @@ export default function SidePeekContainer({
setActiveSidePeek(null)
const nextSearchParams = new URLSearchParams(searchParams.toString())
nextSearchParams.delete("sidepeek")
nextSearchParams.delete("open")
router.push(`${pathname}?${nextSearchParams}`, { scroll: false })
}

View File

@@ -1,5 +1,6 @@
import { SidePeekContentKey } from "./types"
export const generateSidePeekLink = (key: SidePeekContentKey) => {
return `?sidepeek=${key}`
// what should the parameter be named to make sense in all use cases/languages? single caracter? like`s=`?
return `?open=${key}`
}