From 0011cbe8d2d18d860d50c83391c5076c271cd80d Mon Sep 17 00:00:00 2001 From: Hrishikesh Vaipurkar Date: Fri, 25 Apr 2025 07:06:53 +0000 Subject: [PATCH] Merged in fix/SW-2375-aa-tracking-critical-pageview- (pull request #1863) fix: SW-2375 Fixed object comparison in bookingflow params flag * fix: SW-2375 Fixed object comparison in bookingflow params flag Approved-by: Niclas Edenvin --- apps/scandic-web/components/TrackingSDK/RouterTracking.tsx | 6 +++--- apps/scandic-web/stores/tracking.ts | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/apps/scandic-web/components/TrackingSDK/RouterTracking.tsx b/apps/scandic-web/components/TrackingSDK/RouterTracking.tsx index 13789860d..ced0967fc 100644 --- a/apps/scandic-web/components/TrackingSDK/RouterTracking.tsx +++ b/apps/scandic-web/components/TrackingSDK/RouterTracking.tsx @@ -18,14 +18,14 @@ export default function RouterTracking() { setInitialPageLoadTime, updateRouteInfo, hasPathOrLangChanged, - hasBookingFlowParamsChange, + hasBookingFlowParamsChanged, } = useTrackingStore() const { startRouterTransition } = useRouterTransitionStore() useEffect(() => { updateRouteInfo(pathName, currentLang, searchParams) - if (hasPathOrLangChanged() || hasBookingFlowParamsChange()) { + if (hasPathOrLangChanged() || hasBookingFlowParamsChanged()) { setInitialPageLoadTime(Date.now()) trackPageViewStart() startTransition(() => { @@ -38,7 +38,7 @@ export default function RouterTracking() { currentLang, updateRouteInfo, hasPathOrLangChanged, - hasBookingFlowParamsChange, + hasBookingFlowParamsChanged, setInitialPageLoadTime, startRouterTransition, ]) diff --git a/apps/scandic-web/stores/tracking.ts b/apps/scandic-web/stores/tracking.ts index b7b42db11..6a4385efa 100644 --- a/apps/scandic-web/stores/tracking.ts +++ b/apps/scandic-web/stores/tracking.ts @@ -22,7 +22,7 @@ interface TrackingStoreState { params: ReadonlyURLSearchParams ) => void hasPathOrLangChanged: () => boolean - hasBookingFlowParamsChange: () => boolean + hasBookingFlowParamsChanged: () => boolean } const useTrackingStore = create((set, get) => ({ @@ -69,7 +69,7 @@ const useTrackingStore = create((set, get) => ({ return currentPath !== previousPath || currentLang !== previousLang }, - hasBookingFlowParamsChange: () => { + hasBookingFlowParamsChanged: () => { const { currentPath, currentParams, previousParams } = get() if (!previousParams || !currentParams) return false @@ -84,7 +84,7 @@ const useTrackingStore = create((set, get) => ({ searchParamsToRecord(currentParams) ) - return Object.is(previousParamsObject, currentParamsObject) + return !Object.is(previousParamsObject, currentParamsObject) }, }))