P5-3631 - Fix lint issues and use eslint on build

gulpfile.js

@@ -1,33 +1,54 @@
+'use strict';
+
 var gulp = require('gulp');
 var browserify = require('browserify');
 var buffer = require('vinyl-buffer');
 var rename = require('gulp-rename');
 var source = require('vinyl-source-stream');
-var jshint = require('gulp-jshint');
+var eslint = require('gulp-eslint');
 var qunit = require('gulp-qunit');
+var mkdirp = require('mkdirp');
+var del = require('del');
+var runSequence = require('run-sequence');
 
-gulp.task('build', function() {
+var outputPath = './dist';
+
+gulp.task('build', function (done) {
+  runSequence(
+    'clean-dist',
+    'create-dist',
+    'lint',
+    'compile',
+    done);
+});
+
+gulp.task('clean-dist', function () { return del(outputPath); });
+
+gulp.task('create-dist', function () { return mkdirp(outputPath); });
+
+gulp.task('compile', function() {
   return browserify('./src/main.js')
     .bundle()
     .pipe(source('main.js'))
     .pipe(buffer())
     .pipe(rename('image-editor.js'))
-    .pipe(gulp.dest('./dist'));
+    .pipe(gulp.dest(outputPath));
 });
 
-gulp.task('test', ['build'], function() {
+gulp.task('test', ['compile'], function() {
   return gulp.src('./test/index.html')
     .pipe(qunit({timeout: 1}));
 });
 
 gulp.task('lint', function() {
   return gulp.src(['./src/**/*.js', './test/unit/*.js'])
-    .pipe(jshint())
-    .pipe(jshint.reporter('default'));
+    .pipe(eslint())
+    .pipe(eslint.format())
+    .pipe(eslint.failAfterError());
 });
 
 gulp.task('watch', function() {
-  gulp.watch('./src/**/*.js', ['build']);
+  gulp.watch('./src/**/*.js', ['lint', 'compile']);
 });
 
-gulp.task('default', ['lint', 'build']);
+gulp.task('default', ['build']);