P5-3564 - Add eslint and run with --fix

.eslintrc

@@ -0,0 +1,34 @@
+{
+    "env": {
+        "browser": true,
+        "commonjs": true
+    },
+    "extends": ["eslint:recommended"],
+    "rules": {
+        "no-console": 0,
+        "strict": [
+            "error",
+            "safe"
+        ],
+        "indent": [
+            "error",
+            2
+        ],
+        "linebreak-style": [
+            "error",
+            "unix"
+        ],
+        "quotes": [
+            "error",
+            "single"
+        ],
+        "semi": [
+            "error",
+            "always"
+        ],
+        "comma-dangle": [
+            "error",
+            "only-multiline"
+        ]
+    }
+}

README.md

@@ -1,3 +1,8 @@
 Photowall Image Editor
 ======================
 Image editor for the Photowall web project
+
+# Linting
+Linting can be run manually with
+`npm run lint`
+

dist/image-editor.js

@@ -585,7 +585,7 @@ var Canvas = fabric.util.createClass(fabric.Canvas, {
     $.ajax({
       url: this.get3dUrl(),
       crossDomain: true,
-            type: "HEAD",
+      type: 'HEAD',
       cache: true,
     }).done(function() {
       fabric.Image.fromURL(encodeURI(this.get3dUrl()), function (img) {
@@ -2324,7 +2324,7 @@ module.exports = assertKeyValuePair;
 function calcCrop(obj, width, height, units) {
   var cropRatio = width / height;
   var objRatio = obj.width / obj.height;
-    var inchToCm = units === "inch" ? 2.54 : 1;
+  var inchToCm = units === 'inch' ? 2.54 : 1;
 
   var returnValue = {
     image: obj,

examples/.eslintrc

@@ -0,0 +1,7 @@
+{
+    "globals": {
+        "$": false,
+        "ImageEditor": false,
+        "QUnit": false
+    }
+}

gulpfile.js

@@ -1,5 +1,5 @@
 var gulp = require('gulp');
-var browserify = require('browserify')
+var browserify = require('browserify');
 var buffer = require('vinyl-buffer');
 var rename = require('gulp-rename');
 var source = require('vinyl-source-stream');

package.json

@@ -8,13 +8,17 @@
   },
   "devDependencies": {
     "browserify": "^13.1.1",
+    "eslint": "^5.14.1",
     "gulp": "^3.9.0",
+    "gulp-jshint": "^2.0.4",
+    "gulp-qunit": "^1.5.0",
+    "gulp-rename": "^1.2.2",
     "jshint": "^2.9.5",
     "qunit": "^1.0.0",
-    "gulp-jshint": "^2.0.4",
-    "gulp-rename": "^1.2.2",
     "vinyl-buffer": "^1.0.0",
-    "vinyl-source-stream": "^1.1.0",
-    "gulp-qunit": "^1.5.0"
+    "vinyl-source-stream": "^1.1.0"
+  },
+  "scripts": {
+    "lint": "eslint gulpfile.js 'examples/**/*.js' 'test/unit/**/*.js' 'src/**/*.js'"
   }
 }

src/.eslintrc

@@ -0,0 +1,7 @@
+{
+    "rules": {
+        "no-console":[
+            "error"
+        ]
+    }
+}

src/Canvas.js

@@ -220,7 +220,7 @@ var Canvas = fabric.util.createClass(fabric.Canvas, {
     $.ajax({
       url: this.get3dUrl(),
       crossDomain: true,
-            type: "HEAD",
+      type: 'HEAD',
       cache: true,
     }).done(function() {
       fabric.Image.fromURL(encodeURI(this.get3dUrl()), function (img) {

src/utils/calc-crop.js

@@ -15,7 +15,7 @@
 function calcCrop(obj, width, height, units) {
   var cropRatio = width / height;
   var objRatio = obj.width / obj.height;
-    var inchToCm = units === "inch" ? 2.54 : 1;
+  var inchToCm = units === 'inch' ? 2.54 : 1;
 
   var returnValue = {
     image: obj,

test/.eslintrc

@@ -0,0 +1,6 @@
+{
+    "globals": {
+        "QUnit": false,
+        "ImageEditor": false
+    }
+}